Received-SPF: pass (google.com: domain of linux-kernel+bounces-118500-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Sender: Ingo Molnar <mingo.kernel.org@gmail.com>
Date: Tue, 26 Mar 2024 09:00:37 +0100
From: Ingo Molnar <mingo@kernel.org>
To: Shrikanth Hegde <sshegde@linux.ibm.com>
Cc: peterz@infradead.org, vincent.guittot@linaro.org,
	dietmar.eggemann@arm.com, qyousef@layalina.io,
	linux-kernel@vger.kernel.org, vschneid@redhat.com
Subject: Re: [PATCH v3 0/2] sched: Minor changes for rd->overload access
Message-ID: <ZgKApcWeuwxc2+WO@gmail.com>
References: <20240325054505.201995-1-sshegde@linux.ibm.com>
 <ZgFTtAOw39tIyfzR@gmail.com>
 <3c92c18b-6a19-4477-9972-1219c29b3d71@linux.ibm.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <3c92c18b-6a19-4477-9972-1219c29b3d71@linux.ibm.com>


* Shrikanth Hegde <sshegde@linux.ibm.com> wrote:

> 
> 
> On 3/25/24 4:06 PM, Ingo Molnar wrote:
> > 
> > * Shrikanth Hegde <sshegde@linux.ibm.com> wrote:
> > 
> >> v2 -> v3:
> >> - Wrapped check for value change inside ser_rd_overload_status
> >>   as suggested by Qais.
> >> - Added reviewed-by tags.
> >>
> >> v1 -> v2:
> >> - dropped Fixes tag.
> >> - Added one of the perf probes in the changelog for reference.
> >> - Added reviewed-by tags.
> >>
> >> tl;dr
> >> When running workloads in large systems, it was observed that access to
> >> rd->overload was taking time. It would be better to check the value
> >> before updating since value changes less often. Patch 1/2 does that.
> >> With patch updates happen only if necessary. CPU Bus traffic reduced a
> >> bit. No significant gains in workload performance.
> > 
> > Could you please post this against the latest scheduler tree, ie. tip:sched/core?
> > 
> > Thanks,
> > 
> > 	Ingo
> 
> Hi Ingo. I had mentioned the same in cover letter. Sorry if I didn't 
> mention it in the correct place. 
> 
> *These patches depend on below to be applied first*
> https://lore.kernel.org/all/20240307085725.444486-1-sshegde@linux.ibm.com/
> 
> After that the above patch would apply.

OK, I missed that, but I don't really like patch #3 of that other series, 
so we'll need to address that first.

Thanks,

	Ingo