Received-SPF: pass (google.com: domain of linux-kernel+bounces-118509-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Sender: Ingo Molnar <mingo.kernel.org@gmail.com>
Date: Tue, 26 Mar 2024 09:05:58 +0100
From: Ingo Molnar <mingo@kernel.org>
To: Sandipan Das <sandipan.das@amd.com>
Cc: Ian Rogers <irogers@google.com>, linux-perf-users@vger.kernel.org,
	linux-kernel@vger.kernel.org, x86@kernel.org, peterz@infradead.org,
	acme@kernel.org, namhyung@kernel.org, mark.rutland@arm.com,
	alexander.shishkin@linux.intel.com, jolsa@kernel.org,
	adrian.hunter@intel.com, tglx@linutronix.de, bp@alien8.de,
	eranian@google.com, ravi.bangoria@amd.com, ananth.narayan@amd.com
Subject: Re: [PATCH 1/2] perf/x86/amd/core: Update stalled-cycles-* events
 for Zen 2 and later
Message-ID: <ZgKB5hMlt87E5VhI@gmail.com>
References: <cover.1711352180.git.sandipan.das@amd.com>
 <03d7fc8fa2a28f9be732116009025bdec1b3ec97.1711352180.git.sandipan.das@amd.com>
 <CAP-5=fVLWMnT4TV2nvbOUTTkWHYowbEOFDYqAvf1hkUEDpkKfw@mail.gmail.com>
 <5749c648-b6c4-4400-9628-3cd38d953f58@amd.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <5749c648-b6c4-4400-9628-3cd38d953f58@amd.com>


* Sandipan Das <sandipan.das@amd.com> wrote:

> On 3/25/2024 8:04 PM, Ian Rogers wrote:
> > On Mon, Mar 25, 2024 at 12:48 AM Sandipan Das <sandipan.das@amd.com> wrote:
> >>
> >> AMD processors based on Zen 2 and later microarchitectures do not
> >> support PMCx087 (instruction pipe stalls) which is used as the backing
> >> event for "stalled-cycles-frontend" and "stalled-cycles-backend". Use
> >> PMCx0A9 (cycles where micro-op queue is empty) instead to count frontend
> >> stalls and remove the entry for backend stalls since there is no direct
> >> replacement.
> >>
> >> Signed-off-by: Sandipan Das <sandipan.das@amd.com>
> > 
> > This looks good to me. Should there be a Fixes tag for the sake of backports?
> > 
> 
> My bad. Yes, there should a fixes tag.
> 
> Fixes: 3fe3331bb285 ("perf/x86/amd: Add event map for AMD Family 17h")
> 
> Ingo, I see that you have already pushed this to the perf/urgent branch.
> Should I send a v2?

That's OK, no need, I've amended the commits in perf/urgent. 2019 is quite 
a way back for a Fixes tag though. :-)

Thanks,

	Ingo