Date: Thu, 17 Jan 2008 23:06:38 +0100
From: Ingo Molnar <mingo@elte.hu>
To: Yinghai Lu <Yinghai.Lu@Sun.COM>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: copy srat table and unmap in acpi_parse_table
Message-ID: <20080117220638.GA18883@elte.hu>
References: <200801171244.46228.yinghai.lu@sun.com> <20080117204343.GA32175@elte.hu> <200801171409.56611.yinghai.lu@sun.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200801171409.56611.yinghai.lu@sun.com>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 939
Lines: 27


* Yinghai Lu <Yinghai.Lu@Sun.COM> wrote:

> > Or if d8d28f25f33c6a03 really needs to be reverted to get your 
> > system to boot properly, which particular bit of it was causing 
> > trouble for you? (or the whole thing?)
> 
> we need to call acpi_os_unmap_memory in acpi_table_parse or just after 
> it.
> 
> call it in acpi_table_parse is much cleaner

agreed - i had a second look at your patch and it's much cleaner.

> the problem is that acpi_numa_slit_init do bad assumaption that it 
> still can use address after it's callback function. so we need to copy 
> the slit.

ok. I've applied your patch and boot-tested it already - it should show 
up soon in the next x86.git drop.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/