Received-SPF: pass (google.com: domain of linux-kernel+bounces-118519-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <7b4a6d7f-76ad-471f-a178-dc598fbc0e22@quicinc.com>
Date: Tue, 26 Mar 2024 13:41:52 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v16 7/9] usb: dwc3: qcom: Refactor IRQ handling in glue
 driver
To: Johan Hovold <johan@kernel.org>
CC: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Rob Herring
	<robh+dt@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Wesley Cheng
	<quic_wcheng@quicinc.com>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        "Greg
 Kroah-Hartman" <gregkh@linuxfoundation.org>,
        Conor Dooley
	<conor+dt@kernel.org>,
        Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
        Felipe Balbi
	<balbi@kernel.org>, <devicetree@vger.kernel.org>,
        <linux-arm-msm@vger.kernel.org>, <linux-usb@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <quic_ppratap@quicinc.com>,
        <quic_jackp@quicinc.com>
References: <20240307062052.2319851-1-quic_kriskura@quicinc.com>
 <20240307062052.2319851-8-quic_kriskura@quicinc.com>
 <ZgFyukBXIIwZo7v-@hovoldconsulting.com>
 <50926b91-3c61-4dbf-85c9-7558ab96e628@quicinc.com>
 <ZgF6zvaT2OkrbkHK@hovoldconsulting.com>
 <807015d4-c5ed-4e04-9948-fd1ff894a04e@quicinc.com>
 <ZgHUR-Rk-YzqiTtt@hovoldconsulting.com>
Content-Language: en-US
From: Krishna Kurapati PSSNV <quic_kriskura@quicinc.com>
In-Reply-To: <ZgHUR-Rk-YzqiTtt@hovoldconsulting.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit


On 3/26/2024 1:15 AM, Johan Hovold wrote:

> Just change the logic in dwc3_qcom_find_num_ports() so that it returns 1
> if "dp_hs_phy_1" is missing, and otherwise you determine the number of
> ports by iterating from 2 to DWC3_MAX_PORTS - 1.

Hi Johan,

I made this change and it works. Removed any return value check for the 
find_num_ports call as it can return only 1/2/3/4 now.

---
     irq = platform_get_irq_byname_optional(pdev, "qusb2_phy");
         if (irq > 0)
                 return 1;

         irq = platform_get_irq_byname_optional(pdev, "dp_hs_phy_irq");
         if (irq > 0)
                 return 1;

         irq = platform_get_irq_byname_optional(pdev, "dp_hs_phy_1");
         if (irq <= 0)
                 return 1;

         for (port_index = 1; port_index < DWC3_MAX_PORTS - 1; 
port_index++) {
                 sprintf(irq_name, "dp_hs_phy_%d", port_index + 1);

                 irq = platform_get_irq_byname_optional(pdev, irq_name);
                 if (irq <= 0)
                         return port_index;
         }

         return DWC3_MAX_PORTS;

---

Let me know if this is fine and I can push out v17.

Regards,
Krishna,