Received: by 2002:ab2:6857:0:b0:1ef:ffd0:ce49 with SMTP id l23csp3182021lqp; Tue, 26 Mar 2024 01:46:45 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWwDOqvpkIDY/J/u5/sv0dGr9ywZyfo2B/8kVCOcJbQipBmFeRthBeO49f2rpjRP0uCSK9NrM0Ynob8YP3rbl9pWC9gGyewe/rYHG9QfQ== X-Google-Smtp-Source: AGHT+IGbzB6uPhGhONk0MdbTgpmZn2xGcAHPumqGtBN5uKJoaD2OanQckc5CmRn9b9CLw91MsVZM X-Received: by 2002:a50:aa8c:0:b0:56b:8dcd:acb5 with SMTP id q12-20020a50aa8c000000b0056b8dcdacb5mr8569366edc.39.1711442805473; Tue, 26 Mar 2024 01:46:45 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711442805; cv=pass; d=google.com; s=arc-20160816; b=eLdPWOJkpV/2RnopiBBEBAGXkNZhXrnv43zgmMCMdJdyjmrEfe5OiSVDuJwBObZ8oy 8T+vsPBtAmIMHzEF65NPmh1FGqjNEG9deDK6QoKoeKdOmXsp87z09iKY1TcYeIBk4aQS BdN0GHkdMhfqfwO1GNZ3oCXtebO0X7VnJtqwZZW/2E5ooQUsPIZ3H0DmscQre7jbi5d5 DdfLLiS+RVWKHJ5RlU0cfAfBCdwsOj04mOwlU4qKNg8Oxw1kGRUCJ2kt/GtgEbo6Tp2O PGEIE11SR8BhpsffHSYSJgZggyyGlGH6LjQVt4O/Atv++0HZfLZOKfZSj2NlzddgVq0P 8uBg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=oktKZgoRFXP8NpJ8HdKNagmPMD1Ba43WQLeL86GJPN4=; fh=o3m/kPXB2Xn26BJeM+GZjQvYXnb+fX/pRPqXL3zlY8Y=; b=aHwkAJRK0L9ib5I34JDAliUQJhWbT1avCPaf5qzIxLU9cPXUx1913lvjWRR6Tzl6uV NolSOeBuNIyy2FDDP7o2t2SnLTWmQcY5xqpgGm/a5uz5wfkWfh8viEeCMtBtVjdcwc/S 79wtE1LpWMHWe0vmlICRzBb6Yr+8izS02bBbmE+urSXM2KN/VNJtf3WevfoPIcWRl+si 3iSUrBklYL4d+O8EMkf/NDYcQSNxfi78ju0udYQWsvxzUQBxIsrNfbOPpV1JhNyArgZd 8ukgnQBYc5gHXxowc2984IkJu5dIeput2mFVqgh0g5biF5cmD5wBKoGmK53o6st4Qh45 iUUg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=fW9yzfvL; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-118567-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-118567-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id ds2-20020a0564021cc200b005673899d1basi3426086edb.257.2024.03.26.01.46.45 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Mar 2024 01:46:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-118567-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=fW9yzfvL; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-118567-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-118567-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 3491A1F39FE0 for ; Tue, 26 Mar 2024 08:46:45 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6959F14A8B; Tue, 26 Mar 2024 08:46:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fW9yzfvL" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B34CEEDB; Tue, 26 Mar 2024 08:46:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711442793; cv=none; b=l8H5/fBvNwx2NlHI1Qd/NPkX+74UB20vUawUsS+LtNUAKbSE/A6Ay3W5+Y+oVLsXtoW9KcT5lMXU0BomR7Hok+gwm/9dvFTpYW3EVSwXeL4gAg1iZV/9jZLhqschgDZaIF8PWg8v37h7b1Wg/AK9akTcquOfApVsEx/YPRont2g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711442793; c=relaxed/simple; bh=u+aZyQYa+tMPYo6GZURLmeeAY6gnUE+FlTJQQr16EjQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jul61FPYOKd/rR7xQF7+BjCuLEqzFOZYp6RDgjXfdR31IwOSRWddO6Vi7Ay0YSrXNdRcG0ztEV5ysYbWqGm8BOkBWhaXRa72+vxy7NLpd6utEhkuYRLq9mu3K12mCRUuWXpSY1bIvSLb5VlmvdDhB39IqtwoZh8ds6c17HltPAI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fW9yzfvL; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id F1F01C433F1; Tue, 26 Mar 2024 08:46:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711442792; bh=u+aZyQYa+tMPYo6GZURLmeeAY6gnUE+FlTJQQr16EjQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=fW9yzfvLq9W807c9iG4auL6tA2HKmi8Nqbn0YbZH0Rj6rTSW9LdnTUMUkHvjWra8x XI0mdqDXPDDfpGE6Sr6CfV8XjrTmh7MI9OKZviUUE01jwCrkBS78/qryPBbMyZZjxi 5RUd7FoXKCQeWUPlBDM/oiX5+apF3E3eJhfHleiByDBwjGZ63WBVih0OzeKRJZfXFp jkif2fJ7IbgpAF2d5YfqjWaAZmOaBYzDd3BUnY+ZttSGGEkC/rUxNzuAkxIMzmBH7o 8Fl51wrAm+U81BgOep+BT+0niCCv2v5OGimrmNMKPjlxbankFr81YNXa+vAPE3a/O1 kbXz3LLbUD0iQ== Message-ID: Date: Tue, 26 Mar 2024 09:46:26 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] platform/chrome: cros_ec_ucsi: Implement UCSI PDC driver To: Pavan Holla , Greg Kroah-Hartman , Heikki Krogerus Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Abhishek Pandit-Subedi References: <20240325-public-ucsi-h-v1-0-7c7e888edc0a@chromium.org> <20240325-public-ucsi-h-v1-3-7c7e888edc0a@chromium.org> Content-Language: en-US From: Krzysztof Kozlowski Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: <20240325-public-ucsi-h-v1-3-7c7e888edc0a@chromium.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 26/03/2024 00:37, Pavan Holla wrote: > Implementation of transport driver for UCSI. This driver will be used > if the ChromeOS EC implements a PPM. > > +static struct platform_driver cros_ucsi_driver = { > + .driver = { > + .name = DRV_NAME, > + .pm = &cros_ucsi_pm_ops, > + }, > + .probe = cros_ucsi_probe, > + .remove = cros_ucsi_remove, > +}; > + > +module_platform_driver(cros_ucsi_driver); > + > +MODULE_LICENSE("GPL"); > +MODULE_DESCRIPTION("UCSI driver for ChromeOS EC."); > +MODULE_ALIAS("platform:" DRV_NAME); You should not need MODULE_ALIAS() in normal cases. If you need it, usually it means your device ID table is wrong (e.g. misses either entries or MODULE_DEVICE_TABLE()). MODULE_ALIAS() is not a substitute for incomplete ID table. Using DRV_NAME here brings even more confusion... Best regards, Krzysztof