Received-SPF: pass (google.com: domain of linux-kernel+bounces-118577-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Tue, 26 Mar 2024 08:48:29 +0000
From: Conor Dooley <conor.dooley@microchip.com>
To: Allen Lin <allencl_lin@hotmail.com>
CC: Conor Dooley <conor@kernel.org>, Rob Herring <robh@kernel.org>,
	<dmitry.torokhov@gmail.com>, <krzysztof.kozlowski+dt@linaro.org>,
	<conor+dt@kernel.org>, <jikos@kernel.org>, <benjamin.tissoires@redhat.com>,
	<linux-input@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 1/4] dt-bindings: input: Add Himax HX83102J touchscreen
Message-ID: <20240326-whoever-spotter-1fe7ace35428@wendy>
References: <20240322085606.993896-1-allencl_lin@hotmail.com>
 <TY0PR06MB56116F0902017225C78EDDDD9E312@TY0PR06MB5611.apcprd06.prod.outlook.com>
 <20240322-mammary-boil-f9a4c347fba1@spud>
 <20240322183009.GA1227164-robh@kernel.org>
 <20240322-rectified-udder-fef9102f58da@spud>
 <TY0PR06MB56110ADEA805B68BE2B887069E352@TY0PR06MB5611.apcprd06.prod.outlook.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="MNNZ2t7NSNgD6OgC"
Content-Disposition: inline
In-Reply-To: <TY0PR06MB56110ADEA805B68BE2B887069E352@TY0PR06MB5611.apcprd06.prod.outlook.com>

--MNNZ2t7NSNgD6OgC
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Mar 26, 2024 at 01:46:56PM +0800, Allen Lin wrote:
> Conor Dooley <conor@kernel.org> =E6=96=BC 2024=E5=B9=B43=E6=9C=8823=E6=97=
=A5 =E9=80=B1=E5=85=AD =E4=B8=8A=E5=8D=882:34=E5=AF=AB=E9=81=93=EF=BC=9A
> >
> > On Fri, Mar 22, 2024 at 01:30:09PM -0500, Rob Herring wrote:
> > > On Fri, Mar 22, 2024 at 05:54:08PM +0000, Conor Dooley wrote:
> > > > On Fri, Mar 22, 2024 at 04:56:03PM +0800, Allen_Lin wrote:
> > > > > Add the HX83102j touchscreen device tree bindings documents.
> > > > > HX83102j is a Himax TDDI touchscreen controller.
> > > > > It's power sequence should be bound with a lcm driver, thus it
> > > > > needs to be a panel follower. Others are the same as normal SPI
> > > > > touchscreen controller.
> > > > >
> > > > > Signed-off-by: Allen_Lin <allencl_lin@hotmail.com>
> > > >
> > > > note to self/Krzysztof/Rob:
> > > > There was a previous attempt at this kind of device. This version l=
ooks
> > > > better but might be incomplete given there's a bunch more propertie=
s in
> > > > that patchset:
> > > > https://lore.kernel.org/all/20231017091900.801989-1-tylor_yang@hima=
x.corp-partner.google.com/
> > >
> > > Those don't look like properties we want coming back.
> >
> > Oh, I don't want most of them coming back either. There are some
> > supplies in there though that I think we would like to come back, no?
> > Maybe this particular device doesn't have any supplies, but that doesn't
> > really seem credible.
>=20
> We will use Firmware-name in Device Tree.

> For power supply settings, because there may be other device using
> same regulator.

If there are other devices using the same regulator is it more
important that you document it so that it doesn't get disabled by the
other users.

> We plan to define it as an optional property for user to control in
> next release.

I don't see how the regulator would not be required, the device doesn't
function without power.

Thanks,
Conor.

--MNNZ2t7NSNgD6OgC
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZgKL2AAKCRB4tDGHoIJi
0m2yAQCWBWCSYIcP5R7VCgO/0OcvwNyQA3V8xkXyyNTaF56DjAEA9p3hmjmzoWbc
Y3z2iIHDUeGgBDNtUNF2Uu9ALdlJ5AM=
=0xei
-----END PGP SIGNATURE-----

--MNNZ2t7NSNgD6OgC--