Received-SPF: pass (google.com: domain of linux-kernel+bounces-118686-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Tue, 26 Mar 2024 10:30:10 +0100
From: Greg KH <gregkh@linuxfoundation.org>
To: Kyle Tso <kyletso@google.com>
Cc: linux@roeck-us.net, heikki.krogerus@linux.intel.com, badhri@google.com,
	linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH v1] usb: typec: tcpm: Correct the PDO counting in pd_set
Message-ID: <2024032624-drizzle-coaster-c97f@gregkh>
References: <20240319074337.3307292-1-kyletso@google.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240319074337.3307292-1-kyletso@google.com>

On Tue, Mar 19, 2024 at 03:43:37PM +0800, Kyle Tso wrote:
> The index in the loop has already been added one and is equal to the
> number of PDOs to be updated when leaving the loop.

That says what is happening but not the issue that is being addressed.
What is the problem with the number being off by one?  Is this a "crash
the system" or merely "our accounting is wrong"?

thank,

greg k-h