Received-SPF: pass (google.com: domain of linux-kernel+bounces-118690-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Tue, 26 Mar 2024 10:34:35 +0100
From: Greg KH <gregkh@linuxfoundation.org>
To: Surong Pang <surong.pang@unisoc.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	Orson.Zhai@unisoc.com, Zhiyong.liu@unisoc.com,
	Surong.Pang@gmail.com
Subject: Re: [PATCH] usb: gadget: rndis: add multi packages support for rndis
Message-ID: <2024032615-smog-pardon-4d5f@gregkh>
References: <20240306054949.324172-1-surong.pang@unisoc.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240306054949.324172-1-surong.pang@unisoc.com>

On Wed, Mar 06, 2024 at 01:49:49PM +0800, Surong Pang wrote:
> As ncm, aggergate multi skb packages and transfer them at one URB.
> In USB2.0, the network throughput can be improved from about 18MB/S
> to 35MB/S.

Why is rndis still being used?  It's an insecure and obsolete protocol
that should not be used at all anywhere.  I keep trying to delete it
entirely, but need to go and write an active exploit to prove to people
just how bad it really is before I can do so...

Adding more functionality to it is not a good idea, what is wrong with
the other, built-in, networking protocols instead?  Why are you using
this old one still when there are so many better options out there?

thanks,

greg k-h