Received-SPF: pass (google.com: domain of linux-kernel+bounces-118691-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Tue, 26 Mar 2024 10:36:12 +0100
From: Greg KH <gregkh@linuxfoundation.org>
To: Surong Pang <surong.pang@unisoc.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	Orson.Zhai@unisoc.com, Zhiyong.liu@unisoc.com,
	Surong.Pang@gmail.com
Subject: Re: [PATCH] usb: gadget: rndis: add multi packages support for rndis
Message-ID: <2024032639-pope-tiling-340c@gregkh>
References: <20240306054949.324172-1-surong.pang@unisoc.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240306054949.324172-1-surong.pang@unisoc.com>

On Wed, Mar 06, 2024 at 01:49:49PM +0800, Surong Pang wrote:
> --- a/drivers/usb/gadget/function/rndis.c
> +++ b/drivers/usb/gadget/function/rndis.c
> @@ -39,6 +39,8 @@
>  
>  #include "rndis.h"
>  
> +static int max_out_pkts_per_xfer;
> +static int max_out_size_per_xfer;

Note, this will not work, you can't have device-specific variables as a
single entry, otherwise multiple devices at the same time will not work
at all.

thanks,

greg k-h