Received-SPF: pass (google.com: domain of linux-kernel+bounces-118705-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Subject: Re: [PATCH] irqchip/gic-v3-its: Fix double free on error
To: huangguanrui.hgr <huangguanrui.hgr@alibaba-inc.com>
CC: <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
	<maz@kernel.org>, <shannon.zhao@linux.alibaba.com>, <tglx@linutronix.de>
References: <aac642a4-85a1-6df4-1192-638ce0d5086e@huawei.com>
 <20240322023810.62914-1-huangguanrui.hgr@alibaba-inc.com>
From: Zenghui Yu <yuzenghui@huawei.com>
Message-ID: <661a577c-b4bb-e438-6ba5-6ed90b08649f@huawei.com>
Date: Tue, 26 Mar 2024 17:43:39 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.9.0
Precedence: bulk
MIME-Version: 1.0
In-Reply-To: <20240322023810.62914-1-huangguanrui.hgr@alibaba-inc.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 2024/3/22 10:38, huangguanrui.hgr wrote:
> We notice that:
> In its_vpe_irq_domain_alloc, its_vm is from args, But in its_vpe_irq_domain_free,
> its_vm is from domain->host_data.

They *should* point to the same its_vm structure.

> Will these two values be different? For example, when other bugs occur?

Of course they can be different if there are *bugs* but I guess you
won't get any further (e.g., you hit BUG_ON(vm != vpe->its_vm) in
its_vpe_irq_domain_free()). The right thing to do is fixing the bug
rather than papering over it.

Zenghui