Received-SPF: pass (google.com: domain of linux-kernel+bounces-118741-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <1a2b604e-6e1b-4da9-ac2f-e2f2c80054ce@amd.com>
Date: Tue, 26 Mar 2024 15:36:31 +0530
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/1] x86/elf: Add a new .note section containing Xfeatures
 information to x86 core files
Content-Language: en-US
To: Kees Cook <keescook@chromium.org>,
 "Balasubrmanian, Vignesh" <Vignesh.Balasubrmanian@amd.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
 "linux-toolchains@vger.kernel.org" <linux-toolchains@vger.kernel.org>,
 "mpe@ellerman.id.au" <mpe@ellerman.id.au>,
 "npiggin@gmail.com" <npiggin@gmail.com>,
 "christophe.leroy@csgroup.eu" <christophe.leroy@csgroup.eu>,
 "aneesh.kumar@kernel.org" <aneesh.kumar@kernel.org>,
 "naveen.n.rao@linux.ibm.com" <naveen.n.rao@linux.ibm.com>,
 "ebiederm@xmission.com" <ebiederm@xmission.com>,
 "x86@kernel.org" <x86@kernel.org>,
 "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
 "linux-mm@kvack.org" <linux-mm@kvack.org>,
 "Petkov, Borislav" <Borislav.Petkov@amd.com>,
 "George, Jini Susan" <JiniSusan.George@amd.com>, "matz@suse.de"
 <matz@suse.de>, "binutils@sourceware.org" <binutils@sourceware.org>,
 "jhb@freebsd.org" <jhb@freebsd.org>,
 "felix.willgerodt@intel.com" <felix.willgerodt@intel.com>
References: <20240314112359.50713-1-vigbalas@amd.com>
 <20240314112359.50713-2-vigbalas@amd.com> <202403140850.5659C0F4@keescook>
From: "Balasubrmanian, Vignesh" <vigbalas@amd.com>
In-Reply-To: <202403140850.5659C0F4@keescook>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?amlUNjFXNzJ3b1JHbk0ya1NSNjVHRVROR2FNc0pyT1c5QVh0Ky82clhLc1lQ?=
 =?utf-8?B?d1Q1Z05ITHlyQVhMVFJoUWNxdHlxUDluYk8vU1htd0g0TE41WkdFWHpTV3Bl?=
 =?utf-8?B?bURZclB0b3MvbWl0bmQ4cldPZ2Q4RDZUc3BQa2IyaHVTUXh3L2owbVJPTXN4?=
 =?utf-8?B?ZVlkaHZ3cUV3T1kvTjNaRUlRVExSazNiS09wZFBnWHlETGw3OVJCRUd3ak82?=
 =?utf-8?B?U0NsVFRNdDVEczJVeGY1b21xeEhxVDdUZHVoMjBrcGtrMkZSbEo5TU5RaVBR?=
 =?utf-8?B?bTNqUThQVVpvMkxkcHBYQ21nV2RNOXZqVUNuaU5JaUFiZTBvYzhnSElkT1lN?=
 =?utf-8?B?dFlpRU5sZUlJTE1BSGtxbWs4ZjhldU5MSzhNVWMzNEJMaFdxZW9lc3kxZWJD?=
 =?utf-8?B?aG84UzZ3ZVJpMzEyNEU3Sm5wT0xwQktaSTZhdHVuTEdEZzJMcXEvSkpnbHR2?=
 =?utf-8?B?Q2M1cE03T0JFSHNYRVFweDB3em5KWXIrK0tVT0JSK0ZLaXg4QnlpREhubzM0?=
 =?utf-8?B?SVhSVUZKODR3dC9OWi9vMG5sL2JBNlVDSFlXUnJaUGk2bUpWRmRnMFJpeFZG?=
 =?utf-8?B?R2JHQ3RmaVVGSlZlUWNSdGwwVUM2ZUtOWHVGcytLWWxBdnZUOElvN2g1dUZR?=
 =?utf-8?B?L1ZuWm1kYnlieUljSmJpdGtiWEdrWkx0VlFtci9MWUh4NkxWL0lwdjhDY2ZY?=
 =?utf-8?B?UTk0TTB2ekxhQ1FNamx4Vm5MM0VQV3hwUGJQc0pZL3Y2N3lqeitIbFRRem5F?=
 =?utf-8?B?dmdNUkF3WElZaGVjUHc5b2kxT2FYU0ZzbE05U2lFUjVzUG5IOHd1dUVHcklB?=
 =?utf-8?B?WkIyZDI0K1g2SlJhUHBjK3o1QmN5UUxtWHdrdWdwMk1vb2Z1cUxHQXE5OHVX?=
 =?utf-8?B?S0F2VnREZzRyS2ZaWFhEUGN5RlE3a3NRRGtUVW5BNi9FZzBZYTFuVDhMUFlF?=
 =?utf-8?B?anJ0bzQ5ZFgyN2tjTFpsRXhhVGROaUpVdkd1dnVzMEw1dE9ZUC9CblhPZ01y?=
 =?utf-8?B?d3ZIZnpiU3BTNm1FNFZrcGtmMGpFYno4R0M2R1d0QkVGM3NVTVN2N1haUXhj?=
 =?utf-8?B?ekYvWTVLUjEyZzNYclcyRjFnbjAwanZLbWtrZTJaMHRlWjQ0LzV1eFd1aVh2?=
 =?utf-8?B?dm9WQWs3dFMzYlVRTjVUTTZ6YjNUL0ViMnRFR3FlRERvRGdDa0FjQ0Zybktx?=
 =?utf-8?B?SndOKzNWTytKY0h4WVp6QkIzRk5GUW5YalRlQ0Q3Ymk1eVk3bDd1MmdPc3Y0?=
 =?utf-8?B?MG9XZGpGQ3R1UUpKbXhHQnRwMFdnVlJkeW9rTFRIK2QvNkhJeHVSN3F1ai9H?=
 =?utf-8?B?QkdhbGNwY3o1S3FHT0x6aVE0azNiV1RTYTBxaHIyVkxOQTRnRXZtT05IWXdq?=
 =?utf-8?B?Z3FMbjFCVUpmQ2xKWmhndE9JMVU2VkNwVHpBMVBnK3VQUEJjenNyTWx6Tm5H?=
 =?utf-8?B?TmxvUnJEakJ6Umw1em9CS1UwYUZnWFlpSEFtWGV0eUg4ZnJVSDVvUjRmZnQ5?=
 =?utf-8?B?c1dES05aeExxTjJrRjYvUVFjem94RDJ0TDJybzdTZ2g0RnllZFFzU0RNQXU0?=
 =?utf-8?B?ZjVJbWRXRFk5U1Yyb0tNblMxQ1JqWXJ2REtaZnFaVXBUVnNHejl0VjdZZGRZ?=
 =?utf-8?B?UDJWeHgrVUJNeGwxV0NaMTIvbnNLTU8zVVFPTnM2dXYrcEZLSHRoNThjVXdn?=
 =?utf-8?B?RmFEd2JDeTc5V3VwbE50S2kxekgzK3BoMUJQRGowN28vRW1HK0tGb1M3eFJI?=
 =?utf-8?B?NzREZEpHMnJuT1h4VjFYYVlDQ1Q5d1BXM1NTZy9ZY3RaL3oyVjc0ZXJJQVBF?=
 =?utf-8?B?ZFR3TzJHTEdHZUxzd1ZPSXJBcFRFVDdhT0NUcTBmaXVKc3UvTHhJWVZLQStD?=
 =?utf-8?B?MWVBWFA0U0dQTEw5Mi9YeXpJTVJiN2p5eFJCcHJ6QmFjdEFNTlhhTndrNnc5?=
 =?utf-8?B?SWNaSi9DcUVCUUFqOFN3dVFmL1Q0aTFRR3pkd2JPZ21qSDBxbTRoRDBRTlQ5?=
 =?utf-8?B?eGtDd0J6Q3VwZldzSlV0VkNYMTZraUF5Sk5kZU5OcVBSa0wyTE1NSzN0MVEy?=
 =?utf-8?B?d3h3L2R2dENkWXkwc3k5MTNPVFZkaXZnSlJZM1pCMGpXTTRheXNsYTNFOTNV?=
 =?utf-8?Q?PlXID0VRltIjHWIdRgRzUWh2n?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 88c1d0fd-4728-45ce-2f7f-08dc4d7c6ea0
X-MS-Exchange-CrossTenant-AuthSource: SJ1PR12MB6124.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Mar 2024 10:06:41.0119
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wgiD5X4SumZXyZv/PAUOXuuBwqnrLhGgQ/B8J4NVt7TzRBQA+Rc4JVRm/4LhcnclEB+3QSPVJ2nlXmkz18DTIg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB8555


> Otherwise looks reasonable, though I see Dave has feedback to address
> too. :)
>
> Thanks for working on this!
>
> -Kees
Thank you for the review.
I will address all this on next version.

thanks,
vigneshbalu.

> --
> Kees Cook