Received-SPF: pass (google.com: domain of linux-kernel+bounces-118744-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
MIME-Version: 1.0
References: <20240312165905.1764507-1-andriy.shevchenko@linux.intel.com> <20240325211915.GA1449994@bhelgaas>
In-Reply-To: <20240325211915.GA1449994@bhelgaas>
From: Mateusz K <mateusz.kaduk@gmail.com>
Date: Tue, 26 Mar 2024 11:06:38 +0100
Message-ID: <CAPf=4Rc2vQrWqcs=-ND3iOZFJyKE7FdPoqU9w6DKjoSaJo6KaQ@mail.gmail.com>
Subject: Re: [PATCH v1 1/1] mfd: intel-lpss: Switch over to MSI interrupts
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Lee Jones <lee@kernel.org>, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

I tried the patch that changes PCI_IRQ_LEGACY into PCI_IRQ_ALL_TYPES
and it seems I get some other error now

[    1.477341] intel-lpss 0000:00:15.0: enabling device (0004 -> 0006)
[    1.477466] intel-lpss 0000:00:15.0: can't derive routing for PCI INT A
[    1.477468] intel-lpss 0000:00:15.0: PCI INT A: not connected
[    1.477488] intel-lpss 0000:00:15.0: probe with driver intel-lpss
failed with error -2147483648
[    1.489572] intel-lpss 0000:00:15.2: enabling device (0004 -> 0006)
[    1.489688] intel-lpss 0000:00:15.2: can't derive routing for PCI INT C
[    1.489689] intel-lpss 0000:00:15.2: PCI INT C: not connected
[    1.489715] intel-lpss 0000:00:15.2: probe with driver intel-lpss
failed with error -2147483648
[    1.501886] intel-lpss 0000:00:19.0: enabling device (0004 -> 0006)
[    1.502034] intel-lpss 0000:00:19.0: can't derive routing for PCI INT A
[    1.502036] intel-lpss 0000:00:19.0: PCI INT A: not connected
[    1.502067] intel-lpss 0000:00:19.0: probe with driver intel-lpss
failed with error -2147483648
[    1.514288] intel-lpss 0000:00:19.1: enabling device (0004 -> 0006)
[    1.514535] intel-lpss 0000:00:19.1: can't derive routing for PCI INT B
[    1.514538] intel-lpss 0000:00:19.1: PCI INT B: not connected
[    1.514570] intel-lpss 0000:00:19.1: probe with driver intel-lpss
failed with error -2147483648
[    1.526291] intel-lpss 0000:00:1e.0: enabling device (0004 -> 0006)
[    1.526555] intel-lpss 0000:00:1e.0: can't derive routing for PCI INT A
[    1.526557] intel-lpss 0000:00:1e.0: PCI INT A: not connected
[    1.526604] intel-lpss 0000:00:1e.0: probe with driver intel-lpss
failed with error -2147483648
[    1.538130] intel-lpss 0000:00:1e.3: enabling device (0004 -> 0006)
[    1.538233] intel-lpss 0000:00:1e.3: can't derive routing for PCI INT D
[    1.538235] intel-lpss 0000:00:1e.3: PCI INT D: not connected
[    1.538253] intel-lpss 0000:00:1e.3: probe with driver intel-lpss
failed with error -2147483648

Mateusz

On Mon, Mar 25, 2024 at 10:19=E2=80=AFPM Bjorn Helgaas <helgaas@kernel.org>=
 wrote:
>
> [+bcc Mateusz]
>
> On Tue, Mar 12, 2024 at 06:59:05PM +0200, Andy Shevchenko wrote:
> > Some devices support MSI interrupts. Let's at least try to use them in
> > platforms that provide MSI capability.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> >  drivers/mfd/intel-lpss-pci.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/mfd/intel-lpss-pci.c b/drivers/mfd/intel-lpss-pci.=
c
> > index 8c00e0c695c5..c36a101df7be 100644
> > --- a/drivers/mfd/intel-lpss-pci.c
> > +++ b/drivers/mfd/intel-lpss-pci.c
> > @@ -54,7 +54,7 @@ static int intel_lpss_pci_probe(struct pci_dev *pdev,
> >       if (ret)
> >               return ret;
> >
> > -     ret =3D pci_alloc_irq_vectors(pdev, 1, 1, PCI_IRQ_LEGACY);
> > +     ret =3D pci_alloc_irq_vectors(pdev, 1, 1, PCI_IRQ_ALL_TYPES);
> >       if (ret < 0)
> >               return ret;
>
> I guess at least some of these devices do support INTx, since we
> always used INTx previously, right?
>
> There are a bunch of bug reports complaining about a lack of _PRT
> entries for them, e.g., these from
> https://bugzilla.kernel.org/show_bug.cgi?id=3D212261#c24:
>
>   intel-lpss 0000:00:15.0: enabling device (0004 -> 0006)
>   intel-lpss 0000:00:15.0: can't derive routing for PCI INT A
>   intel-lpss 0000:00:15.0: PCI INT A: not connected
>   intel-lpss: probe of 0000:00:15.0 failed with error -22
>   intel-lpss 0000:00:15.2: enabling device (0004 -> 0006)
>   intel-lpss 0000:00:15.2: can't derive routing for PCI INT C
>   intel-lpss 0000:00:15.2: PCI INT C: not connected
>   intel-lpss: probe of 0000:00:15.2 failed with error -22
>   intel-lpss 0000:00:19.0: enabling device (0004 -> 0006)
>   intel-lpss 0000:00:19.0: can't derive routing for PCI INT A
>   intel-lpss 0000:00:19.0: PCI INT A: not connected
>   intel-lpss: probe of 0000:00:19.0 failed with error -22
>   intel-lpss 0000:00:19.1: enabling device (0004 -> 0006)
>   intel-lpss 0000:00:19.1: can't derive routing for PCI INT B
>   intel-lpss 0000:00:19.1: PCI INT B: not connected
>   intel-lpss: probe of 0000:00:19.1 failed with error -22
>   intel-lpss 0000:00:1e.0: enabling device (0004 -> 0006)
>   intel-lpss 0000:00:1e.0: can't derive routing for PCI INT A
>   intel-lpss 0000:00:1e.0: PCI INT A: not connected
>   intel-lpss: probe of 0000:00:1e.0 failed with error -22
>   intel-lpss 0000:00:1e.3: enabling device (0004 -> 0006)
>   intel-lpss 0000:00:1e.3: can't derive routing for PCI INT D
>   intel-lpss 0000:00:1e.3: PCI INT D: not connected
>   intel-lpss: probe of 0000:00:1e.3 failed with error -22
>
> I don't know if these are a _PRT bug (I think if a device advertises a
> non-zero Interrupt Pin, the _PRT should tell us how it is routed), or
> possibly a device bug (advertises Interrupt Pin =3D=3D INTA when it shoul=
d
> advertise "no INTx used"), or something else.
>
> Bjorn