Received-SPF: pass (google.com: domain of linux-kernel+bounces-118769-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
References: <20240307214418.3812290-1-ipylypiv@google.com> <20240307214418.3812290-3-ipylypiv@google.com>
 <CAMuHMdWxVbT=f+kZ58urwGhYD9RfBnu7u8oLAyrx_riU8OGt0w@mail.gmail.com> <66ad274d-9890-411d-9fba-90fed2eb33f5@kernel.org>
In-Reply-To: <66ad274d-9890-411d-9fba-90fed2eb33f5@kernel.org>
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Tue, 26 Mar 2024 11:16:00 +0100
Message-ID: <CAMuHMdXA3dD=+oVgZ5cLdWdNHp+VdRCH0+L_kAPRQ0eaANAE+A@mail.gmail.com>
Subject: Re: [PATCH v8 2/7] scsi: libsas: Define NCQ Priority sysfs attributes
 for SATA devices
To: Damien Le Moal <dlemoal@kernel.org>
Cc: Igor Pylypiv <ipylypiv@google.com>, Niklas Cassel <cassel@kernel.org>, 
	John Garry <john.g.garry@oracle.com>, Jason Yan <yanaijie@huawei.com>, 
	"James E.J. Bottomley" <jejb@linux.ibm.com>, "Martin K. Petersen" <martin.petersen@oracle.com>, 
	Jack Wang <jinpu.wang@cloud.ionos.com>, Hannes Reinecke <hare@suse.de>, 
	Xiang Chen <chenxiang66@hisilicon.com>, Artur Paszkiewicz <artur.paszkiewicz@intel.com>, 
	Bart Van Assche <bvanassche@acm.org>, TJ Adams <tadamsjr@google.com>, linux-ide@vger.kernel.org, 
	linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Damien,

On Tue, Mar 26, 2024 at 11:07=E2=80=AFAM Damien Le Moal <dlemoal@kernel.org=
> wrote:
> On 3/26/24 18:53, Geert Uytterhoeven wrote:
> > On Thu, Mar 7, 2024 at 10:55=E2=80=AFPM Igor Pylypiv <ipylypiv@google.c=
om> wrote:
> >> Libata sysfs attributes cannot be used for libsas managed SATA devices
> >> because the ata_port location is different for libsas.
> >>
> >> Defined sysfs attributes (visible for SATA devices only):
> >> - /sys/block/sda/device/ncq_prio_enable
> >> - /sys/block/sda/device/ncq_prio_supported
> >>
> >> The newly defined attributes will pass the correct ata_port to libata
> >> helper functions.
> >>
> >> Reviewed-by: John Garry <john.g.garry@oracle.com>
> >> Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
> >> Reviewed-by: Jason Yan <yanaijie@huawei.com>
> >> Signed-off-by: Igor Pylypiv <ipylypiv@google.com>
> >
> > Thanks for your patch, which is now commit b4d3ddd2df7531e3 ("scsi:
> > libsas: Define NCQ Priority sysfs attributes for SATA devices")
> > in scsi-mkp/for-next
> >
> >> --- a/drivers/scsi/libsas/sas_ata.c
> >> +++ b/drivers/scsi/libsas/sas_ata.c
> >
> >> +
> >> +DEVICE_ATTR(ncq_prio_supported, S_IRUGO, sas_ncq_prio_supported_show,=
 NULL);
> >> +
> >
> > [...]
> >
> >> +
> >> +DEVICE_ATTR(ncq_prio_enable, S_IRUGO | S_IWUSR,
> >> +           sas_ncq_prio_enable_show, sas_ncq_prio_enable_store);
> >> +
> >
> > When both CONFIG_SCSI_SAS_ATA and CONFIG_SATA_HOST are enabled:
>
> I have both enabled in my config and I do not see any issue. What is spec=
ial
> with these on ARM ?

Modular or built-in?
I have them built-in, and it fails on arm64 (with renesas_defconfig,
which is not upstream).
It also fails with shmobile_defconfig on arm32, after manually adding
CONFIG_SCSI_SAS_LIBSAS=3Dy and CONFIG_SCSI_SAS_ATA=3Dy.

Gr{oetje,eeting}s,

                        Geert

--=20
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k=
org

In personal conversations with technical people, I call myself a hacker. Bu=
t
when I'm talking to journalists I just say "programmer" or something like t=
hat.
                                -- Linus Torvalds