Received-SPF: pass (google.com: domain of linux-kernel+bounces-118809-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <44d2e865-ee88-4054-a94e-06c6098bb0e1@amperemail.onmicrosoft.com>
Date: Tue, 26 Mar 2024 17:33:17 +0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 3/3] dt-bindings: hwmon: max31790: Add
 pwmout-pin-as-tach-input property
From: Chanh Nguyen <chanh@amperemail.onmicrosoft.com>
To: Rob Herring <robh@kernel.org>, Guenter Roeck <linux@roeck-us.net>,
 Chanh Nguyen <chanh@os.amperecomputing.com>
Cc: Jean Delvare <jdelvare@suse.com>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Conor Dooley <conor+dt@kernel.org>, Justin Ledford
 <justinledford@google.com>, devicetree@vger.kernel.org,
 linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
 OpenBMC Maillist <openbmc@lists.ozlabs.org>,
 Open Source Submission <patches@amperecomputing.com>,
 Phong Vo <phong@os.amperecomputing.com>,
 Thang Nguyen <thang@os.amperecomputing.com>,
 Quan Nguyen <quan@os.amperecomputing.com>
References: <20240311111347.23067-1-chanh@os.amperecomputing.com>
 <20240311111347.23067-4-chanh@os.amperecomputing.com>
 <20240311173438.GA1451467-robh@kernel.org>
 <ce8b2b49-b194-42f7-8f83-fcbf7b460970@amperemail.onmicrosoft.com>
Content-Language: en-US
In-Reply-To: <ce8b2b49-b194-42f7-8f83-fcbf7b460970@amperemail.onmicrosoft.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZmlkcjRLVHM4VFlPNTVwRmhNbkYvZWxRNDNQTjl3T21udGM5aHdyWjVtdndR?=
 =?utf-8?B?VGhNcHo4M21zSkR4UTJZTG01QVhScHgwOEFVRUNXUTJLbDZ5OEJick9lRDhp?=
 =?utf-8?B?c0FPbUtrY3hSdmYybWtGaEZ2WTlHSk9EYlViN1FmaWFkVy9aTEFWQ2ZzTUkw?=
 =?utf-8?B?WnFaWDZkcG9LaVRYRmcraE82Y1RKRmVDek5HVG4xRTZaaVc3SHlLaHU3ZEJB?=
 =?utf-8?B?YmJoVHdxVko2elFKQURBOVVjaUU5VXJMY1NLWUxYL2N4bTE0SmlHbEVIK1Rk?=
 =?utf-8?B?UXpkK2ZSNE0wdjk0cUtOM3B2VGFsM0J3QUlnVGl1SVhOVk9sNnlmdU5KZ0pJ?=
 =?utf-8?B?dTQ5VnIrM3dUZWRsQWJKTjEzdXRNOXpvT2puWVdlV1RUYlpIc0ZhaXJabi9Q?=
 =?utf-8?B?OTB6bWdiT0wyTnpPTlg4VUdxb0tncFJ0NGJpSkRXb01CRWREd1VkVDZZTnZ4?=
 =?utf-8?B?OGNEN3ZUMmxTaWswUWViOUlKMGlpMFEvV0tsRGY3MWdVbzNrNVV4dUJJWDJz?=
 =?utf-8?B?d2pzK1p3VU11UVBYdXpCeGVWdWtPc0ljNnFwV2dHRE9lZGJ0alZLTzhHYmMz?=
 =?utf-8?B?aWRZN1JMZGVldFhYUWR3SXNLZ3lRMmY4WHNzcmUzeEJnRWx4c3QyS2VscmF4?=
 =?utf-8?B?QWlJcFJKN3llZHdDTTRydlBmdi9LMGNKYUIwOXA1dzZ0YU9LSmw5aGoreTNu?=
 =?utf-8?B?Y3RaYkI4MGJoTHI1YmNYTDk0Myt5TFlTKy9HT1ljNEUxTG8rS1V3SHp1U2Vz?=
 =?utf-8?B?SkpUc1I4N0U1a2F1eDhaZEREV1hpYitjRU1UVGgvRDJwQW9hU1pYTGg2ckxh?=
 =?utf-8?B?N0NIMDVkVHBzY0NVbGVoUUlqNXE4OE1nU0lCWjBCQWdTNllLVEtJVlY3ODR5?=
 =?utf-8?B?Q1ZLeGFwb29oRjhFZ2E5NWV5b2poYTNsbHlldkZhemJvY0hjVjF4anRxQ1dh?=
 =?utf-8?B?Vmd0UzROQmc3VWpVOG5aQ3h0NzhGWEJwWEhHcjEycXlVMVMxTkdmSVppcTJp?=
 =?utf-8?B?SGQrT0UvbmZoN0k5d0JaSUdjcXhPUG9iN2hleFBza0dTSDdTclhhMTVLZjBq?=
 =?utf-8?B?Vnl4elNVZ0lEZCtGTkdkdGswZys5cVJpMlZFOTlnK3FuOFZjOHJQbnF3ODVo?=
 =?utf-8?B?QlVUS0ZoL2c4dUhOVnhFSW44Z3dWRkhjY2F0Z0NrNEZyYkVqL3dPUHpzNTh3?=
 =?utf-8?B?S1Yra2R0WXR1MmlqdjZsUlNnWGZ5MzJDc0hjdU5nSU9sRkVtbDhyakV6emFW?=
 =?utf-8?B?TlFPNkpqYUs5VUwyYndjNktyL3hzbFhrWEZqNWRtQmJvQXlmT3JTOTdCZTI0?=
 =?utf-8?B?Mk8wL2RBbjg2N3BocWVQZk1BNmNvZzBqM29PbnRtRm1GVjZNNGNjWUNSTGJ4?=
 =?utf-8?B?T2VXQkV4WWlTalAwRm16YkRnTE5oS3g2RnRhc1NHaTFBODA1Y2FHeGNKeGtk?=
 =?utf-8?B?MHdpQklST2loOEwyUlNyTnBSaTdTaHlnakFZTzErdjRXUFIyb3BoTHV4OXNV?=
 =?utf-8?B?OXVaMjNxSC96TWkrUU5xaDJ6dEp2bUdNK2l2bys2bEJJUWt3d2doV3JLa1Mv?=
 =?utf-8?B?ZkdDbDRxRWNRWkJubkZGWk9sTnM3U0dpblNzTVc3by83eDNsQXJnS2IydGs1?=
 =?utf-8?B?MEkwOTBmcmlPc1JqeGpkM1FlT2MyZG9kVTN3UW44L1J1Y0ZrWFBxOENNQVYx?=
 =?utf-8?B?ZHpLNWkxNXBteVRLZ0ZKTXpaRkpVZzQ1dkVWN2VjOUsza3k0Rk1CMEhrQ2FU?=
 =?utf-8?B?aFZGKzVBRkVVbk5GcDdPTVdzTkZHZi93bjFZbCtMUkF4WTZxUGtjc0ZRbnps?=
 =?utf-8?B?V3FoRk9mQ2tFQ0tmbFVjOVBFQnZlK242QkNhaFZxZWJhYmw4WStjMENNL2tL?=
 =?utf-8?B?ZlorV0dINmpVZURheHQ2dmQydFhUZ2lzQ0s3azVKRm03QnVTWHJndjdnbDRP?=
 =?utf-8?B?S1VwenlhWnpCOUY1eVpSTUdFMVVqTmdoR1YrbVkzTlROQTliNnk4ZWd3bitt?=
 =?utf-8?B?bCs5ODdQQWxPemdUdGpDVmowd2tueG1INnptYVlDMG1qNjE5U3NrZmx4T0Fu?=
 =?utf-8?B?OVZkTiszSnRzRkQwRXhZMDVBRU1NUUQ0Njcwa0Z5T3FRaE5OWDdyOURJY2tB?=
 =?utf-8?B?WEYrSnUvdXJzMjlTUEprTFBVdkkvZVd6bDFVeGl6TGdrTkpjWk1JbjZ0QmtI?=
 =?utf-8?Q?591KmzXJXKQIC5hEsvoy4ek=3D?=
X-OriginatorOrg: amperemail.onmicrosoft.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8c802408-97b6-42e1-4943-08dc4d802c1b
X-MS-Exchange-CrossTenant-AuthSource: DM6PR01MB5947.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Mar 2024 10:33:27.2490
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sVqnd+/G9XeypkAwpsZMDrqYiP1Pgv9MWXVbQqYFHbpAZ2NFLJV9lraokHvCjXgMPC8Yetv7gEIiN3BTHhgAUiIMrkhrVlP+KgxCO0I97vzSmUPB/KUkzfeybAkxmfcO
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR01MB7880


On 18/03/2024 16:53, Chanh Nguyen wrote:
> 
> 
> On 12/03/2024 00:34, Rob Herring wrote:
>> On Mon, Mar 11, 2024 at 06:13:47PM +0700, Chanh Nguyen wrote:
>>> Add pwmout-pin-as-tach-input property.
>>>
>>> Signed-off-by: Chanh Nguyen <chanh@os.amperecomputing.com>
>>> ---
>>>   Documentation/devicetree/bindings/hwmon/max31790.yaml | 11 +++++++++++
>>>   1 file changed, 11 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/hwmon/max31790.yaml 
>>> b/Documentation/devicetree/bindings/hwmon/max31790.yaml
>>> index 5a93e6bdebda..447cac17053a 100644
>>> --- a/Documentation/devicetree/bindings/hwmon/max31790.yaml
>>> +++ b/Documentation/devicetree/bindings/hwmon/max31790.yaml
>>> @@ -25,6 +25,16 @@ properties:
>>>     reg:
>>>       maxItems: 1
>>> +  pwmout-pin-as-tach-input:
>>> +    description: |
>>> +      An array of six integers responds to six PWM channels for
>>> +      configuring the pwm to tach mode.
>>> +      When set to 0, the associated PWMOUT produces a PWM waveform for
>>> +      control of fan speed. When set to 1, PWMOUT becomes a TACH input
>>> +    $ref: /schemas/types.yaml#/definitions/uint8-array
>>> +    maxItems: 6
>>> +    minItems: 6
>>
>> Seems incomplete. For example, fan tachs have different number of
>> pulses per revolution, don't you need to know that too?
>>
>> There's a common fan binding now (or pending). You should use that and
>> this property won't be needed.
>>
>> Rob
> 
> Thank Rob,
> 
> I checked in the 
> Documentation/devicetree/bindings/hwmon/fan-common.yaml. I found the 
> tach-ch property, but it seems define the tach channel used for fan.
> 
>    tach-ch:
>      description:
>        The tach channel used for the fan.
>      $ref: /schemas/types.yaml#/definitions/uint8-array
> 
> I would like to define a new vendor property to configure the PWM-OUT 
> pin to become a TACH-IN pin. So I introduce the 
> "maxim,pwmout-pin-as-tach-input" property. Please help me share your 
> comments!

Hi Guenter and Rob,

I'm preparing for patch v2. I'm looking forward to hear your advice. 
Should I use the "tach-ch" property (a common fan property) or define 
new vendor property ("maxim,pwmout-pin-as-tach-input") for my purpose?

Thank you very much!
Chanh