Received-SPF: pass (google.com: domain of linux-kernel+bounces-118842-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <9bea167d-edcf-4d66-8ec7-051e97c8dffd@linaro.org>
Date: Tue, 26 Mar 2024 12:00:05 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v4] thermal/drivers/tsens: Add suspend to RAM support for
 tsens
Content-Language: en-US
To: Priyansh Jain <quic_priyjain@quicinc.com>,
 Amit Kucheria <amitk@kernel.org>, Thara Gopinath <thara.gopinath@gmail.com>,
 Bjorn Andersson <andersson@kernel.org>,
 Konrad Dybcio <konrad.dybcio@linaro.org>,
 "Rafael J . Wysocki" <rafael@kernel.org>, Zhang Rui <rui.zhang@intel.com>,
 Lukasz Luba <lukasz.luba@arm.com>, linux-pm@vger.kernel.org,
 linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: quic_manafm@quicinc.com
References: <20240326074033.17002-1-quic_priyjain@quicinc.com>
From: Daniel Lezcano <daniel.lezcano@linaro.org>
In-Reply-To: <20240326074033.17002-1-quic_priyjain@quicinc.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 26/03/2024 08:40, Priyansh Jain wrote:
> As part of suspend to RAM, tsens hardware will be turned off.
> While resume callback, re-initialize tsens hardware.
> 
> Signed-off-by: Priyansh Jain <quic_priyjain@quicinc.com>
> ---
> V3 -> V4: Make tsens_reinit function specific to tsens v2. Add
> NULL resume callback support for platform whose versions < ver_2_x
> in tsens ops.
> V2 -> V3: Remove suspend callback & interrupt enablement part from
> resume callback.
> V1 -> V2: Update commit text to explain the necessity of this patch
> 
>   drivers/thermal/qcom/tsens-v0_1.c |  6 +++++
>   drivers/thermal/qcom/tsens-v1.c   |  3 +++
>   drivers/thermal/qcom/tsens-v2.c   |  1 +
>   drivers/thermal/qcom/tsens.c      | 37 +++++++++++++++++++++++++++++++
>   drivers/thermal/qcom/tsens.h      |  5 +++++
>   5 files changed, 52 insertions(+)
> 
> diff --git a/drivers/thermal/qcom/tsens-v0_1.c b/drivers/thermal/qcom/tsens-v0_1.c
> index 32d2d3e33287..7ed85379247b 100644
> --- a/drivers/thermal/qcom/tsens-v0_1.c
> +++ b/drivers/thermal/qcom/tsens-v0_1.c
> @@ -329,6 +329,7 @@ static const struct tsens_ops ops_8226 = {
>   	.init		= init_8226,
>   	.calibrate	= tsens_calibrate_common,
>   	.get_temp	= get_temp_common,
> +	.resume		= NULL,

As a static variable it is already set to NULL. Why do you need to 
explicitly set them everywhere ?

[ ... ]

> +#ifdef CONFIG_SUSPEND
> +static int tsens_reinit(struct tsens_priv *priv)
> +{
> +	unsigned long flags;
> +
> +	spin_lock_irqsave(&priv->ul_lock, flags);

What this lock is protecting ?

> +	if (tsens_version(priv) >= VER_2_X) {

May be move this test before the lock ?

> +		/*
> +		 * Re-enable the watchdog, unmask the bark.
> +		 * Disable cycle completion monitoring
> +		 */
> +		if (priv->feat->has_watchdog) {
> +			regmap_field_write(priv->rf[WDOG_BARK_MASK], 0);
> +			regmap_field_write(priv->rf[CC_MON_MASK], 1);
> +		}
> +
> +		/* Re-enable interrupts */
> +		tsens_enable_irq(priv);
> +	}
> +
> +	spin_unlock_irqrestore(&priv->ul_lock, flags);
> +
> +	return 0;
> +}
> +
> +int tsens_resume_common(struct tsens_priv *priv)
> +{
> +	if (pm_suspend_target_state == PM_SUSPEND_MEM)
> +		tsens_reinit(priv);
> +
> +	return 0;
> +}
> +
> +#endif /* !CONFIG_SUSPEND */


-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog