Received-SPF: pass (google.com: domain of linux-kernel+bounces-118851-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Content-Type: text/plain; charset="utf-8"
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20240319072712.133449-5-umang.jain@ideasonboard.com>
References: <20240319072712.133449-1-umang.jain@ideasonboard.com> <20240319072712.133449-5-umang.jain@ideasonboard.com>
Subject: Re: [PATCH v3 4/6] media: imx335: Use integer values for size registers
From: Kieran Bingham <kieran.bingham@ideasonboard.com>
Cc: Umang Jain <umang.jain@ideasonboard.com>, Tommaso Merciai <tomm.merciai@gmail.com>
To: Alexander Shiyan <eagle.alexander923@gmail.com>, Dave Stevenson <dave.stevenson@raspberrypi.com>, Sakari Ailus <sakari.ailus@linux.intel.com>, Umang Jain <umang.jain@ideasonboard.com>, open list <linux-kernel@vger.kernel.org>
Date: Tue, 26 Mar 2024 11:10:26 +0000
Message-ID: <171145142670.1011926.13962568934811871543@ping.linuxembedded.co.uk>
User-Agent: alot/0.10

Quoting Umang Jain (2024-03-19 07:27:10)
> Consider integer values for registers that are related to various
> sizes in the register map. This helps in improving the overall
> readability.
>=20
> No functional changes intended in this patch.

Thanks, I think this definitely helps readability here for these units.

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

>=20
> Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
> Reviewed-by: Tommaso Merciai <tomm.merciai@gmail.com>
> ---
>  drivers/media/i2c/imx335.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>=20
> diff --git a/drivers/media/i2c/imx335.c b/drivers/media/i2c/imx335.c
> index ae4341644a84..7609dbc537b1 100644
> --- a/drivers/media/i2c/imx335.c
> +++ b/drivers/media/i2c/imx335.c
> @@ -251,12 +251,12 @@ static const struct cci_reg_sequence mode_2592x1940=
_regs[] =3D {
>         {IMX335_REG_MODE_SELECT, 0x01},
>         {IMX335_REG_MASTER_MODE, 0x00},
>         {IMX335_REG_WINMODE, 0x04},
> -       {IMX335_REG_HTRIMMING_START, 0x0180},
> -       {IMX335_REG_HNUM, 0x0a20},
> -       {IMX335_REG_Y_OUT_SIZE, 0x0794},
> -       {IMX335_REG_AREA3_ST_ADR_1, 0x00b0},
> -       {IMX335_REG_AREA3_WIDTH_1, 0x0f58},
> -       {IMX335_REG_OPB_SIZE_V, 0x00},
> +       {IMX335_REG_HTRIMMING_START, 384},
> +       {IMX335_REG_HNUM, 2592},
> +       {IMX335_REG_Y_OUT_SIZE, 1940},
> +       {IMX335_REG_AREA3_ST_ADR_1, 176},
> +       {IMX335_REG_AREA3_WIDTH_1, 3928},
> +       {IMX335_REG_OPB_SIZE_V, 0},
>         {IMX335_REG_XVS_XHS_DRV, 0x00},
>         {CCI_REG8(0x3288), 0x21}, /* undocumented */
>         {CCI_REG8(0x328a), 0x02}, /* undocumented */
> --=20
> 2.43.0
>