Received-SPF: pass (google.com: domain of linux-kernel+bounces-118859-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Content-Type: text/plain; charset="utf-8"
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20240319072712.133449-6-umang.jain@ideasonboard.com>
References: <20240319072712.133449-1-umang.jain@ideasonboard.com> <20240319072712.133449-6-umang.jain@ideasonboard.com>
Subject: Re: [PATCH v3 5/6] media: imx335: Fix active area height discrepency
From: Kieran Bingham <kieran.bingham@ideasonboard.com>
Cc: Umang Jain <umang.jain@ideasonboard.com>
To: Alexander Shiyan <eagle.alexander923@gmail.com>, Dave Stevenson <dave.stevenson@raspberrypi.com>, Sakari Ailus <sakari.ailus@linux.intel.com>, Umang Jain <umang.jain@ideasonboard.com>, open list <linux-kernel@vger.kernel.org>
Date: Tue, 26 Mar 2024 11:15:34 +0000
Message-ID: <171145173466.1011926.14195824080886002217@ping.linuxembedded.co.uk>
User-Agent: alot/0.10

Quoting Umang Jain (2024-03-19 07:27:11)
> The imx335 reports a recommended pixel area of - 2592x1944.
> The driver supported mode however limits it to height=3D1940.
>=20
> Fix the height discrepency by correctly the value of height
> (with updates to vblank and mode registers).

"Fix the height discrepency by correcting the Y_OUT_SIZE,
HTRIMMING_START, and changing the WINMODE, followed by the corresponding
updates to reflect the new minimum vblanking periods."

I'm curious though - why does IMX335_REG_HTRIMMING_START jump /so/ much
here? Something to do with the WINMODE change?


Because I've seen this works and with the optional update to the commit
message:

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

>=20
> Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
> ---
>  drivers/media/i2c/imx335.c | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
>=20
> diff --git a/drivers/media/i2c/imx335.c b/drivers/media/i2c/imx335.c
> index 7609dbc537b1..10a09830dbd6 100644
> --- a/drivers/media/i2c/imx335.c
> +++ b/drivers/media/i2c/imx335.c
> @@ -247,13 +247,13 @@ static const int imx335_tpg_val[] =3D {
>  };
> =20
>  /* Sensor mode registers */
> -static const struct cci_reg_sequence mode_2592x1940_regs[] =3D {
> +static const struct cci_reg_sequence mode_2592x1944_regs[] =3D {
>         {IMX335_REG_MODE_SELECT, 0x01},
>         {IMX335_REG_MASTER_MODE, 0x00},
> -       {IMX335_REG_WINMODE, 0x04},
> -       {IMX335_REG_HTRIMMING_START, 384},
> +       {IMX335_REG_WINMODE, 0x00},
> +       {IMX335_REG_HTRIMMING_START, 48},
>         {IMX335_REG_HNUM, 2592},
> -       {IMX335_REG_Y_OUT_SIZE, 1940},
> +       {IMX335_REG_Y_OUT_SIZE, 1944},
>         {IMX335_REG_AREA3_ST_ADR_1, 176},
>         {IMX335_REG_AREA3_WIDTH_1, 3928},
>         {IMX335_REG_OPB_SIZE_V, 0},
> @@ -404,15 +404,15 @@ static const u32 imx335_mbus_codes[] =3D {
>  /* Supported sensor mode configurations */
>  static const struct imx335_mode supported_mode =3D {
>         .width =3D 2592,
> -       .height =3D 1940,
> +       .height =3D 1944,
>         .hblank =3D 342,
> -       .vblank =3D 2560,
> -       .vblank_min =3D 2560,
> +       .vblank =3D 2556,
> +       .vblank_min =3D 2556,
>         .vblank_max =3D 133060,
>         .pclk =3D 396000000,
>         .reg_list =3D {
> -               .num_of_regs =3D ARRAY_SIZE(mode_2592x1940_regs),
> -               .regs =3D mode_2592x1940_regs,
> +               .num_of_regs =3D ARRAY_SIZE(mode_2592x1944_regs),
> +               .regs =3D mode_2592x1944_regs,
>         },
>  };
> =20
> --=20
> 2.43.0
>