Received-SPF: pass (google.com: domain of linux-kernel+bounces-118862-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: tada keisuke <keisuke1.tada@kioxia.com>
To: "song@kernel.org" <song@kernel.org>,
        "yukuai3@huawei.com"
	<yukuai3@huawei.com>
CC: "linux-raid@vger.kernel.org" <linux-raid@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [PATCH 00/11] md: avoid counter operation conflicts
Thread-Topic: [PATCH 00/11] md: avoid counter operation conflicts
Thread-Index: Adp/Y1jSZkz1OENpR0iwTWSI17JctA==
Date: Tue, 26 Mar 2024 10:29:16 +0000
Message-ID: <a022f547c43e40e2b9f0aebb2bd0bfa8@kioxia.com>
Accept-Language: ja-JP, en-US
Content-Language: ja-JP
Content-Type: text/plain; charset="iso-2022-jp"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
MIME-Version: 1.0
X-CrossPremisesHeadersFilteredBySendConnector: CNN1EXMB04.r1.kioxia.com
X-OrganizationHeadersPreserved: CNN1EXMB04.r1.kioxia.com

Currently, active_aligned_reads and nr_pending used as counters are atomic =
types.
Therefore, when inc/dec in a multi-core results in conflicts.

To solve this problem, use "percpu_ref" counters that can avoid conflicts a=
nd maintain consistency.

Switch modes of percpu_ref to achieve both consistency and conflict avoidan=
ce.
During normal operations such as inc/dec, it operates as percpu mode.
When consistency is required, it operates as atomic mode.
The operations that require consistency are as follows:
=1B$B!&=1B(BZero check for the counter
=1B$B!&=1B(BAll operations in RAID 1/10

Patches 1, 3, 6 change active_aligned_reads, and patches 2, 4, 5, 7 to 11 c=
hange nr_pending.
nr_pending temporarily switch from percpu mode to atomic mode in patch 7.
This is to reduce the amount of changes from patches 8 to 10.
Finally, nr_pending switch from atomic mode to percpu mode in patch 11.

Keisuke TADA (11):
  add infra for active_aligned_reads changes
  add infra for nr_pending changes
  workaround for inconsistency of config state in takeover
  minimize execution of zero check for nr_pending
  match the type of variables to percpu_ref
  avoid conflicts in active_aligned_reads operations
  change the type of nr_pending from atomic_t to percpu_ref
  add atomic mode switching in RAID 1/10
  add atomic mode switching when removing disk
  add atomic mode switching when I/O completion
  avoid conflicts in nr_pending operations

 drivers/md/md-bitmap.c   |  2 +-
 drivers/md/md.c          | 40 +++++++++++++++---
 drivers/md/md.h          | 62 ++++++++++++++++++++++++----
 drivers/md/raid1.c       | 37 +++++++++++------
 drivers/md/raid10.c      | 60 ++++++++++++++++-----------
 drivers/md/raid5-cache.c |  4 +-
 drivers/md/raid5.c       | 89 +++++++++++++++++++++++++++-------------
 drivers/md/raid5.h       | 17 +++++++-
 8 files changed, 230 insertions(+), 81 deletions(-)


base-commit: fcf3f7e2fc8a53a6140beee46ec782a4c88e4744
--=20
2.34.1