Received-SPF: pass (google.com: domain of linux-kernel+bounces-118918-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Date: Tue, 26 Mar 2024 13:49:16 +0200 (EET)
To: Luke Jones <luke@ljones.dev>
cc: Hans de Goede <hdegoede@redhat.com>, corentin.chary@gmail.com, 
    platform-driver-x86@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/9] platform/x86: asus-wmi: add support for 2024 ROG
 Mini-LED
In-Reply-To: <9962eb39-23b8-470c-aab9-698f10c80358@app.fastmail.com>
Message-ID: <13a24576-da89-95b8-4ed2-c24b5ba54a21@linux.intel.com>
References: <20240325054938.489732-1-luke@ljones.dev> <20240325054938.489732-2-luke@ljones.dev> <2cadcf26-7b99-3b32-8441-1b3939cf93b4@linux.intel.com> <9962eb39-23b8-470c-aab9-698f10c80358@app.fastmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323328-123968063-1711453452=:1084"
Content-ID: <4af481a0-3df1-fb51-9340-c76dc95d2617@linux.intel.com>

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323328-123968063-1711453452=:1084
Content-Type: text/plain; CHARSET=ISO-8859-15
Content-Transfer-Encoding: QUOTED-PRINTABLE
Content-ID: <2fe8638a-8dad-ab77-13ea-f5eb0404094e@linux.intel.com>

On Tue, 26 Mar 2024, Luke Jones wrote:
> On Tue, 26 Mar 2024, at 2:47 AM, Ilpo J=E4rvinen wrote:
> > On Mon, 25 Mar 2024, Luke D. Jones wrote:
> >=20
> > > Support the 2024 mini-led backlight and adjust the related functions
> > > to select the relevant dev-id. Also add `available_mini_led_mode` to =
the
> > > platform sysfs since the available mini-led levels can be different.
> > >=20
> > > Signed-off-by: Luke D. Jones <luke@ljones.dev>
> > > ---

> > > @@ -2109,10 +2110,27 @@ static ssize_t mini_led_mode_show(struct devi=
ce *dev,
> > >  struct asus_wmi *asus =3D dev_get_drvdata(dev);
> > >  int result;
> > > =20
> > > - result =3D asus_wmi_get_devstate_simple(asus, ASUS_WMI_DEVID_MINI_L=
ED_MODE);
> > > - if (result < 0)
> > > - return result;
> > > + result =3D asus_wmi_get_devstate_simple(asus, asus->mini_led_dev_id=
);
> > > =20
> > > + /* Remap the mode values to match previous generation mini-led.
> > > + * Some BIOSes return -19 instead of 2, which is "mini-LED off", thi=
s
> > > + * appears to be a  BIOS bug.
> > > + */
> > > + if (asus->mini_led_dev_id =3D=3D ASUS_WMI_DEVID_MINI_LED_MODE2) {
> > > + switch (result) {
> > > + case 0:
> > > + result =3D 1;
> > > + break;
> > > + case 1:
> > > + result =3D 2;
> > > + break;
> > > + case 2:
> > > + case -19:
> >=20
> > Can you confirm this -19 really does come from BIOS? Because I suspect=
=20
> > it's -ENODEV error code from from one of the functions on the driver si=
de
> > (which is why I asked you to change it into -ENODEV).
>=20
> Yes it does. It is rather annoying. What happens in this case is that=20
> `2` is written to the WMI endpoint to turn off the MINI-Led feature,=20
> this works fine and it is turned off, there are no errors from the write=
=20
> at all - verifying the accepted limits in dsdt also shows it is correct.=
=20
>=20
> However, after that, the read fails once.

Hi,

I'm left a bit unsure how to interpret your response. If "read fails", it=
=20
would indicate that -ENODEV originates from asus_wmi_evaluate_method3(),=20
asus_wmi_get_devstate() or asus_wmi_get_devstate_bits(), not from BIOS? So=
=20
which way it is?

After reading some more code, I think I figured out the answer myself.
However, that raises another question... So lets now take a step back and=
=20
walk through the code:

Your patch does:
=09result =3D asus_wmi_get_devstate_simple(asus, asus->mini_led_dev_id);

asus_wmi_get_devstate_simple() calls asus_wmi_get_devstate_bits() with
ASUS_WMI_DSTS_STATUS_BIT mask that is 0x00000001.

If there's no error, retval is masked with that ASUS_WMI_DSTS_STATUS_BIT=20
forcing the return value to 0-1 range so:

a) I don't think -19 can originate from BIOS but comes from kernel side.
b) How can it ever return 2 (mini-LED off) ?????

> And only if that `2` was=20
> written. `0` and `1` write fine, and read fine also. I hope I've managed=
=20
> to describe and clarify what I'm seeing here.
>=20
> I'm happy to change -ENODEV. No problem, queued on my todo list.


--=20
 i.
--8323328-123968063-1711453452=:1084--