Received-SPF: pass (google.com: domain of linux-kernel+bounces-118927-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Tue, 26 Mar 2024 12:55:12 +0100
From: Petr =?UTF-8?B?VGVzYcWZw61r?= <petr@tesarici.cz>
To: Christoph Hellwig <hch@lst.de>
Cc: Petr Tesarik <petrtesarik@huaweicloud.com>, Marek Szyprowski
 <m.szyprowski@samsung.com>, Robin Murphy <robin.murphy@arm.com>, Petr
 Tesarik <petr.tesarik1@huawei-partners.com>, Michael Kelley
 <mhklinux@outlook.com>, Will Deacon <will@kernel.org>, open list
 <linux-kernel@vger.kernel.org>, "open list:DMA MAPPING HELPERS"
 <iommu@lists.linux.dev>, Roberto Sassu <roberto.sassu@huaweicloud.com>
Subject: Re: [PATCH v4 2/2] bug: introduce ASSERT_VAR_CAN_HOLD()
Message-ID: <20240326125512.430c1ed0@meshulam.tesarici.cz>
In-Reply-To: <20240326075606.GA10489@lst.de>
References: <20240325083105.658-1-petrtesarik@huaweicloud.com>
	<20240325083105.658-3-petrtesarik@huaweicloud.com>
	<20240326075606.GA10489@lst.de>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Tue, 26 Mar 2024 08:56:06 +0100
Christoph Hellwig <hch@lst.de> wrote:

> On Mon, Mar 25, 2024 at 09:31:05AM +0100, Petr Tesarik wrote:
> > From: Petr Tesarik <petr.tesarik1@huawei-partners.com>
> > 
> > Introduce an ASSERT_VAR_CAN_HOLD() macro to check at build time that a
> > variable can hold the given value.  
> 
> This really should be run past whoever maintains build_bug.h and
> also cc linux-kernel.  Please also split the addition and the user
> in swiotlb into separate patches.
> 
> I plan to pick up patch 1 for now, and wait for the discussion on
> this addition.

Fair enough. The use in swiotlb depends on patch 1 from this series,
but you're right, I can send the macro addition as a separate patch to
get some feedback.

Thank you!
Petr T