Received-SPF: pass (google.com: domain of linux-kernel+bounces-118957-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Tue, 26 Mar 2024 20:19:37 +0800
From: Inochi Amaoto <inochiama@outlook.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, 
	Inochi Amaoto <inochiama@outlook.com>, Vinod Koul <vkoul@kernel.org>, Rob Herring <robh@kernel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, 
	Chen Wang <unicorn_wang@outlook.com>, Paul Walmsley <paul.walmsley@sifive.com>, 
	Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>
Cc: Jisheng Zhang <jszhang@kernel.org>, Liu Gui <kenneth.liu@sophgo.com>, 
	Jingbao Qiu <qiujingbao.dlmu@gmail.com>, dlan@gentoo.org, dmaengine@vger.kernel.org, 
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org
Subject: Re: [PATCH v5 1/3] dt-bindings: dmaengine: Add dmamux for
 CV18XX/SG200X series SoC
Message-ID:
 <IA1PR20MB495344ACA27E700ABEE61878BB352@IA1PR20MB4953.namprd20.prod.outlook.com>
References: <IA1PR20MB4953E2937788D9D92C91ABBBBB352@IA1PR20MB4953.namprd20.prod.outlook.com>
 <57398ee0-212c-4c82-bfed-bf38f4faa111@linaro.org>
 <IA1PR20MB4953EDEEFC3128741F8E152EBB352@IA1PR20MB4953.namprd20.prod.outlook.com>
 <473528ac-dce2-41e3-a6d7-28f8c53a89ef@linaro.org>
 <IA1PR20MB4953517450F0E622A66E9A7DBB352@IA1PR20MB4953.namprd20.prod.outlook.com>
 <cf42e020-9a5b-48bb-bc14-c0cc9498627b@linaro.org>
 <IA1PR20MB4953EA589A0FF36DC6FCF0E8BB352@IA1PR20MB4953.namprd20.prod.outlook.com>
 <1525c377-af73-4204-8a2b-983c6d99316c@linaro.org>
 <IA1PR20MB4953D3A70237A5395E61C170BB352@IA1PR20MB4953.namprd20.prod.outlook.com>
 <f7f6fcd8-5f49-4685-8488-9d51bb1210f5@linaro.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f7f6fcd8-5f49-4685-8488-9d51bb1210f5@linaro.org>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: IA1PR20MB4953:EE_|CY8PR20MB5428:EE_
X-MS-Office365-Filtering-Correlation-Id: 787b2348-173c-42ff-07d4-08dc4d8efdba
X-MS-Exchange-SLBlob-MailProps:
	7J/vb0KDx3ghsXKwRy/t5h7NdWkXmzB0niMmniiG7D09qm7u3EBjVD9Ss2kFjN118O1TeSJ/L7Nm8bMSf381miSzr3+wXTNeeTiXkHXRbBPg6Itzw/GyPHL9K9g2OISzqt87eDk/dS3eWBJI8IGleh78EwHJ7hicnnBb46sJ/CMVkjPsEsM5C7ewEEtgnQLhLntMSqkR/jr71PLsGFZJqEXeHpnxnflpf2aWn5Rt2TeIc7HmErf/Tc1HlNo2dv3BIUVi0dM3NBRZ3fO57VUwoy6W+xdHuvnhbVAPXMxbXCuyww14dFWXvffjMHo2MKnSMTArD0I83U+P6JzRqV/eXvDMXlCMr9XcY+hFnKv3grqfihkoneDfksXvehcTI7VmM/RkgdcZWOF0yMZajNUBQKykMS3tqzsjJFyB804R+tkF1VBaVpZYRJddJRM98xM9ohduMO876d0CoVoylxp667uT2eagdFwn++Yh6wOZtEW+dWSzgpHrIBEPu+IW/zRmI3r25cXq0m7vReJreJEEfQl5P+O+7Q/WcuT2BK9IsxG+5awP7MILeKPEYVYM6vmPxgZ4nYsF4Q34RapCL3mqj9AHkdZrJezmDJH39JQuD9MDYgCaI4LsDqKPTo4sOFP4mWfXABRXLOhD+w920Q1C2hXXnd8+3BVDhn9dNO888GwFRV2wfmJigAU98SEJMyNmZRMPnUu0YZbuuvl7Lsn4UbWR8WAGHrXbuqQHho4o9NiTHdnSGvzUTC+GH2EHocs8hXZJDZ574yTOyaAuY5GdSZPP6kToD8GaCyHfYUpFvNk=
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	5bHJIwpv571ugmCeA55X/1fjb8m9guxxkEo2yN5/dPiTjVlP1AFTa3exKA8i86Pk+KVzY8MePZv6bwYnOGvw5E4JbI+XuP3Kvpw9zZD72QdyXkr8AI+0etvz/2oVOFEIHjwzaMwOPvCdj0rXCz01tmNviSgm0ihS7vpBXPnBIix1KRSDATG6sI1scoVyuayLGc96EHoSARJSfVnfOq4wtVHT2NaB/CzQ2RomvZrjonp44wX57PhfjWHZWA54tgJB/4kcs3gcHioS2RLsh5/nRlsZaPqcG44sYHopMRhsdbEMj3hPxs9ABM0gWOrXbcZ+4gW9B18riANLINft5VWp95SsGpEk7Rjib2BP60kNmz9TAKc8ZaP5Rnc4SC4++INlvOorqhKF9oj9PDMsclYTVNZVA2Mi7UNVXpFvxe8XE+R1MBVr2Y4kf835ZwnvZANTsR75xHAM7U1p9rqA++5n7waWa1uq+B0omxS9vTa//2ok+WJiGf2muezNbc+Bq3JR0YxwP1rdGv+9keBogLGGqq1ePCswer9lMFjpxHN4b66lhSgiz9bUuyFKr7pYCfGlkaLwWARghlBzWp+KcjN3/62/DN+LAsag8NjmBCn05NfdE76UluOK2jNb3snS2qSa
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?gpq0pi9EQZzzBEoH7olEmhj8YiIoijf/goZ5dneQnLsWB5bzUieHes9SrjxG?=
 =?us-ascii?Q?OrXP8J8aHMkVPJzaY8919VnSl+ol/KtwiCL67rH/IlX6GHTKZnJ12E6Iw0qO?=
 =?us-ascii?Q?9yP9vmApA1QNVrg8MkB8S4dS4uM7Pu5f3jY4b82sIrR9x0FP9Wr24g9Z0tqP?=
 =?us-ascii?Q?pIW6XClZZ9kUrhab5fA/VRXkhF3ATPNf/+QKX6ThtAMfqciJvorQYLLfL3lM?=
 =?us-ascii?Q?dDS7/WXCYm+4FGPwNkEWutv5rSMy3+s+0+0hj05vsh4QSQbY05J5GMz2AOIS?=
 =?us-ascii?Q?uRTVjH5bTWO7/IOCA1WlLp/xgMYWh/n1eifBhzzc9CZOsonKq3NUtj6JXEZq?=
 =?us-ascii?Q?7DeW7uxOQynIwmOMokWFSKp2E0eOH19YIRepr6vi5nMeErjKkcz0k86IVM33?=
 =?us-ascii?Q?aJYPmQs+zpUOL7Su6JBY36Xmbn3VY849Riwsn5OaXUgpU00Vpr24iGc4+sIF?=
 =?us-ascii?Q?OIAgn6hAZ4X3nSV+EZ8wVTMO4WriJ0ukH5H1HUaBtCadzDmFHoyRPZ49jJrK?=
 =?us-ascii?Q?8qq6lWBjLOh2LSqCC+yyjYZHB+TMjsI1z8etDCnaH33feA5mYD8U/9s8b1a/?=
 =?us-ascii?Q?2f7Ws1RdUKllZf9Ie7gdmyld1uJrrhm0cEuOLU5gtE6j5xRY0wPIZub6hL1f?=
 =?us-ascii?Q?o5h0OmXzjzT1sYH1hT7zgOsX6VLyvs87b007+MRVfzYaJe+YCDTMClJPNOXw?=
 =?us-ascii?Q?EiEWZxgGoCiLxKLB6sqOTTO3mPEG4chCPeuMDHfv65+0TIbuI/GGvpqT7o/q?=
 =?us-ascii?Q?NfatuPhMFSeujVxt9DGq7Rm8+XeUplYW9aHSv/RILLmm6xn4DAYdz97vSMet?=
 =?us-ascii?Q?66YhxA6nqoIdVngk1M9nU5lSsMnmK1V94ajaD2yTJG3VdvzKmv2Q//uqJFoS?=
 =?us-ascii?Q?tckJi8KYFg60SZwyBq1y1enQals1Na2zD6oc9CGivOzkTHm8WfOEL2e+dV20?=
 =?us-ascii?Q?IoMQwak6qVfCmPrr7jbri3dh9xAus4j6J73TdtmkFiRALTYIycfJVFvsaDGN?=
 =?us-ascii?Q?A/nfLz71VMYjCdBi9kePK/Aa/f25LU3oDyLpE55xKX05Ay4GEhZwp2NE1F+V?=
 =?us-ascii?Q?xyh988MobNiiqZ5jKMgeiR/653mh7GxpzcwWJ4fOCFdcpZDFW/ssd3iNO5/z?=
 =?us-ascii?Q?Xdd2b070r2j7Ea2E/qsML5yO5eGyvckczC61SQt71ACEVj+HNpVBekMrZU6q?=
 =?us-ascii?Q?c1aZjdRBSWf8tpyIXYe5ozzgdu+5nUJkvl5OcUWF5niTrWkWOgPASxCvDmSV?=
 =?us-ascii?Q?thi7N48f/KDimr2wgx/4?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 787b2348-173c-42ff-07d4-08dc4d8efdba
X-MS-Exchange-CrossTenant-AuthSource: IA1PR20MB4953.namprd20.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Mar 2024 12:19:32.1146
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR20MB5428

On Tue, Mar 26, 2024 at 01:14:12PM +0100, Krzysztof Kozlowski wrote:
> On 26/03/2024 13:06, Inochi Amaoto wrote:
> e.
> >>>> +	regmap_set_bits(dmamux->regmap,
> >>>> +			DMAMUX_CH_REG(chid),
> >>>> +			DMAMUX_CH_SET(chid, devid));
> >>>> +
> >>>> +	regmap_update_bits(dmamux->regmap, CV1800_SDMA_DMA_INT_MUX,
> >>>> +			   DMAMUX_INT_CH_MASK(chid, cpuid),
> >>>> +			   DMAMUX_INT_CH_BIT(chid, cpuid));
> >>>
> >>> I think this is.
> >>
> >> So where exactly? I don't see any define being used here.
> >> CV1800_SDMA_DMA_INT_MUX is not in your header. DMAMUX_ is not in your
> >> header. So what are you pointing?
> >>
> >> I don't understand this communication. Are you mocking me here or what?
> >> It's waste of my time.
> >>
> > 
> > I apologize for my misunderstanding and your wasted time. I had 
> > previously thought that hardware constants is also binding. This 
> > leads to a weird communication between us. Since I agree and 
> > understand this file is not a binding, I will remove this file in
> > the next version. Anyway, thanks for your kindly explanation.
> 
> OK, no problem. When I asked where do you use header, it should make you
> think... remove the #include from the driver and everything still
> compiles, so obviously header is not being used.
> 
> Best regards,
> Krzysztof
> 

Thanks, I will think and do this for the future patch.

Regards,
Inochi