Received-SPF: pass (google.com: domain of linux-kernel+bounces-118958-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <c4d03bf6-feab-40cd-a9f7-b31e8ff60a69@intel.com>
Date: Tue, 26 Mar 2024 13:20:28 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next v5 17/21] lib/bitmap: add tests for IP tunnel
 flags conversion helpers
To: Yury Norov <yury.norov@gmail.com>
CC: "David S. Miller" <davem@davemloft.net>, Eric Dumazet
	<edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni
	<pabeni@redhat.com>, Michal Swiatkowski <michal.swiatkowski@linux.intel.com>,
	Marcin Szycik <marcin.szycik@linux.intel.com>, Wojciech Drewek
	<wojciech.drewek@intel.com>, Andy Shevchenko <andy@kernel.org>, "Rasmus
 Villemoes" <linux@rasmusvillemoes.dk>, Alexander Potapenko
	<glider@google.com>, Jiri Pirko <jiri@resnulli.us>, Ido Schimmel
	<idosch@nvidia.com>, Przemek Kitszel <przemyslaw.kitszel@intel.com>, "Simon
 Horman" <horms@kernel.org>, <linux-btrfs@vger.kernel.org>,
	<dm-devel@redhat.com>, <ntfs3@lists.linux.dev>, <linux-s390@vger.kernel.org>,
	<intel-wired-lan@lists.osuosl.org>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
References: <20240201122216.2634007-1-aleksander.lobakin@intel.com>
 <20240201122216.2634007-18-aleksander.lobakin@intel.com>
 <Zd9hmZaMIcip4ndA@yury-ThinkPad>
From: Alexander Lobakin <aleksander.lobakin@intel.com>
Content-Language: en-US
In-Reply-To: <Zd9hmZaMIcip4ndA@yury-ThinkPad>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q2FlVitkTXBIRmhXaGtMS1VpV0dBRGY3MzR2UTJkekNIQ0JDUFNEMmE1S1Na?=
 =?utf-8?B?NDVhZHRLelp4WEVJNFlGL2VKdm5ENGVnNHdWM0N1YnRUM09xb1BCNVQvRWly?=
 =?utf-8?B?UTZNdDlVUitHUkV2SUZHUTFiNXhCTS9TWHcvSjJrYnkrMlVVWDhhNkNoTE1j?=
 =?utf-8?B?VTZPb0ExYzE0cXM4L1hTNER6SFVRS08zMGRhME83RjEwZ04wWDFXZkw3ZERY?=
 =?utf-8?B?NkVZalV2dmNMRXU4TVNjRUh3ekJ0Q214b2JuQ2wzTVJraGdkbExyNE5MWHpE?=
 =?utf-8?B?Z0gzN3V2MWZCdHUvV0lHNlhwWDB1T1p0WmxEdXdqTTJzNXhVV1kzOUFUSnpH?=
 =?utf-8?B?L2N4QmJ6YkorOTVpa3VaaTVSN0NjVXNkclYwL0ZXem1KZlpNRE53VTlsYjcw?=
 =?utf-8?B?SXpreEJxakNOTUcxZ3FuQ2o1bnFYQmwva2JOSjduUDN1WGpmVlpqOW9Nbk9W?=
 =?utf-8?B?L24xeWp4WUtWbVVpVUhBTjdSdUxQWU9RQUpUWEtFelQwdEM1bzhXTEU4VWhG?=
 =?utf-8?B?QWFsYmN1NFZkRnF3TWlXVXhzUGlrWms3UWpRNkVFN2laVHVmWlhFQ0tlT29w?=
 =?utf-8?B?MGxPM1IxUjYySlRNazhLRXBRckJIeTIzcEJCbkwyOEg3Q1dtS1JCampQRjhy?=
 =?utf-8?B?WXR5bW5TNnRPWnk4MGxzem9YNlI2RUNPSzNaenhkNDVWQk95UlZHSk9hQ2Jp?=
 =?utf-8?B?dU9oMGRKb1NKeWdtOTZmL1ltK0FPQTVPVlZrUW5HM0VwUjZDdDl3YWtPZDdD?=
 =?utf-8?B?SThEYjVOckVKZjdjam5FWWZ2LzhmTGs4OEx6NW9iYktVNzZIYUF1c2dDcU5M?=
 =?utf-8?B?OGxaVmpwVy9ld2lBOVhNNWRsd2FJMHJTZWNpQ3FKWDE3ZjdyRjdDZkNmQ1Nt?=
 =?utf-8?B?OTBDYlJNZjhBU3ROSC91NkR1aXNkSDdwOVVRZFo5bFBGRGsxTEoyemhYMGFT?=
 =?utf-8?B?R3ZseldxaWY0VzVFRlZHbWRybnpveXRaU0E0Rmk4Ylp6OVBSaC9KTkFuWFI0?=
 =?utf-8?B?YXdoTldnT3BPNmk4L2FURWdveU5JNkQ1eDA0VEVKOUNJK2xRaFgrWEIvUklx?=
 =?utf-8?B?VjRkWjBLMDBaM2Z1azkzUWFHZzVJL3RJN3dzSklDTENQcjBKQjFJUDlhdElm?=
 =?utf-8?B?dHMrc0Q4SGxMa3FKajJzbDJDa0FyeE5ucDdFekJJNkpHNkRKRzVsN0hOQk9w?=
 =?utf-8?B?NDF2YjRJdUFOekJnOTVpY2QyT2xHZDI4YmFiSEhucU1YM3JaTCtrZTViSXhu?=
 =?utf-8?B?aVl2QzhEZXB6UkhiSW53VXpEd0VOZ2dxblQ2TGpKeVZGd3Rwd1dpamRNWlhp?=
 =?utf-8?B?aDFKZVNiL0dreEZ4NXlrRFo2SXduOHduVVNhTWdJTEoxU052M2VtVjRjMEc1?=
 =?utf-8?B?K2VoTXJ5Q1pxZHR5REovTGFkOVVveDhVZXdrZUZaMTNNdnJRTHRxYldaRTBX?=
 =?utf-8?B?RnZtUnRIbUJtT2svdUs5NW5Ob3BVSjRnVzdid0RrMGVxTnVZcDhVTG9WZHF3?=
 =?utf-8?B?MTVCVWkxRWs2ZGZsbURmZmZmUERXZUdJc09OdUJsdnFEeDBNaFFmODdlemIz?=
 =?utf-8?B?a3ZGWkMxMzZOemYxV3pwVExwWWprWXIvdjIxMXBabUVQZGEwa0lKbEFRT2VP?=
 =?utf-8?B?c0pwZnBkNGVaKzB3NFROSXphZWt1NUkzZ1RrcWdmSUhlS0syVUk1TUkzMElL?=
 =?utf-8?B?QnZvbHVzTFFTZFRwODNyZ1V6eEUyV2I0M2VLNmpWcHRFa3JXVTFDemN2S0ZS?=
 =?utf-8?B?TWtmNzMzZHdGSS9lMG5GTjFmdmFTSzFpNHZkYW5wenlCMm9aOUFvWWgxaCtT?=
 =?utf-8?B?d2h4Q3lpSnZYVkU5ak95aTBSL0VnNUU3bVVIWkJrOEdrTGpLMXhLZDR3eGhk?=
 =?utf-8?B?RkU5ZE5ZVStraWpMU29NaWV0Nk9tVmNxTDJGWGVDZWpzK2lYeG1GbFhjd3Va?=
 =?utf-8?B?L0RyUWlGR0MzRS9nZW5Jc0dsOEk1ajV3K1AvS1JHbzFSSnNYL2FHRVpZQitr?=
 =?utf-8?B?K0VnS1BBZkhrZnlPV09LOU5YRUhjRy9TYzlCV05TeURLUm9qL3hSNThLRGdm?=
 =?utf-8?B?d3g4NVZrTTBEc0pkYUxybkY5Y0I0QU1YdVFTU25NVFhKYVBESEI0R2x3bkFL?=
 =?utf-8?B?dklsUGZQQlBzWEtkM2tjQktZQnoxK0tTckdSMXdXN04vakdwMHJwTjRTNmZO?=
 =?utf-8?B?THc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6ddcdc94-0892-4944-6a88-08dc4d8f23ef
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB8718.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Mar 2024 12:20:36.0801
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: itRBogoD2uLVRkVGOkLo2TOCl/DAoZQZr/HNrfbJ2b4cT5eWW/0YeRmjo0HItJCodiSFz60Ab3ZYGQ2NqXZMymg18lrbxwIVsmovVUNZx/k=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6365
X-OriginatorOrg: intel.com

From: Yury Norov <yury.norov@gmail.com>
Date: Wed, 28 Feb 2024 08:38:49 -0800

> On Thu, Feb 01, 2024 at 01:22:12PM +0100, Alexander Lobakin wrote:
>> Now that there are helpers for converting IP tunnel flags between the
>> old __be16 format and the bitmap format, make sure they work as expected
>> by adding a couple of tests to the bitmap testing suite. The helpers are
>> all inline, so no dependencies on the related CONFIG_* (or a standalone
>> module) are needed.
>>
>> Cover three possible cases:
>>
>> 1. No bits past BIT(15) are set, VTI/SIT bits are not set. This
>>    conversion is almost a direct assignment.
>> 2. No bits past BIT(15) are set, but VTI/SIT bit is set. During the
>>    conversion, it must be transformed into BIT(16) in the bitmap,
>>    but still compatible with the __be16 format.
>> 3. The bitmap has bits past BIT(15) set (not the VTI/SIT one). The
>>    result will be truncated.
>>    Note that currently __IP_TUNNEL_FLAG_NUM is 17 (incl. special),
>>    which means that the result of this case is currently
>>    semi-false-positive. When BIT(17) is finally here, it will be
>>    adjusted accordingly.
>>
>> Signed-off-by: Alexander Lobakin <aleksander.lobakin@intel.com>
> 
> So why testing IP tunnels stuff in lib/test_bitmap? I think it should
> go with the rest of networking code.

When I was creating these tests, there was no networking-specific KUnit,
but now we have one, so it makes sense to move it.

Thanks,
Olek