Received-SPF: pass (google.com: domain of linux-kernel+bounces-119025-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Tue, 26 Mar 2024 14:00:34 +0100
From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Rob Herring <robh@kernel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, 
	Tony Lindgren <tony@atomide.com>, devicetree@vger.kernel.org, linux-omap@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] dt-bindings: hsi: nokia-modem: convert to YAML
Message-ID: <6fs52p67hlgvnwfsmbdh3asv4rv3dew5kgbhpcvwbbtkxk4csv@2pbwotxezgs2>
References: <20240325-hsi-dt-binding-v1-0-88e8e97c3aae@collabora.com>
 <20240325-hsi-dt-binding-v1-2-88e8e97c3aae@collabora.com>
 <58ec79cc-150e-4fef-bb4b-9d29901e9a04@linaro.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="znisws7tnra4zv4t"
Content-Disposition: inline
In-Reply-To: <58ec79cc-150e-4fef-bb4b-9d29901e9a04@linaro.org>


--znisws7tnra4zv4t
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Tue, Mar 26, 2024 at 08:21:05AM +0100, Krzysztof Kozlowski wrote:
> On 25/03/2024 22:45, Sebastian Reichel wrote:
> > Convert the legacy txt binding to modern YAML.
> > No semantic change.
> >=20
> > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> > ---
> >  .../devicetree/bindings/hsi/nokia-modem.txt        |  59 ------------
> >  .../devicetree/bindings/hsi/nokia-modem.yaml       | 101 +++++++++++++=
++++++++
> >  2 files changed, 101 insertions(+), 59 deletions(-)
> >=20
>=20
>=20
> > -};
> > diff --git a/Documentation/devicetree/bindings/hsi/nokia-modem.yaml b/D=
ocumentation/devicetree/bindings/hsi/nokia-modem.yaml
> > new file mode 100644
> > index 000000000000..c57cbcc7b722
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/hsi/nokia-modem.yaml
>=20
> Filename should match compatibles. nokia,n9-modem.yaml or nokia,modem.yaml

Ack, I will switch to nokia,modem.yaml in v2.

> > @@ -0,0 +1,101 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/hsi/nokia-modem.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Nokia modem
> > +
> > +maintainers:
> > +  - Sebastian Reichel <sre@kernel.org>
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - nokia,n900-modem
> > +      - nokia,n950-modem
> > +      - nokia,n9-modem
> > +
>=20
> Aren't hsi-channel-ids related to hsi-channel-names? If so, they
> should be here with constraints.

Indeed. I forgot them, since they were not in the old binding :)
I will constraint them to min/max items 4 in v2.

> > +  hsi-channel-names:
> > +    items:
> > +      - const: mcsaab-control
> > +      - const: speech-control
> > +      - const: speech-data
> > +      - const: mcsaab-data

[...]

> > +examples:
> > +  - |
> > +    #include <dt-bindings/gpio/gpio.h>
> > +    #include <dt-bindings/interrupt-controller/irq.h>
> > +    hsi-client {
>=20
> This should be "modem".

Ack.

>=20
> > +        compatible =3D "nokia,n900-modem";
> > +

Thanks for the review,

-- Sebastian

--znisws7tnra4zv4t
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmYCxu0ACgkQ2O7X88g7
+ppX/hAAhXkf0s9bqwd4TCVkEl7HVkqaHaUsDMZz6WmOTXc22K3BeJ/DGO0vfTU0
Bb4VEqv8BldN/a2nz6u0AsKVgQ+ca3WYiT2H1O+ykBE5kFSxqzZxY0PNJBmJasLM
u7YDRQpOFWMcNcDXo1ZFuXwMuomsxw93j+kAMzZtQYk2roQdSFBTatG6Roj1AfcE
m0NEWgpjteNyx+d2r+zExF/sLEr8/GL4L5erDKETk6uKRoorRUvz+ZI9EBi+7hWM
RQMBGbBW+kUEDz6YYsI9AFElCBQv1qQwh3cxjUh/gR1ScHkpVYovQ4P0Z0rAyDvh
rswzG21MnPZNfOPWPhTn9CkZ7qkNw6drCiFNLaPzObhvBm9G6fRZX7CByPqnWQaO
C2KQXJF+53eWDaRfnftURVdiH/NdgE2q2pw7LG1bUF/wKTqfqN0ARfDQ6JYmWeFG
K9mIGgZQxhI9etRrlR7k+enFRVM8eJnT524b8cTLhyw4Cv2o3B/avIGxU3bnyTsB
M3DBYU75Xg1OESy6wTv/noc5thyyCiLJS+uSqcvwyi6UYOBGJFe9O3m1Dz3RA0A7
c4tzgtrIq8ny5UO6UugOKpyGZd3meYhlyKwpgWdpqGMPgY45mkE091NL/Rki0v+1
HjwqkxgZ3uEJC9ZfU8LuVFg8q78F61zkj2vADJInlaslT3xkS/o=
=pXTQ
-----END PGP SIGNATURE-----

--znisws7tnra4zv4t--