Received-SPF: pass (google.com: domain of linux-kernel+bounces-119060-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <0ba9914d-7060-498a-beac-2b19770e1963@oracle.com>
Date: Tue, 26 Mar 2024 13:32:09 +0000
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2] scsi: libsas: Allocation SMP request is aligned to
 ARCH_DMA_MINALIGN
To: Damien Le Moal <dlemoal@kernel.org>, Yihang Li <liyihang9@huawei.com>,
        yanaijie@huawei.com, jejb@linux.ibm.com, martin.petersen@oracle.com,
        chenxiang66@hisilicon.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        linuxarm@huawei.com, prime.zeng@huawei.com, yangxingui@huawei.com
References: <20240326124358.2466259-1-liyihang9@huawei.com>
 <5b5b9392-7fd2-4c87-8e41-5e54adf20003@kernel.org>
Content-Language: en-US
From: John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <5b5b9392-7fd2-4c87-8e41-5e54adf20003@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?aC9VTnlLRklqUGRhY3JrWU80clg4Rk45OHU5ZDByYlBFSnRCVkVCZmgzaVMr?=
 =?utf-8?B?QmExcE1FVUJEaHU1V2lGeitOSUI4MFlFSWZxbDcrYkM5UVJueDV6S3FGOXNt?=
 =?utf-8?B?SDlaem14SE5LK2M3TGFybWhKaEtVY3RSbWtLcGFneXhkZkxFK09lOUlOK0pC?=
 =?utf-8?B?M0Z4NldxV2p5U0kvLzYwc252NzgzNFhNVmJjUGhUWXNPdlpsUVpzMTBvYWhi?=
 =?utf-8?B?dXE0dzJzUEliemZSU2xRL0ZJMlJhbWlsRGJ1RVAzMTlva2JNbnhyQytMcUtZ?=
 =?utf-8?B?OTdRcUhrMXRUeFFnV296RDN1MTVrcGpyc0ltTXI0YW9RdzVITTNlRDd2K1Fz?=
 =?utf-8?B?S0lTb1B1WDR2YUViQ3I1YU1wUFR6MjE5NVdCblZEVkJ6ZTdZdnRMRkZUMlk2?=
 =?utf-8?B?RzRnRE9JQmRzeW1XUm12OHBoc3ZQVVVxcU8raVRXV1lZaXRmSFdNS1UxZVFE?=
 =?utf-8?B?dEZGM1VMeWtTMzNVOVQ4L1FhUkFFYitaemhWNHlaL21wTDY1QjdpRnBlbFFh?=
 =?utf-8?B?aW5qUnl2WmM3YUZwUitDM1BxdTZGOHVZbFd5Vm4zZGR6QXBLanNWdXZFV0d3?=
 =?utf-8?B?UGl3TjFlSXMxbUFmMHpnYnJzQ0l1VjRwSzRjbGIwTkd6aTluaWFuVDhYMFA0?=
 =?utf-8?B?YmFKU2MweWxyU3k5SmZyZ2lBZnpUVzVZSUp5Q1JlYlRzWVN1SWtPU20rZ3la?=
 =?utf-8?B?SWtJc1Vwb05yR0t3UTdsV1FPQTdXdDZkdWpoNHdnQm5vTXU5RDFNaTdEWHNM?=
 =?utf-8?B?L3VzUytMdXBTS094R0IybVV4Y1RLRFB0SVNxR2tMNHpUSkNiSml5R1Fkbjdx?=
 =?utf-8?B?U1dsOWpxbXJwQzVZT25id0JLeWVocGdzYXR6OWdVd1c2QWV2QWc0Vy9lVXNy?=
 =?utf-8?B?aHhJZzJWVHhTY0d2Vk12OGxXS0RndXNkMXoyeExPeDRMRFBMUDJwaFJVbnRa?=
 =?utf-8?B?TUJLVXh0MzNQRDdUYnhPeUZ4ajFvdWVmZ3IwU0RjSStIV1RoTjdESnllSi9H?=
 =?utf-8?B?dVJYODNjOGw5Z2RrVWtvNlgxQVNTRmp3MnhzZU5lbnVVL1hpRWI1OTBFU2tN?=
 =?utf-8?B?QzlVY3k0M2E0UXNZbDBXQWtWVkpndWdZK2NNdkxqVFpBTjJBeE9kT0tnWUt0?=
 =?utf-8?B?a3RMeTVRUUlEdU9sWHErcTQ1eHFOM2xVWkhMWDFnQWtnTU5wV1pycGVnYWZq?=
 =?utf-8?B?OUVTYkdVM3h0UnVjUitnSEMvR3JuVFVYUU9YOVh4RGRnQ2c5eldLSkREQTJr?=
 =?utf-8?B?NkFIZVNLdXEwMlorSDNSS3FNVkwwVEhKWjZ0TUVKYzlHVmZCZW1hTWdwOFFD?=
 =?utf-8?B?Q0M4clpnajlJV29zNVFKR21JdUJJRHFvb2lpZUo5T2VaWjlFK1Q2WTkrUTFK?=
 =?utf-8?B?MnhHcFZZT2hSSUJrWFJ4M0JJQ012OHROb2ZCREluSnBqenZVWkhOTnRBVmZy?=
 =?utf-8?B?blFUTDhOS08rUmlvaUQ5OE9PNlNjd04zYXh0dms0OERHa3A4NE4wcHlrSzNL?=
 =?utf-8?B?cExudTRYd1YzVElKT0hsbWZRaytZZDB6Mzczc2sxNDdqcU9iamtjM0lPVGZY?=
 =?utf-8?B?S0ptd0JCMXpQT0ZsTGtBM1owdFhGanVXK0M2Tk5JWWVYeE9zaVpGbXlpcTUz?=
 =?utf-8?B?OHBZNkcreVpXU0l6c0pPckg1ZHF0UGpIZDJ4bTNveFdSNUgzYmRndGVCb2l2?=
 =?utf-8?B?My9WdmFqbkZlaC9kYXpFK1dHMFp3dENwN0JPeVJ0aHQwa0ZkTGI4VmtxVW5Q?=
 =?utf-8?B?L1IxUWlpeDJ5bGc4Q3JzZnBDUjE5VXhjaEp3YmorMXFmdXp5cVdHUTVxUUpM?=
 =?utf-8?B?QVIwTXVFMmIyV2lGRE9CckljN3FQS3VWSEpTNG14b2IrcXVsb1J5VEFkczBv?=
 =?utf-8?B?MjlleThKckZvYWV0eXNDcmNXaWZXbkRUUG41bDU0b21JbVdrdnF5OXY3aGUz?=
 =?utf-8?B?MVpuQTBIbkhxcEJBcU1qOFR4dkg3bElDa2pxU2R2R0xPMlU5a2M3Zkg3dXJL?=
 =?utf-8?B?emJLeHhnYUhweFJsVnpFaFByeEVLa3I3U1R4U3JoVWRKRjVnL0Njckpwbmdh?=
 =?utf-8?B?YjNOZWFBOFFDQWJWZElDM0dZV2xwb0dCWk1RK29HM293WTNDZVU4aDFScjQz?=
 =?utf-8?B?Njd0cVl5VzNuVG8xWktFck9CZEoyOTMxTDVEUStqVHhaVVdBMXFRdWRYVFdW?=
 =?utf-8?B?SEE9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	pNAHP/EcOzZCZokot6dAr49IcGDmcg/dGc8nzSPhNoAilQMp5kU4wXtbLX+5LTHjJpJMy6Ks1w/xJm/vkr6qo8X0WHoJFgrM1XHI1TPNgpUz3K25mN5kXFMdHbNgB62OIVMz7cESlhyt0utYVOzPofRVIbjv0MdISU/FiEbqaKtsJhvc8oMOaV5w8iCT7PFnuvJ0eW3Wo3VappHw1oIIgZFSivEzo5Pv+7Hn3onJp2J28E5oJHwV35+DtW0KLb7ESWNKeI6EO7R9URCuD8dIeTUHUVnN9q3zM6DKnzNCt9FVyp4HpA1gD6KqN+v6Bo19Vnhm9SG0y7Fb9cgxkCYnPML60XPZlYXZzun8cMsfTKrb1fuIRep5zQrBEGwbF3NJ2sFa/PPNPF21NIwqHnG86hd36/6D0tv0FBaf3AO5JUK1DtDavIITNFOej3XNK7xUESwuMnZ6A0GxIBvXFx+1cVbcMWtg9PPZtKGlkd6ubBRP3DSG5rzsOoch3VJOQu8Faird90bkgIGQGVq6dcffrzD+gCBZy4g8SjGm6bOTJ7Kzfyqba47EiiVOfyof4zMvkxOWzNAFmW8mDGiYGW/kQ1PWau4l3x5eYfop+bBnJhs=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ae43ae57-3e76-4b0f-3e4a-08dc4d992574
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Mar 2024 13:32:13.5581
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: snb4D5+JoX/rkOa8I4wo7nd3haeCtLERdUnpZHIpcCGmdRMCJy0ALmVyEjmBfHFzH1ef5bYcF9vIPZeZnNyIrg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4749
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-03-26_06,2024-03-21_02,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 bulkscore=0
 adultscore=0 mlxscore=0 phishscore=0 malwarescore=0 spamscore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2403210000 definitions=main-2403260094
X-Proofpoint-GUID: ChhFw9B4m4KUkrBajUHZY4OoYdUIRFym
X-Proofpoint-ORIG-GUID: ChhFw9B4m4KUkrBajUHZY4OoYdUIRFym

On 26/03/2024 13:14, Damien Le Moal wrote:
> On 3/26/24 21:43, Yihang Li wrote:
>> This series [1] reducing the kmalloc() minimum alignment on arm64 to 8
>> (from 128). In libsas, this will cause SMP requests to be 8-byte-aligned
>> through kmalloc() allocation. However, for the hisi_sas hardware, all
>> commands address must be 16-byte-aligned. 
> Otherwise, the commands fail to
>> be executed.
>>
>> ARCH_DMA_MINALIGN represents the minimum (static) alignment for safe DMA
>> operations, so use ARCH_DMA_MINALIGN as the alignment for SMP request.
>>
>> Link: https://lkml.kernel.org/r/20230612153201.554742-1-catalin.marinas@arm.com [1]
>> Signed-off-by: Yihang Li <liyihang9@huawei.com>
>> ---
>> Changes since v1:
>> - Directly modify alloc_smp_req() instead of using handler callback.
>> ---
>>   drivers/scsi/libsas/sas_expander.c | 5 ++++-
>>   1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/scsi/libsas/sas_expander.c b/drivers/scsi/libsas/sas_expander.c
>> index a2204674b680..941abc7298df 100644
>> --- a/drivers/scsi/libsas/sas_expander.c
>> +++ b/drivers/scsi/libsas/sas_expander.c
>> @@ -135,7 +135,10 @@ static int smp_execute_task(struct domain_device *dev, void *req, int req_size,
>>   
>>   static inline void *alloc_smp_req(int size)
>>   {
>> -	u8 *p = kzalloc(size, GFP_KERNEL);
>> +	u8 *p;
>> +
>> +	size = ALIGN(size, ARCH_DMA_MINALIGN);


If this is a hisi_sas requirement, then why use ARCH_DMA_MINALIGN and 
not 16B as minimum alignment?

Or are we really talking about an arch requirement?

>> +	p = kzalloc(size, GFP_KERNEL);
> 
> Nit: why not:
> 
> 	p = kzalloc(ALIGN(size, ARCH_DMA_MINALIGN), GFP_KERNEL);
> 
>>   	if (p)
>>   		p[0] = SMP_REQUEST;
>>   	return p;
> 
> Otherwise looks OK to me.
> 
> John,
> 
> Unrelated to this patch, but I wonder if the GFP_KERNEL used here shouldn't be
> GFP_NOIO... Is this ever called in the IO path or error recovery ?
> 

These should not be called in the IO path - as they are management 
functions. But I am quite confident that they can be called in SCSI 
error handling (for libsas).

Thanks,
John