Received-SPF: pass (google.com: domain of linux-kernel+bounces-119063-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Tue, 26 Mar 2024 14:34:32 +0100
From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Rob Herring <robh@kernel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, 
	Tony Lindgren <tony@atomide.com>, devicetree@vger.kernel.org, linux-omap@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] dt-bindings: hsi: omap-ssi: convert to YAML
Message-ID: <64js2unmngyzluullyos6ylkvgvdgn26zgnkku2guozynervpy@tkniifdrklyi>
References: <20240325-hsi-dt-binding-v1-0-88e8e97c3aae@collabora.com>
 <20240325-hsi-dt-binding-v1-3-88e8e97c3aae@collabora.com>
 <8cd3158b-ed51-4a1f-a626-fa58c85d4aeb@linaro.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="njs5f5dqoav63mx4"
Content-Disposition: inline
In-Reply-To: <8cd3158b-ed51-4a1f-a626-fa58c85d4aeb@linaro.org>


--njs5f5dqoav63mx4
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Tue, Mar 26, 2024 at 08:26:54AM +0100, Krzysztof Kozlowski wrote:
> On 25/03/2024 22:45, Sebastian Reichel wrote:
> > Convert the legacy txt binding to modern YAML.
> > No semantic change.
>=20
> You deprecated a property: ti,hwmods. Also will be one more change:
> ti,ssi-cawake-gpio->gpios

and I will introduce a simple bus binding for referencing the
peripheral. I added a list to the commit message for v2.

> >  Documentation/devicetree/bindings/hsi/omap-ssi.txt | 102 -----------
> >  .../devicetree/bindings/hsi/ti,omap-ssi.yaml       | 196 +++++++++++++=
++++++++
> >  2 files changed, 196 insertions(+), 102 deletions(-)

[...]

> > +patternProperties:
> > +  "[hs]si-port@[0-9a-f]+":
>=20
> Does anything actually depends on the name? Can these be "port@[0-9a-f]+"?

That should work. The Linux driver is looping over all child nodes
and checking the compatible.

[...]

> > +      ti,ssi-cawake-gpio:
>=20
> ti,ssi-cawake-gpios

mh, the kernel supports the extra s since 2016. I guess that should
be good enough. I will fix it in v2.

All other comments will be fixed in v2.

Thanks for the review,

-- Sebastian

--njs5f5dqoav63mx4
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmYCzuMACgkQ2O7X88g7
+pqxjA//TjV4yyHewGmF+3gOtEjdCKdzJEQuAWEQDolYEEUDF/bk9rGKfJ8YQ0vC
vcHGnK/7UC99dnuBoHDSaQONXuuBdl+Hnyv8OxkGCb+glkdoXAkBcwkGZQf0EBXw
oPnmdXZhEdC9wt/HoGaF8gB9ojbrAV1Tw18ypKL5WkKK/mczFBMZUHhZXY0AzIJ8
KMQ4+sc0S/cRhq1ilRXsqY6omLDuHVX5zyBRZS+QqiNGtI6xZc5SIhNXlmLua6/Q
DXaaag+TbMoFfjtqvp5xfCPtc3hlCuImnBKoS/nJHTcoIHAEvA6/VuxNYbKJ26gX
7U/vfz8hOaZqQvdVmwGXkYBUpqO/++ksWXgYPvzJJ/8UJ1YlkwI1/eS1USbM7Qdz
P+D5hWRjQRa0D6Vw6D8R78cz3/joX1SjYWfEA8Cwe0KYt55mH2hOQ2l0828u9Fve
RIDy/193hRUeKFHMvB4yLAFtRJsYkuXPiIFp2VSeeGGgq9GXBcTZEBXBOQ6prHzy
zslwKiBHZQ/RUfuc8WjHPmM1RcwL+iuqCfRsOQp2oQZ93di6yCsJg4CQv9RkmmZo
KlhLt/Mk4tsKljYdskxDjQSb2Aic0ByhpmLEd7+zUAftDfWgBz6mTNTlX6jKGwuF
2UUGzH2PKf6pTpISgBHJNYUKrMQOb0LlHxUi1hPTgtnU1dyC4NU=
=Rttd
-----END PGP SIGNATURE-----

--njs5f5dqoav63mx4--