Received-SPF: pass (google.com: domain of linux-kernel+bounces-119062-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Tue, 26 Mar 2024 14:34:24 +0100
From: Lukasz Majewski <lukma@denx.de>
To: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
Cc: Andrew Lunn <andrew@lunn.ch>, Florian Fainelli <f.fainelli@gmail.com>,
 Vladimir Oltean <olteanv@gmail.com>, "David S. Miller"
 <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski
 <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org,
 linux-kernel@vger.kernel.org, linux@ew.tq-group.com, Michael Krummsdorf
 <michael.krummsdorf@tq-group.com>
Subject: Re: [PATCH] net: dsa: mv88e6xxx: fix usable ports on 88e6020
Message-ID: <20240326143424.3368d9b1@wsk>
In-Reply-To: <20240326123655.40666-1-matthias.schiffer@ew.tq-group.com>
References: <20240326123655.40666-1-matthias.schiffer@ew.tq-group.com>
Organization: denx.de
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/NP2qDeJCkPvX5.p498HS=_l";
 protocol="application/pgp-signature"; micalg=pgp-sha512

--Sig_/NP2qDeJCkPvX5.p498HS=_l
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Hi Matthias,

> From: Michael Krummsdorf <michael.krummsdorf@tq-group.com>
>=20
> The switch has 4 ports with 2 internal PHYs, but ports are numbered up
> to 6, with ports 0, 1, 5 and 6 being usable.
>=20
> Fixes: 71d94a432a15 ("net: dsa: mv88e6xxx: add support for MV88E6020
> switch") Signed-off-by: Michael Krummsdorf
> <michael.krummsdorf@tq-group.com> Signed-off-by: Matthias Schiffer
> <matthias.schiffer@ew.tq-group.com> ---
>=20
> I was unfortunately too busy to notice the issue when the patch this
> Fixes was resubmitted in my name. It would have been better to change
> my From into a Based-on-patch-by or similar when modifying it

The "discussion" about this work was lasting at least a few months with
several iterations and changing the design decisions ...

> - and
> the final version obviously wasn't even tested on an 88E6020...


Can you share on which kernel version have you tested the patch that
you claim that testing was omitted?


>=20
> Best regards,
> Matthias
>=20
>=20
>  drivers/net/dsa/mv88e6xxx/chip.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/net/dsa/mv88e6xxx/chip.c
> b/drivers/net/dsa/mv88e6xxx/chip.c index 9ed1821184ece..c95787cb90867
> 100644 --- a/drivers/net/dsa/mv88e6xxx/chip.c
> +++ b/drivers/net/dsa/mv88e6xxx/chip.c
> @@ -5503,8 +5503,12 @@ static const struct mv88e6xxx_info
> mv88e6xxx_table[] =3D { .family =3D MV88E6XXX_FAMILY_6250,
>  		.name =3D "Marvell 88E6020",
>  		.num_databases =3D 64,
> -		.num_ports =3D 4,
> +		/* Ports 2-4 are not routed to pins
> +		 * =3D> usable ports 0, 1, 5, 6
> +		 */
> +		.num_ports =3D 7,
>  		.num_internal_phys =3D 2,
> +		.invalid_port_mask =3D BIT(2) | BIT(3) | BIT(4),
>  		.max_vid =3D 4095,
>  		.port_base_addr =3D 0x8,
>  		.phy_base_addr =3D 0x0,


Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de

--Sig_/NP2qDeJCkPvX5.p498HS=_l
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEgAyFJ+N6uu6+XupJAR8vZIA0zr0FAmYCzuAACgkQAR8vZIA0
zr0WZQf/TS8tiLOb/uxni7yXlc91NzpTBzJttjl0eCjVQXLAAM91ACAh31rDNN9V
SpzRqygxu7tCrijEtp4mdNk1M2Q0Yv6dJ+nzDXQwcBfCoXZ8aoW15gO0Dl82Ndso
Xe1zfzC42AUucu4MIP/gJSYt6zCcUxX2qhoQ/QD8HMHPabR52XviVmIRu+8DswaK
gu7DLLKGOUZdY3bczYlo+yp+M1Lr+6lAJLuBoERP/xOXZ1pjhluYtvsFFJcvzxzk
EGU27rFF/vo8qfjaOHQ2gXQT3/IvTEMebT7lVLP71bs71Gnm1/R2uwKhDr2SWpbh
v8biXDw0AFh1iAm0ecFoOCmu1mSOCQ==
=mBsF
-----END PGP SIGNATURE-----

--Sig_/NP2qDeJCkPvX5.p498HS=_l--