Received-SPF: pass (google.com: domain of linux-kernel+bounces-119137-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Tue, 26 Mar 2024 15:07:27 +0100
From: Greg KH <gregkh@linuxfoundation.org>
To: =?utf-8?B?5bqe6IuP6I2jIChTdXJvbmcgUGFuZyk=?= <surong.pang@unisoc.com>
Cc: "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	=?utf-8?B?57+f5LqsIChPcnNvbiBaaGFpKQ==?= <Orson.Zhai@unisoc.com>,
	=?utf-8?B?5YiY5pm65YuHIChaaGl5b25nIExpdSk=?= <Zhiyong.Liu@unisoc.com>,
	"Surong.Pang@gmail.com" <Surong.Pang@gmail.com>
Subject: Re: [PATCH] usb: gadget: rndis: add multi packages support for rndis
Message-ID: <2024032616-dumping-blustery-aeb2@gregkh>
References: <9d39b91505c4449f98e8431e2f257f8b@shmbx05.spreadtrum.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <9d39b91505c4449f98e8431e2f257f8b@shmbx05.spreadtrum.com>

On Tue, Mar 26, 2024 at 10:47:16AM +0000, 庞苏荣 (Surong Pang) wrote:
> Dear Greg，
> Share Android Phone internet to Windows PC via USB still need the rndis feature.

What supported Windows PC still only has rndis and not cdc-ncm support?
Or the other USB networking driver support built in?  Windows has
deprecated RNDIS for a good reason, let's not continue to insist on
using insecure protocols please.

> OK, if rndis will be deleted entirely, this patch can be abandoned.

Eventually, yes, but as is, your patch can't be taken given the quick
review I already provided.

If you can show that there are Windows systems that only have RNDIS
support, and need this increased speed (i.e. that they can also support
the speedup), and fix up the other issues, then we can review your new
submission.  But please provide that proof when you do so.

thanks,

greg k-h