Received-SPF: pass (google.com: domain of linux-kernel+bounces-119135-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Subject: Re: [PATCH v3 4/4] virt: vmgenid: add support for devicetree bindings
Message-ID: <b8029b57-a33c-4305-ad27-5848f0702053@amazon.co.uk>
Date: Tue, 26 Mar 2024 14:05:11 +0000
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Content-Language: en-US
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, kernel test robot
	<lkp@intel.com>, Sudan Landge <sudanl@amazon.com>, <tytso@mit.edu>,
	<Jason@zx2c4.com>, <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
	<conor+dt@kernel.org>, <sathyanarayanan.kuppuswamy@linux.intel.com>,
	<thomas.lendacky@amd.com>, <dan.j.williams@intel.com>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
CC: <oe-kbuild-all@lists.linux.dev>, <graf@amazon.de>, <dwmw@amazon.co.uk>,
	<bchalios@amazon.es>, <xmarcalx@amazon.co.uk>
References: <20240325195306.13133-5-sudanl@amazon.com>
 <202403262047.aZVjmDY5-lkp@intel.com>
 <727c3a30-d704-4d28-af40-a01e28ca042e@linaro.org>
From: "Landge, Sudan" <sudanl@amazon.co.uk>
In-Reply-To: <727c3a30-d704-4d28-af40-a01e28ca042e@linaro.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit


On 26/03/2024 12:53, Krzysztof Kozlowski wrote:
> CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.
> 
> 
> 
> On 26/03/2024 13:48, kernel test robot wrote:
>> Hi Sudan,
>>
>> kernel test robot noticed the following build errors:
> 
> ...
> 
>>     134                ret = setup_vmgenid_state(state, remapped_ptr);
>>     135                if (ret)
>>     136                        goto out;
>>     137
>>     138                state->irq = platform_get_irq(pdev, 0);
>>     139                if (state->irq < 0) {
>>     140                        ret = state->irq;
>>     141                        goto out;
>>     142                }
>>     143                pdev->dev.driver_data = state;
>>     144
>>     145                ret =  devm_request_irq(&pdev->dev, state->irq,
>>     146                                        vmgenid_of_irq_handler,
>>     147                                        IRQF_SHARED, "vmgenid", &pdev->dev);
>>     148                if (ret)
>>     149                        pdev->dev.driver_data = NULL;
>>     150
>>     151        out:
>>     152                return ret;
>>     153        #else
>>   > 154                (void)dev;
> 
> So this code was not even built...
> 
> Best regards,
> Krzysztof
> 
I built it with CONFIG_ACPI and CONFIG_OF enabled but missed to build it 
without the CONFIG_OF flag. As mentioned in the other mail I'll make 
sure to run all required tools and check for all combinations before 
posting future patches.