Received: by 2002:ab2:6857:0:b0:1ef:ffd0:ce49 with SMTP id l23csp3360373lqp; Tue, 26 Mar 2024 07:15:27 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVFLm+DshG9WT2fk+f0fxwo0sYWIIVGK5D+iFbqMRRiCwHE1ucGLWGsGtW7d7cSDLwMm5R58FY8VAUTr2Wl5eLYKiTNCmBgDEEPPZAYkQ== X-Google-Smtp-Source: AGHT+IEjUwRWQunRaEK6emxGKjFDXSQIDJQjy9ViKMWeB51CA0bQ4Ga0xKnGxT+NOIUdswOjVQUF X-Received: by 2002:a17:906:1785:b0:a47:4e07:ea05 with SMTP id t5-20020a170906178500b00a474e07ea05mr1193934eje.37.1711462525096; Tue, 26 Mar 2024 07:15:25 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711462525; cv=pass; d=google.com; s=arc-20160816; b=ZVZngl7r+dsZF8Wt81WosEedbUWTRKcZOZwzRy1f1P4Dc1pS8ZxMnqVLHB0xSTJ2Fy PXNGUTCJ1K2cZo6B7yQrpr0/cQurUcTyLZkDM1t0SApk/eorUXhx1cMcCdtPuLlxq5sW aNcKjVFBP+37JsPdpVKxaXNkSK/+PoeMolN+yuBIONSm8dvIVCh13GMxEDeL+4j62L2D v49F5ERG7mre2Hd9Kjo0EXt67Z4WKQiUqkvTFcoCaarteSCKyoDMx4Yf2DcM8t7pW3sh axkYJfdr7IJOGCKu0OMhonxJ6yfTxChew5oiiqkmzNidDMBFCtDMp61JpI3RlIm7YSGl oWJw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:to:subject :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :date:message-id:dkim-signature; bh=q8UnXfSeM5UVwmqgM/TReDYUEzDHA5y4BulPyK+wuG0=; fh=F94kNVx5lNcr+tTryex79JgIsbyzLcVXAEo4ozyg3h0=; b=rieHsdHkCaVlxXSCqD37pP2mFr9LeWkS/U5QUVXroPBOqMhQvJCbbRlMuZ2P9I/rSI RapVg/+xgF+udY8D/+gqU1Ll7KJiHPDy7WlXX1oVSb3iA55ztfajVG4nnuUco8oYUXGx pIbp7t0RlGaCSuLTqUHCfomAb4uatMsbx1+p8tHuG3F3hV0L1e8CipjoqgXxlHa2yCrX Sb9n1V8DBMnbXXeJrKqk+vw6h93uXS4tz4gUt9tkrh7B+mZM/sy/klhMOnXOS/uYpynd M2d+d3q4KbD8RRo1pzYdX2cWs1ZQNNJvyBNPlpflDYSB89d0QM/K8diPR2BjfEgB/+Q/ ijTg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=foXo01lS; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-119143-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-119143-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id b16-20020a170906491000b00a4de233e006si1009585ejq.398.2024.03.26.07.15.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Mar 2024 07:15:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-119143-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=foXo01lS; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-119143-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-119143-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id E18711F25AE0 for ; Tue, 26 Mar 2024 14:12:54 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id BEF3F12D20B; Tue, 26 Mar 2024 14:09:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="foXo01lS" Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59F057641B; Tue, 26 Mar 2024 14:09:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711462192; cv=none; b=C9ElihkB5nEIHFk/TosQABbh0/QL/ehLDoQSTqXUR7KzgMmX2a5xDWVgt6BXZrUDADLU9wVcWpira0hIIrglatl1s00T4ZmkyMf+g2eBFhIZzIzlYJu6QvXTTathCs+OKC08mXrOHqkaXg8GUj1GyaFhJXVSp3iOfDst/WTJpdo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711462192; c=relaxed/simple; bh=q8UnXfSeM5UVwmqgM/TReDYUEzDHA5y4BulPyK+wuG0=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=eyD3Yv5sGLPsohGAf5Xp2ypc0b8yDsq1YOBNbq3uvwnImiyJo+Ywl2vFjgLjJHC8shelF3LjtgZD5QZ9U9K5mt/mYo30li/Vu+TZeW2PcIjTriDK4832VigLTDew0nkbqXNp8aTjRMW+tE8/vfZXyIJ3rilGhqdnfrcos6N369w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=foXo01lS; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-41490e42c74so1623855e9.1; Tue, 26 Mar 2024 07:09:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711462189; x=1712066989; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:to:subject :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=q8UnXfSeM5UVwmqgM/TReDYUEzDHA5y4BulPyK+wuG0=; b=foXo01lSD0Z74P68Ei4WXpHlPCN2xLTDq3h8IfGutL+jfF0VszhMoyUpymDHOW6Ubu hRk6Q3ed0nVdi8RKGLRxOPUJlTMAgcVynPfWcURMMEUEJE5Lfm51F9bPzVdbvHbPBYpp +HInyPvGGU2i7hRcQBJQDzmAK/2pBpI6UjgN6M9QCuQ844IEca7lsnYK0D4hyw/I8X2w UKEZoCT5FlTAoZp7AqM+mwIaXo6OQqCx/CpkjRq8a/YjvcvujwtC8Dn/KATc4NHhqquz dmUXb912XurknWBLsT/+8D6+h6c3ekBUch+Y57zzvhYsKGD4QxCgWfrfFg6BHg7QUGMG +T+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711462189; x=1712066989; h=content-transfer-encoding:in-reply-to:from:references:to:subject :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=q8UnXfSeM5UVwmqgM/TReDYUEzDHA5y4BulPyK+wuG0=; b=en/7QRcIoEVJEe5QY/ryhRaTT+YqQn4ZD7BSEkrqWcaToF1oXxhg47ArKufIBogtla F/KivqtZNHM4U/BvhXH8Le8q//ttJ8J1NzufLnSr1SpXuzbekgYzds6pXSkUQSjQES/I bHkl5fT40bngKWbcMaO/uUiC6JsiKX/h0F/sVxRkuL+Nn+6zTa6tN5TSYuf3YEvIrdBe JHnWrYVCAOmyqsIyAKl2eqDaU/MpPnDkAtrKU+Wk/bcR3g5dT/4HvDyIVFysjWW3YPaI 2hv2S1PPAQg2kWhG73X2G6CDNWhTh9rn2c4h3bFlcmAVjXVNM/yG8/hv3zF/4V9kRUJI zw9w== X-Forwarded-Encrypted: i=1; AJvYcCXV8Fn9awoVBvNpQt0N229YUpRfzecWH39gyBSeCBId11lf9s8DZWSxx1jX6Wpyospnwha8d/MCYf2eM+b4k4FZyXqfuz1T8PHXFLmhmgemHbZd3QWEWWnniiFwUQIK4qkj4ZSrJr21yYhCpeZJbL5KclzG4i3XfNMf/EPxXPMI0Z0Zv3H5 X-Gm-Message-State: AOJu0Yx9x3mZ/laT4iILFIRQ3gGiURt20taPGAL23FFMAiD619+q4irr lZ7Sx9LVUyhvlme1JwfVuSMbjUi8xDJEmLvaUXk+qSEfB89F1S5A X-Received: by 2002:a05:600c:510d:b0:414:7bf0:973f with SMTP id o13-20020a05600c510d00b004147bf0973fmr1483318wms.9.1711462189436; Tue, 26 Mar 2024 07:09:49 -0700 (PDT) Received: from debian ([146.70.204.204]) by smtp.gmail.com with ESMTPSA id v16-20020a05600c445000b0041490a83f8fsm820290wmn.31.2024.03.26.07.09.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Mar 2024 07:09:49 -0700 (PDT) Message-ID: <5ecf0c85-5435-4371-8201-6a5a322298e3@gmail.com> Date: Tue, 26 Mar 2024 15:09:28 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH net-next v4 4/4] net: gro: move L3 flush checks to tcp_gro_receive To: Willem de Bruijn , davem@davemloft.net, edumazet@google.com, kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org References: <20240325182543.87683-1-richardbgobert@gmail.com> <20240325182543.87683-5-richardbgobert@gmail.com> <6601c830c1daa_11c6072943b@willemb.c.googlers.com.notmuch> <494e8cac-e87a-4bc4-8a77-1801a703fd86@gmail.com> <6602d05046526_13d9ab29498@willemb.c.googlers.com.notmuch> From: Richard Gobert In-Reply-To: <6602d05046526_13d9ab29498@willemb.c.googlers.com.notmuch> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Willem de Bruijn wrote: > My main concern is moving this code to tcp_offload.c, if it likely > soon will be moved elsewhere again. Got it. I'll move these functions to gro.c and post a v5 with Jakub's requests as well.