Received: by 2002:ab2:6857:0:b0:1ef:ffd0:ce49 with SMTP id l23csp3361728lqp; Tue, 26 Mar 2024 07:17:12 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUX3fINmpnWSJRjR+gpu+PVQCZjDJnv27/9xjqKZkYGWuYGmktp8/Nx60DN9bAYwogUfB1iUPvgHzFcAUg30yFmvSU1fBg59Q7xZ9uRtw== X-Google-Smtp-Source: AGHT+IH4M7m2VEIdnTkTB6YI3/KzX1WjwP+0fCmMOlF5u/Ut/IkiZHGtxkxMVOIwNaeIRJpQA43c X-Received: by 2002:a05:6a00:730f:b0:6ea:a274:cdf8 with SMTP id lq15-20020a056a00730f00b006eaa274cdf8mr7780486pfb.29.1711462632142; Tue, 26 Mar 2024 07:17:12 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711462632; cv=pass; d=google.com; s=arc-20160816; b=UsVtg7YaC8QMBzXW5fx9xX1f4pjXbmIHb17G80+Z/aSXwWQ4FmOTg2wOSOo6zeJJia 3X1B7Vvr5Nq75nIifVlbc7BgJyGjlXRDGZCuSfvJ0qEpiOlhJf/Go6laVqyCSSsxh5mK eYXh/tMJPnTPXltPJ9NSQ/YRIQSDxjoCPU5ciz4Z+gFcRp5+mcDEfjn+7UdtFDoJVYZF qaoCoJjrzTI96gm/4z4yR1tFTftQRHbQGXC89pyNZqFw4PE+BKHNhBmzlSopJkVsAhRJ tHLfPNOCpjlYQ1JNQccKCXOrDtNpsF5yyP/BACGuF6dbjIEZe80/9CgPguSDsPqgMd7t Eajg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=VJfebqtXkl389SDeTD7YYtNydWpUFmx9bb86pDSusXM=; fh=NityMlQx9HCDE9FoErQCSjBt/3bq1RmAMdCYPuG5duI=; b=ZAzRZBX8vmvutp2VJtQOlYfc4Iy/XGwmsDnYAneVj1ofcgBawIAAV1Yioy4O8f7Ljs UgGxcGnWawJipgBzOSEdgrkyYKu4jAr0hRtD8so3tXK/ZkmhnhpmQKCZ3oWYjqk7xZDP lbLZJYrZqItvJcb+mAACPqc1Uc3QlIt0ZQhbm47ixf5bd6Hje57RuevWnLA6zEonjFsN Da2TuZ+6z7YkspV1XQxG/qiJ6pJu3oP+tOi0FfosgRNe/V6B4TeiGDHC4k+4/2aOujaC lE6VmnCtheTsAxVzBxmoKz5xRM1t6U/tsTN7ndw59kl5/lj2DCA9etEK/+iekyxKg4YX KLIA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=oYpozZ5W; arc=pass (i=1 spf=pass spfdomain=google.com dkim=pass dkdomain=google.com dmarc=pass fromdomain=google.com); spf=pass (google.com: domain of linux-kernel+bounces-119159-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-119159-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id w2-20020aa79a02000000b006e7356c25d4si7479216pfj.183.2024.03.26.07.17.11 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Mar 2024 07:17:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-119159-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=oYpozZ5W; arc=pass (i=1 spf=pass spfdomain=google.com dkim=pass dkdomain=google.com dmarc=pass fromdomain=google.com); spf=pass (google.com: domain of linux-kernel+bounces-119159-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-119159-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id A8903321065 for ; Tue, 26 Mar 2024 14:17:11 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B59A412D753; Tue, 26 Mar 2024 14:15:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="oYpozZ5W" Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 51A96762F7 for ; Tue, 26 Mar 2024 14:15:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711462511; cv=none; b=ddCPb/7GTZnT0RjZSF4MrXqML6e0dCBuiUPCqrKJjPpYEZXg3hBxlxMlUx+zvv85FGIwBar3TkmGORuPRLcUwcrOHFnx+2zuuBb9Fv7PIt4mv63l5Ac2PSaOc2INqcdfUu+3fPTbpDhgJE1IIgjSm/lMCfzcz+hrkexcAEs8q/Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711462511; c=relaxed/simple; bh=VJfebqtXkl389SDeTD7YYtNydWpUFmx9bb86pDSusXM=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=cmiB61qDcHr7b77/PXMga4pxWH9pAZvq88aJkt8YYUVVMJUaogTjK3sYWM0eU5zTzZeSZcdjo61KZoFgftrHUDUBXbvRGM867zgq1EyzyNUA6c+W6KLJ7u+e0TGBAWXx2jnD9r8ERa14e59645s9iI10b9/tdaYz3tskAU2zZNk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=oYpozZ5W; arc=none smtp.client-ip=209.85.208.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-56beb6e68aeso8107a12.1 for ; Tue, 26 Mar 2024 07:15:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1711462508; x=1712067308; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=VJfebqtXkl389SDeTD7YYtNydWpUFmx9bb86pDSusXM=; b=oYpozZ5WtSu5jpwmjGNry233tkGvWmCZGnMTsXOshJg7f2xuyDkqX4ioUXEr/V5zi7 Jkk/4rNN6PeQq0XaOrHfc6RCnnVVRPMMJ9J2deCTv1qTealooa3QBAbbRDqAZDTqAZqA kSyTg65m/J3E+6OfmFajm+gxeEJwppcY1tr+yAipufDVQjl4aq8Pc1r1mvt2zXfpXwyG q6Q+dUPbNG63Zk6/42yX4U7LjydeqSxgz+uumlvXleas3gjTNQjjrphDepTjrvuD7YMS coEzl7ohFFmpJMSI3kjyP9/iSaWbqW+ScUU+jh1xtRqSKAG5DIZdWnCqNjF5QvKJ98MP bb/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711462508; x=1712067308; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VJfebqtXkl389SDeTD7YYtNydWpUFmx9bb86pDSusXM=; b=BokHt3TV1FMl1tGWwULlQzh6tkGp7r0eYxMr/0TKjYCIXo3HNcXM/ws4NzJIuW3pw+ y0Q5J0z+ptnd8ddMYn7Jo4wUcpHvDtAdelUnLNkOczc6HxltAipC8jRzrvQ67DnuINwb xTblWvvSRE533PBEgc0JaxP0eozXMa9bGBZoHx1yceGwYZ2mCyt75+HV9b+4zoMb3fxa lhQHDu4JYxmf5+JhDZ+NKjdixVBTdfuMOVKVK6O/XGWd2c4fiPMai6PgvLplvaXcfds6 mBvpzMUUCIKX7Cqd8R0EGm3xISmBwoZVAPy81oRaX6d5vI2z58JbeomvXIPAeZVJRl2R C+sQ== X-Forwarded-Encrypted: i=1; AJvYcCWSPKyscz/bgE0CKZ5K+VT1TnyKgjxL6Y5NEUHMndIFTuIAC+pNdYM8A6VIsSQS53ncAyqlMDOFoNTj1QNw9fplZE7gfUZwZzUMmnn4 X-Gm-Message-State: AOJu0YxYEeviLAnvS6L0pQgJH9RMkdj5d3D19Dn39woeChHrYHUQ0vAu BU2e/gCwIp6Zua2Gpgtx/UUZwEjdS18NQ+hAn22ez0U3GVEqZgM6GF6f31JJA3e68j3lUmwQaFe 1bHSAFe83yOzVxfrn97ZmLOZUmOu1TWDBDSYA X-Received: by 2002:a05:6402:1a26:b0:568:ce1e:94e5 with SMTP id be6-20020a0564021a2600b00568ce1e94e5mr105879edb.5.1711462508403; Tue, 26 Mar 2024 07:15:08 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240325182543.87683-1-richardbgobert@gmail.com> <20240325182543.87683-5-richardbgobert@gmail.com> In-Reply-To: <20240325182543.87683-5-richardbgobert@gmail.com> From: Eric Dumazet Date: Tue, 26 Mar 2024 15:14:55 +0100 Message-ID: Subject: Re: [PATCH net-next v4 4/4] net: gro: move L3 flush checks to tcp_gro_receive To: Richard Gobert Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, willemdebruijn.kernel@gmail.com, dsahern@kernel.org, xeb@mail.ru, shuah@kernel.org, idosch@nvidia.com, amcohen@nvidia.com, petrm@nvidia.com, jbenc@redhat.com, bpoirier@nvidia.com, b.galvani@gmail.com, liujian56@huawei.com, horms@kernel.org, linyunsheng@huawei.com, therbert@google.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Mar 25, 2024 at 7:27=E2=80=AFPM Richard Gobert wrote: > > {inet,ipv6}_gro_receive functions perform flush checks (ttl, flags, > iph->id, ...) against all packets in a loop. These flush checks are used > currently only in tcp flows in GRO. I think this is a bug. GRO should not aggregate packets if their ttl/tos fields do not match.