Received-SPF: pass (google.com: domain of linux-kernel+bounces-119156-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Tue, 26 Mar 2024 09:13:37 -0500
From: Lucas De Marchi <lucas.demarchi@intel.com>
To: Tiwei Bie <tiwei.btw@antgroup.com>
CC: <richard@nod.at>, <anton.ivanov@cambridgegreys.com>,
	<johannes@sipsolutions.net>, <jani.nikula@intel.com>,
	<linux-um@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
	<intel-xe@lists.freedesktop.org>
Subject: Re: [PATCH v3 8/9] um: Fix -Wmissing-prototypes warnings for
 text_poke*
Message-ID: <tvkjne4liqm3xx64jtkvqhlvvkwmiwlavif7gdh47xlzeltyp5@ymlqsvkdbppr>
References: <20240306101925.1088870-1-tiwei.btw@antgroup.com>
 <20240306101925.1088870-9-tiwei.btw@antgroup.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20240306101925.1088870-9-tiwei.btw@antgroup.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VVRrNC8wbWxIZjdYSi9LZnhSSzUvdkpNYSt6RnQ0NkFCaEJBTUtoWEZQQjMw?=
 =?utf-8?B?K3MyRW5EQjZyNWxZYmpnRjdHbDBJaWJQb0dRbE10WWdQZXNkNTdnZ0ZaR3ZN?=
 =?utf-8?B?cXMzb2YybTVkcDZjdHhpbmtRMEtQNlRNQXovdVV2WTlOMjJDYm5ta21TUy9D?=
 =?utf-8?B?WStkOXYzZXhENklYOFRBblFqNUc3NU9mN1R4NUJmWjdkZjhFUFR4am1mUGw2?=
 =?utf-8?B?alM0Vm1qK3MxakdyWUNhQzZ5RWwxTWNvVmxQM1ppaFlSQmhnNzJLaXBuY1pS?=
 =?utf-8?B?V2ZXd0o2bzd5QWJvNWhUeXB6Y3hyMkpkNGlEaHZRTFpDOGFITzRBSjkvT0tL?=
 =?utf-8?B?YjNDSmlmOXcyTzFnTXhBS1ZDc0xBcWh2aGhXSGUwRmhsWlhIb1A5TUlaZnFG?=
 =?utf-8?B?UEZWVHkzU0REVUc4VitkQWJCS3NvTzV3S0tBRUhyVnhPckllWEtUVEo4dVVZ?=
 =?utf-8?B?WWxURjRvU0ZnQ1ZCcS9wSFJad1h0LzJTTjFzdlZROGl6WitGUjFMb0xwK3NJ?=
 =?utf-8?B?RTFSSkQ4dW0xUUx6ZGFXOXRMbE9nQ2g3Z3B6bFFzWi9LR2g4RzB2N3E5VjNn?=
 =?utf-8?B?TDZaMCt5cDJkSWNBMTNvdXF4cStQQWFsSGhZdURXR0RTUlhuREFmTnRRNE9I?=
 =?utf-8?B?KzNPLzQvRkpjM096TktYRGtZRFh4ODcvL25kWGxKSDNxUHJpNW9MSVcySGJL?=
 =?utf-8?B?SGdyRTlPMTdUQmc3REVmUXlmRURwZDlSSWs3VEFaRGEwRzVYMWFsNHZQRzBh?=
 =?utf-8?B?bEhUTkJNQnZmaVh1OVpVNFB2aUxNWGlHUjZRRWY2YTg1QVVWOHZjb2s1MVlV?=
 =?utf-8?B?bnpsVTBWNE85ak5ZRmp6ZHpLTGZJcFNNdnY3d1hOOHd2VmpvbERFMEJycW5p?=
 =?utf-8?B?V1dPZG1WakRlREd2R2IzRVEwVjM0VTBFMGJMZlA2VXhTQVYyT0dFb242di9i?=
 =?utf-8?B?VCtrN3FQaDU5c3pYeTlNV1dpTkhnaDZKQzluL0hINHVvY3FrZjVVRzJMRkdK?=
 =?utf-8?B?QVdscUVJOU5qYnArcXI1cFBBYzRaS1piRDB6MSsrRmJlaWFmSFJZYUMzVld2?=
 =?utf-8?B?V1hFOUNuOXNHWTlxRmlkZ0c0djNDR1ozaGhSQ0NEcWdJcm5HN0syVUZSOGM1?=
 =?utf-8?B?NVpQNitLdTNsR0ZsYjB3NDFDdjZqQ0xvLzZ3UEJxUHUxZ0JPSURYMWVwRnFR?=
 =?utf-8?B?N2xTVVJZeHgwVHlYS09YWXAwaDBlYUsySjIrdW91MFd1ZnMydlVvWUlsSk1G?=
 =?utf-8?B?YkZyRmNtYVdVWXFIRTcrTzNLNHhNVEl4d3JHWHZtMGdlUk9pTWFlZE51ZUwv?=
 =?utf-8?B?bVdmSld0ZWVoRjJNMXV2b0pWZFpBVklWK3Q0QWVQV2I0bzlFMDNNZjQ3THZZ?=
 =?utf-8?B?RGc0WUE1bUEyNkFldDFnaVV1bFRXclBwZVlxRFprUFExWVdrUS9NbVNLMkRs?=
 =?utf-8?B?Ym9LT1hYcEpvanRRdGlEQmlvQjN0Q3N4cmNjeVp1Y0dSUHNKZU1hOUoyeThP?=
 =?utf-8?B?akhlbnEyekFQaWZPZmlEdVdYbjIvZllEclc2c2lhMHBVRlBSUTBYeUdyVVll?=
 =?utf-8?B?VzJkZHBPZThSMWtqS1JYS0s4Y2ZBS2NQNGY4M1RWZ3Y3eG43SFZqdG5Vak01?=
 =?utf-8?B?ZGNjRVU3K1dKazRTQytWZTlJSVNoc0cyRnZLUmsycXRCZE80NmVUNkhWWStC?=
 =?utf-8?B?U0R5U3NVOG51ems3MGhhZVNUSkN0QytRUDBSbWFQZElsdnFDMEhYR0FIZTky?=
 =?utf-8?B?Qm5CT013ck5zWEpQVG1rOVVoME1JY2dReVNTUnBPOHZCS05rS1E5NXkwU0dw?=
 =?utf-8?B?dTd0cXJWaE15TlFndnFMWDJkSzQwTUZDeXdUeWlRY2NGOGFZaDBpY3owd3ho?=
 =?utf-8?B?UWZjdllRejFsdmg3R2xVWEtjelQvVHBhajBpRGhTckJzYk9ic1I4QzVvRTk3?=
 =?utf-8?B?MUFyYThyWk9KeVFpN3A2L0Fsd1RKWVVkYVpmOU5aU3NNSjQvUHlYOG9zbmdv?=
 =?utf-8?B?QWkwUm9Peit1V1ZhYk1TbUkvRnB4N3JRQUwwRnUxYmRxUUxqMlVRZG5jUUI2?=
 =?utf-8?B?VU9KbVBESFpLYk05ZUdKekpoNXJHVXlyZDdUbzhlc3VRTXNVbmFNeVZqL3dh?=
 =?utf-8?B?YkoxOUFvcmhKOEJpRURuNmJ5cEs0NGVXcVVMK0FSR0ZVOHdKQ3UvMERjWks0?=
 =?utf-8?B?Y1E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ed9043ce-926c-42b1-3bee-08dc4d9ef0a6
X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6139.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Mar 2024 14:13:41.9826
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 40k3qGN5eTLWLoFZcF8q7QLx9MyvvudU8OnBOZnfvUCog7O8K6C/kU+jD4Rzk05AO2Bo7w3ysQbzsbEiqMZjttpHTccSEiVPEQNC+dINlWI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYXPR11MB8710
X-OriginatorOrg: intel.com

On Wed, Mar 06, 2024 at 06:19:24PM +0800, Tiwei Bie wrote:
>The prototypes for text_poke* are declared in asm/text-patching.h
>under arch/x86/include/. It's safe to include this header, as it's
>UML-aware (by checking CONFIG_UML_X86).

but would it work when building on something other than x86? Or is that
not a thing?

Lucas De Marchi

>
>This will address below -Wmissing-prototypes warnings:
>
>arch/um/kernel/um_arch.c:461:7: warning: no previous prototype for ‘text_poke’ [-Wmissing-prototypes]
>arch/um/kernel/um_arch.c:473:6: warning: no previous prototype for ‘text_poke_sync’ [-Wmissing-prototypes]
>
>Signed-off-by: Tiwei Bie <tiwei.btw@antgroup.com>
>---
> arch/um/kernel/um_arch.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/arch/um/kernel/um_arch.c b/arch/um/kernel/um_arch.c
>index 7a9820797eae..e95f805e5004 100644
>--- a/arch/um/kernel/um_arch.c
>+++ b/arch/um/kernel/um_arch.c
>@@ -23,6 +23,7 @@
> #include <asm/cpufeature.h>
> #include <asm/sections.h>
> #include <asm/setup.h>
>+#include <asm/text-patching.h>
> #include <as-layout.h>
> #include <arch.h>
> #include <init.h>
>-- 
>2.34.1
>