Received-SPF: pass (google.com: domain of linux-kernel+bounces-119140-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Tue, 26 Mar 2024 14:08:10 +0000
To: Wedson Almeida Filho <wedsonaf@gmail.com>
From: Benno Lossin <benno.lossin@proton.me>
Cc: rust-for-linux@vger.kernel.org, Miguel Ojeda <ojeda@kernel.org>, Alex Gaynor <alex.gaynor@gmail.com>, Boqun Feng <boqun.feng@gmail.com>, Gary Guo <gary@garyguo.net>, =?utf-8?Q?Bj=C3=B6rn_Roy_Baron?= <bjorn3_gh@protonmail.com>, Andreas Hindborg <a.hindborg@samsung.com>, Alice Ryhl <aliceryhl@google.com>, linux-kernel@vger.kernel.org, Wedson Almeida Filho <walmeida@microsoft.com>
Subject: Re: [PATCH 09/10] rust: init: update `init` module to take allocation flags
Message-ID: <kiqpEglPExNZBB0TsooPwQsQTwFfYadAnVfztU9sFzYJ5CU_Rg0PC_KYEQF4duxv7qOo6gOBUFVnR-GfuEsIEYqgBSWnOGEZAcl3t06cB2s=@proton.me>
In-Reply-To: <20240325195418.166013-10-wedsonaf@gmail.com>
References: <20240325195418.166013-1-wedsonaf@gmail.com> <20240325195418.166013-10-wedsonaf@gmail.com>
Feedback-ID: 71780778:user:proton
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 25.03.24 20:54, Wedson Almeida Filho wrote:
> From: Wedson Almeida Filho <walmeida@microsoft.com>
>=20
> This is the last component in the conversion for allocators to take
> allocation flags as parameters.
>=20
> Signed-off-by: Wedson Almeida Filho <walmeida@microsoft.com>
> ---
>   rust/kernel/init.rs               | 49 ++++++++++++++++---------------
>   rust/kernel/sync/arc.rs           | 17 ++++++-----
>   rust/kernel/sync/condvar.rs       |  2 +-
>   rust/kernel/sync/lock/mutex.rs    |  2 +-
>   rust/kernel/sync/lock/spinlock.rs |  2 +-
>   rust/kernel/workqueue.rs          | 13 +++++---
>   6 files changed, 47 insertions(+), 38 deletions(-)

One formatting issue below, with that fixed:

Reviewed-by: Benno Lossin <benno.lossin@proton.me>

> diff --git a/rust/kernel/sync/arc.rs b/rust/kernel/sync/arc.rs
> index 077200f5350b..af539c5eb4bc 100644
> --- a/rust/kernel/sync/arc.rs
> +++ b/rust/kernel/sync/arc.rs
> @@ -565,13 +565,16 @@ pub fn new(value: T, flags: Flags) -> Result<Self, =
AllocError> {
>       }
>=20
>       /// Tries to allocate a new [`UniqueArc`] instance whose contents a=
re not initialised yet.
> -    pub fn new_uninit(_flags: Flags) -> Result<UniqueArc<MaybeUninit<T>>=
, AllocError> {
> +    pub fn new_uninit(flags: Flags) -> Result<UniqueArc<MaybeUninit<T>>,=
 AllocError> {
>           // INVARIANT: The refcount is initialised to a non-zero value.
> -        let inner =3D Box::try_init::<AllocError>(try_init!(ArcInner {
> +        let inner =3D Box::try_init::<AllocError>(
> +            try_init!(ArcInner {
>               // SAFETY: There are no safety requirements for this FFI ca=
ll.
>               refcount: Opaque::new(unsafe { bindings::REFCOUNT_INIT(1) }=
),
>               data <- init::uninit::<T, AllocError>(),
> -        }? AllocError))?;
> +        }? AllocError),
> +            flags,
> +        )?;

The indentation looks wrong, rustfmt sadly cannot handle the pin-init
macros. This looks better to me:

        let inner =3D Box::try_init::<AllocError>(
            try_init!(ArcInner {
                // SAFETY: There are no safety requirements for this FFI ca=
ll.
                refcount: Opaque::new(unsafe { bindings::REFCOUNT_INIT(1) }=
),
                data <- init::uninit::<T, AllocError>(),
            }? AllocError),
            flags,
        )?;

--=20
Cheers,
Benno

>           Ok(UniqueArc {
>               // INVARIANT: The newly-created object has a refcount of 1.
>               // SAFETY: The pointer from the `Box` is valid.