Received: by 2002:ab2:6857:0:b0:1ef:ffd0:ce49 with SMTP id l23csp3363405lqp; Tue, 26 Mar 2024 07:19:35 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUKWVynzMKnqirf9TKRXYDs5mxDCneygv+IMNKgwVg9fKXE8Gln2kW+d9bh2DM1+6Mm0ys7kgGUjuKDyd25fyKtxgcSP7P4rIrVSI8Scw== X-Google-Smtp-Source: AGHT+IHJLffHsMgR+EH5FYSsu5EZFsEJ4vJjMzV/vW+3E784hGX+48MiWv2bUBEWBEc4i3ODHMwS X-Received: by 2002:a50:951e:0:b0:568:32cc:f808 with SMTP id u30-20020a50951e000000b0056832ccf808mr1155689eda.15.1711462775392; Tue, 26 Mar 2024 07:19:35 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711462775; cv=pass; d=google.com; s=arc-20160816; b=dcMz5LI3/5mvNpx6lUR1xdkYmlmIdByFj+sEVK4ZWnN25ZI6oppydFBg1PSQZZgraj BDuxsj7LOha5Qlcf6YnSSYSqTBya284YqDBZuDsDxby9cO6UOkXlrNbxElcBDfxG1SI+ AJtuZUuc6CrcT1jGd+3t4zjMTrI+FS5ndgohQjGZFW7rkaqKZTd+tVmgWNJYCokZzoe3 uzzYXbFLz7v7k7q9dbiZr/0fr51VP06bPK9BQ15nqOawS3SKBPOg8UIZv5J2LEU+1DX7 kHOSgfsrSAYKPJlhpX6rJlmoiQpryOfzWUPpo/j+DX1lfYVmJk/Dphj/KDT7CwrcV4OI EnKA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=X8CR1+I0cawySEwSdv7UfHrWzydgDcVce+N97oQtxSk=; fh=8stWMjTe41GZPOf/Ejilr5rzjD6WaY/ymN9drhqmskA=; b=h+SCPy+JSOczd5EXgsgyTA+Y/2iP2WDoi4uEc4nauQgLT0GElrinrALXwy1mUEC/XX R7c4mWQ/XN91dov230vNOS5h88loDpHDDKmzM7+9Wv+WhVU7D8PQN8eV5biENhowXJoi GJ2Z5TlILofjBZmNKA4f0Yw1QEvyTLo5BSuwhf6sw8j/N5whvxIBJmDnP0+x4NyqoI00 pNgPL5djqpHZe2LrC4TZ7B5FzvDYFGMh3hfsfePDemaj6/l8ztxCkEfIp/0Ofmc62Qbt AjjjasErpp5ktg2zagGBC3KHsY3Eik0F2hnu5/aLf4nLnO72Pl6nqPZqDkwi88YeLs2I zjmw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=T5C+HdgV; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-119163-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-119163-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id j6-20020a05640211c600b0056bf6181630si3483752edw.407.2024.03.26.07.19.35 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Mar 2024 07:19:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-119163-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=T5C+HdgV; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-119163-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-119163-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 2530E1F2B0D1 for ; Tue, 26 Mar 2024 14:19:35 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id BE1A812D774; Tue, 26 Mar 2024 14:19:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="T5C+HdgV" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DCFC412D74D; Tue, 26 Mar 2024 14:19:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711462762; cv=none; b=nXsbHG4HINX+6U3EHl+MPgZ5kpd87MNQFwEfggTwyMgnvjpKW84Ggi54SuX0Ax2OZBW+L1UXptwYaURsfDTjbTw4nxz31eM6wfU37j1x9NpT5nsYmhNHYcmBGkV0hxjWI+LdzKLrTWH4edo2il7B3R7CW4/z3H+14kL8hoXGvtc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711462762; c=relaxed/simple; bh=cUG492G07dhJ295J2s6Bln1s6TgRP0M3K3HaWg8Wrcs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JGtOb57Y9K8clIm4o7PApk4F6ZMX/z17Ty9q5EVfIcfzT4nzYDoFXm3MQVrY2TqRbf4y+rVmqeIGTJ8biSgD22Wie5HUx0R8oLSs4YzYxxATHeSPLcq/Reg9JjTRjnzcVmbaixw1+QR9HOu4Kt8+49AyMjcRj6///RLBJI+jsyo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=T5C+HdgV; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id E926BC43390; Tue, 26 Mar 2024 14:19:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711462761; bh=cUG492G07dhJ295J2s6Bln1s6TgRP0M3K3HaWg8Wrcs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=T5C+HdgVS4qy/7M7L6NSr7ER7ibxLccniWf/xtu2V/w87sozoVQVerjOkd9t2JJY3 d75k6Ihfs1arrkeh+3lnTOAK7N5XKkMIYBkSdD8lffC2ISSWbW0kqxHP0VY7C23tuB knTNN8sbqvf/fw28+Z3AjtpNa49qDOU54KsmDQojVP2cEoggPP3HZSbVnTW5ooTpfo ZWVTx3v+iHTOlLdbJ5+kw8QXdrKQCuyJ14yQMfj810WQ6Qjr0lTfw4x8dWlg6mdUMe lIXywLcq9ihEPp9biq9VHITu0JqClQQSYK6/cwm2Wagrd7qP2HC6q2fQmGKnbXXkOQ HiCoF9shtzGcQ== Date: Tue, 26 Mar 2024 14:19:16 +0000 From: Simon Horman To: Su Hui Cc: sgoutham@marvell.com, gakula@marvell.com, sbhatta@marvell.com, hkelam@marvell.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, saikrishnag@marvell.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH net v2 1/2] octeontx2-pf: check negative error code in otx2_open() Message-ID: <20240326141916.GW403975@kernel.org> References: <20240326061233.4133148-1-suhui@nfschina.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240326061233.4133148-1-suhui@nfschina.com> On Tue, Mar 26, 2024 at 02:12:34PM +0800, Su Hui wrote: > otx2_rxtx_enable() return negative error code such as -EIO, > check -EIO rather than EIO to fix this problem. > > Fixes: c926252205c4 ("octeontx2-pf: Disable packet I/O for graceful exit") > Signed-off-by: Su Hui > Reviewed-by: Subbaraya Sundeep Reviewed-by: Simon Horman