Received-SPF: pass (google.com: domain of linux-kernel+bounces-119160-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Tue, 26 Mar 2024 09:16:58 -0500
From: Lucas De Marchi <lucas.demarchi@intel.com>
To: Tiwei Bie <tiwei.btw@antgroup.com>
CC: <richard@nod.at>, <anton.ivanov@cambridgegreys.com>,
	<johannes@sipsolutions.net>, <jani.nikula@intel.com>,
	<linux-um@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
	<intel-xe@lists.freedesktop.org>
Subject: Re: [PATCH v3 0/9] um: Minor fixes and cleanups
Message-ID: <zhm2eyo5hy6wta5ga6zqgg546q2atjekdxoivksht2kdrqppoy@6ck7iwpfxidr>
References: <20240306101925.1088870-1-tiwei.btw@antgroup.com>
 <fbd44e8a-713b-4e66-9241-e18fc78c9168@antgroup.com>
Content-Type: text/plain; charset="us-ascii"; format=flowed
Content-Disposition: inline
In-Reply-To: <fbd44e8a-713b-4e66-9241-e18fc78c9168@antgroup.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?QeECTciXk0tut2ZlB5ExRgP8tOj/4ujVxlR2FqVEc6+F6BXNzmLfRCEXyCrO?=
 =?us-ascii?Q?2o9++fqTa65gKxb8m7uc+wfspjTPtnWrnPx0EOyBpzHLahO6MC9GtynmSfCI?=
 =?us-ascii?Q?Sbt6Cfb60R/i96s3AsFd0IZi6EBIPx0kc4JxGbZcpBWQfC6CFCOpkl6Oc2cf?=
 =?us-ascii?Q?jW6qlh0tGTc+2ymWuaUtf+kZVUDRGTKWJBtXsYdGN5Y0faQX3F1zhD0q6sjw?=
 =?us-ascii?Q?0ETUzv2UlGN707qH5LIPAqH7z2tiEyGQkMsMNuqvVFpIQH+04HcQFYvuIHh1?=
 =?us-ascii?Q?THnhK/tnwlYLYpHH/yIQZ5AISRhlVUIy6spnzE71YZ2M+6812AVaHym3pMV+?=
 =?us-ascii?Q?vIMguTUEJjMVcsyH/hhg6MhWFT+T2WzBb685Imqyxl6/HwonwYdCsVz/PwSJ?=
 =?us-ascii?Q?vJ6PS8OJrPUoDstz/WgJ0eMwafSLm5w3VIDrpb+SG2T/IxMVqsfKD/oDnOQE?=
 =?us-ascii?Q?nJRz6uEDeU1gAxdI4kMNPLyjhoGXxxi/9SeDWySz0sObBEU++LYihgcNeBme?=
 =?us-ascii?Q?xpAMZZYAcwuL9K4pLa7tYZuhnp86AtxeJOakOfPTovFwEmnavhi9cupY0kpa?=
 =?us-ascii?Q?VzPqQ2H6VF+J5dIW8mOm4ndsD9fgtonKxh2hd/guTIcyVV6hMq+lJ3UqZHfO?=
 =?us-ascii?Q?ijcvSSjAKQ9afnDZRP0GM0oP0D4icBonmtjJxYp+13lncnr5/S1PVMikh005?=
 =?us-ascii?Q?tfvGuqZMw7Y5Najt+RxhgDXkdheXrYDemiQX+ZHzgDYvvLT+5Ihk247+Bl8n?=
 =?us-ascii?Q?2LMQgQwm376nRJ+OgPC/bi38AMppLE5nzhceX48LU4k+MNkK8gebsGHsbDdC?=
 =?us-ascii?Q?IGY7d7eVy8Fd5Gvq1ds6+Ki+zGFdiSpWRWe5HjBd2UhXLcmLD3U2IwymLy9u?=
 =?us-ascii?Q?SsTrWx5BofIWwgOY7CH8FpXo9wBnH0ZI6WgB6E/ibdIrOO6eaW5rm/oXfe34?=
 =?us-ascii?Q?FvscbLfmERLnSQ3cXITMUgwh6o0jOLGF6fCJGWpF1JYivnZrz63mSdchPoGB?=
 =?us-ascii?Q?OGG5CWwvLx/aaFSZKwROdvEqlInkKHK1JzgHs3CahXBusHqknc7B5xLWJvPB?=
 =?us-ascii?Q?7eulztONDzfic/+pauS4EdbrNDjRWeyo68rELJHaCeETvzF/Q5bherM1phJw?=
 =?us-ascii?Q?GLl6/snzmuQvTqW6vsX4VCCjgaIr2z4ivi7DbiCvns3r4nMcoP0Um9FHrf7R?=
 =?us-ascii?Q?sFU+k/7f3EqTmUvwHeMLIo1tUFaRqZ+gatQYdjjN6Oa6f+fFZEitpKPmifAH?=
 =?us-ascii?Q?3zkXKU3rWU81orZoTsdMvwqfAVjjtzzAplRYsPcfqRabNCYq62zOWMnUPj2C?=
 =?us-ascii?Q?k4aBeFaSy+Vk7MewT77gePnxdG+7k3GfmGi89J5vV5Ts3uEVT3p3fHstEulk?=
 =?us-ascii?Q?5hiwoFMih3kYRjhspNnCrwRfyb1gD0feopofQ89Dt81FBCopiMTsB2UUDKFp?=
 =?us-ascii?Q?bjmojGhxu5OHdiHYBmw8NflGVpHHpNoAq9zMxXIKlM10zzwDlvc7Xf7PjbX5?=
 =?us-ascii?Q?iYbrqo6MulA9dH+GNl8NeLyfEG928rkigZj/qv+B1QiWjbsiT2r69+qjLOZR?=
 =?us-ascii?Q?zRs4S0UpoNcMnL3YmtGdvLlbYfY2t+UhKbPS1E+ddRJW9Uyde8ilPbbU4fWe?=
 =?us-ascii?Q?Tg=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d5f154ea-ddfc-41fb-6ec1-08dc4d9f6819
X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6139.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Mar 2024 14:17:02.3104
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: J9xYDM+1KOWZdUnz/VJRgP3adsK5TTCkUIfAqBOFTUctGZMMXzzahtUB9iSH1AokdCkwS4vyKKL8UhyeddnNY9HQmatevyLJ8VZi3zRl9zo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5190
X-OriginatorOrg: intel.com

On Tue, Mar 26, 2024 at 08:27:25PM +0800, Tiwei Bie wrote:
>Hi,
>
>Gentle ping.. Please take a look at this series if possible. The changes
>in this series are very straightforward, so it shouldn't require much effort
>to review. But they cover a wide area, making them prone to conflicts
>with other patches :/, e.g.
>
>https://lore.kernel.org/linux-um/20240326073750.726636-1-surenb@google.com/T/#u
>
>Sorry to be impatient, but pinging this. This series was originally posted
>two months ago, and hasn't received a review yet. Just want to make sure that
>this series is not lost..
>
>PS. I have tested this series on both of 64bit and 32bit platforms manually.
>There is also a CI test report from patchwork@emeril.freedesktop.org:
>
>https://lore.kernel.org/all/87bk7rzj70.fsf@intel.com/


yeah, it's a clear improvement.

For patches 1-5 and 7, feel free to add my Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
I commented on patch 8 as I'm not sure it's the right approach and same
thing applies to patch 9.  Patch 6 I'm just not sure as it's the first
time I see that file, so I will leave it to others.

thanks
Lucas De Marchi

>
>Thanks,
>Tiwei
>
>On 3/6/24 6:19 PM, Tiwei Bie wrote:
>> A series of minor fixes and cleanups for UML.
>>
>> Most changes in this series are very straightforward. Please consider
>> picking this series for v6.9.
>>
>> There are still some remaining -Wmissing-prototypes warnings. I plan to
>> send a followup RFC series first to fix those warnings.
>>
>> Feedbacks on this series would be appreciated. Thanks!
>>
>> Changes since v2:
>> https://lore.kernel.org/lkml/20240205114708.25235-1-tiwei.btw@antgroup.com/
>> - Add "um: Move declarations to proper headers";
>> - Add "um: Fix -Wmissing-prototypes warnings for text_poke*";
>> - Add "um: Fix -Wmissing-prototypes warnings for __warp_* and foo";
>> - Make do_set_thread_area() static;
>> - Add the missing header for calibrate_delay_is_known;
>>
>> Tiwei Bie (9):
>>   um: Make local functions and variables static
>>   um: Fix the declaration of vfree
>>   um: Remove unused functions
>>   um: Fix the return type of __switch_to
>>   um: Add missing headers
>>   um: Stop tracking host PID in cpu_tasks
>>   um: Move declarations to proper headers
>>   um: Fix -Wmissing-prototypes warnings for text_poke*
>>   um: Fix -Wmissing-prototypes warnings for __warp_* and foo
>>
>>  arch/um/drivers/pcap_kern.c                |  4 +-
>>  arch/um/drivers/ubd_user.c                 |  2 +-
>>  arch/um/include/asm/ptrace-generic.h       |  3 ++
>>  arch/um/include/shared/as-layout.h         |  1 -
>>  arch/um/include/shared/kern_util.h         |  1 +
>>  arch/um/include/shared/um_malloc.h         |  2 +-
>>  arch/um/kernel/kmsg_dump.c                 |  2 +-
>>  arch/um/kernel/mem.c                       |  2 +
>>  arch/um/kernel/physmem.c                   |  3 +-
>>  arch/um/kernel/process.c                   | 48 +++++-----------------
>>  arch/um/kernel/ptrace.c                    |  3 --
>>  arch/um/kernel/reboot.c                    |  1 +
>>  arch/um/kernel/skas/mmu.c                  |  1 +
>>  arch/um/kernel/skas/process.c              |  5 +--
>>  arch/um/kernel/time.c                      |  7 ++--
>>  arch/um/kernel/tlb.c                       |  7 +---
>>  arch/um/kernel/um_arch.c                   |  1 +
>>  arch/um/kernel/um_arch.h                   |  2 +
>>  arch/um/os-Linux/drivers/ethertap_kern.c   |  2 +-
>>  arch/um/os-Linux/drivers/tuntap_kern.c     |  2 +-
>>  arch/um/os-Linux/main.c                    |  5 +++
>>  arch/um/os-Linux/signal.c                  |  4 +-
>>  arch/um/os-Linux/start_up.c                |  1 +
>>  arch/x86/um/asm/ptrace.h                   |  6 +++
>>  arch/x86/um/bugs_32.c                      |  1 +
>>  arch/x86/um/bugs_64.c                      |  1 +
>>  arch/x86/um/elfcore.c                      |  1 +
>>  arch/x86/um/fault.c                        |  1 +
>>  arch/x86/um/os-Linux/mcontext.c            |  1 +
>>  arch/x86/um/os-Linux/registers.c           |  2 +-
>>  arch/x86/um/os-Linux/tls.c                 |  1 +
>>  arch/x86/um/ptrace_32.c                    |  2 -
>>  arch/x86/um/shared/sysdep/kernel-offsets.h |  3 ++
>>  arch/x86/um/tls_32.c                       |  2 +-
>>  arch/x86/um/user-offsets.c                 |  3 ++
>>  35 files changed, 63 insertions(+), 70 deletions(-)
>>
>