Received-SPF: pass (google.com: domain of linux-kernel+bounces-119167-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <adacb412-a043-4512-a8d3-1a0f6f40e9f4@amd.com>
Date: Tue, 26 Mar 2024 10:22:05 -0400
User-Agent: Mozilla Thunderbird
Cc: yazen.ghannam@amd.com, linux-edac <linux-edac@vger.kernel.org>,
 LKML <linux-kernel@vger.kernel.org>,
 "anthony s . k ." <akira.2020@protonmail.com>
Subject: Re: [PATCH] RAS/AMD/FMPM: Fix build when debugfs is not enabled
Content-Language: en-US
To: Borislav Petkov <bp@alien8.de>
References: <20240325183755.776-1-bp@alien8.de>
 <eede2586-f143-4107-a065-2860ed413d0a@amd.com>
 <20240326140759.GGZgLWv3UZVpHZ5c98@fat_crate.local>
From: Yazen Ghannam <yazen.ghannam@amd.com>
In-Reply-To: <20240326140759.GGZgLWv3UZVpHZ5c98@fat_crate.local>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dyt0RWdFOEdCZk1OVjhZMkpHUC9uRkxtQWdIWVhMZE1saVM5ZXRmNlF6ZVU2?=
 =?utf-8?B?bUVSUC9RUWovbSthQVVNTHJ2V1lHeFlNdkxHdHFhVXB2YjhuOHZwc0d1ejZQ?=
 =?utf-8?B?YzhGZGdmTytwVER4bE5OSVZkWjZjNlJVZlRoUmpiWkFCN216ZUY1dXpFYTEv?=
 =?utf-8?B?aitZZS9rcllHMVE1SGZIRC9VUGRGK3J2SHBZWFhzMmNGRWl2U2pSczFuWFha?=
 =?utf-8?B?WjVIL3VsYjdqYVpENnFmc1U5aVdOR2JBS2FINE9wT3lpUHA0QzBlRG0yTDhT?=
 =?utf-8?B?Z1lYWHJWdDBOWHZFUDhRMzh5SkY0bWtZTWZCM0hDbFBrVUlCYjZWUWNCNElL?=
 =?utf-8?B?VnB4NlZKc0x0bnJNbEZPWXZkZEhqUUtTM01jVWdrSlY3SlJvckpyVStXRXdi?=
 =?utf-8?B?L2t6M2w3UkI0ZkVzQkVUR1RLM0wzdHd6Q0dOM0dFN2ZTNm1zZ1l3djhFZlV6?=
 =?utf-8?B?Z2F2STJHVW13aUxTMjdJNldsWkNKalF3Q1hXWEtSK3l4K3ROWjVrN0dIQXI2?=
 =?utf-8?B?NDREbTFTNzk2WHBGNkV2bzNCbTVCSkxPNG9vblBPYy92ZXQ1aERTcUpxd2M5?=
 =?utf-8?B?cGhrY2ZVQVY0UWdKWkI1WHhySmxzWDByZExGZ3UwTEdpY1VMSEZUemRqZU9X?=
 =?utf-8?B?MGp0NHMwSWN5Uzdna2RlS1MvNkw5Q3p1NHVUZGUyY2FTYkd5aUxBWVBrMHFW?=
 =?utf-8?B?Y3I4MERBNjk2emg2RGJIQ2tOb3U4ei9vWFFNOFV2YzNmZjFiV05DL3hXdS90?=
 =?utf-8?B?Vm9vbmFJeEFIUDBXSU1rLzM4REpMdytnT25ncjR6ZHRrM2krb05qS3k3NEd2?=
 =?utf-8?B?blJiS2JPWElDSC9PUVdwcFNBZFpkRHR2ckMrNVpCTnNCWmRGbWdQRDZsTTVl?=
 =?utf-8?B?QWljbUhJdzlHM1c2Y3JENG5GTVVtdng5WGh6d0srcnJzM1hwdE1Vd0ZHSXdX?=
 =?utf-8?B?R0xLeXdaNnVPUC9TZHhCVTZLV1UwQzJYK01KMmFMeHNycjRFWnpUcmgwS1VE?=
 =?utf-8?B?VlRXamFVcmNRL2txTEdBVmd2R245UzJ2UjFIL21VSHE1RzdZQndydDlJdGty?=
 =?utf-8?B?dllKUFJiNjBZK2dkRE9xWVdYYWhtRThwV0d5SHJ5VklBa3FZNXlSbjZQbUdB?=
 =?utf-8?B?Nm12Y2MvMmN4N3NJNGJBNFBsd3VzcGtOcStJY2RaeFVldFJKcHVSV1EvRENq?=
 =?utf-8?B?cDVmeXJKZW04cHlFL0prWHNuYzlXTnN0OFRJQlRLWlBQUDJDWnhpZldXdUNl?=
 =?utf-8?B?cE8xS1FYZEFRdXhJV1pPakRjMjZIY0svMVhLNHRHYXVDMktaY09zQjZHcW1C?=
 =?utf-8?B?VGJDLzhid1dDY3IweWJsa2tlNHV5Qm8zZVM3Mm1JS0VWcW9qbCtPNG4wMkhK?=
 =?utf-8?B?VkFROHBJaTY3dDVYTHVudmVQWHE5UE5KUmZ0V2tIWXRiUkxBcWoyTGtRczVy?=
 =?utf-8?B?UVROUnBOdW5uSUxzU1VIdkg5T3Nha3RkL3ZJaTR6ZGd5bTc0YjFxTngzSVkw?=
 =?utf-8?B?ZllhbGVnWXN6WDN5Tit0SDdzVDBpK0tTT3dGUHBCeUdCdmh3aER3Q09SOW1E?=
 =?utf-8?B?L2tWVHB2eE95a1I4VHZQUGZwcWt1TTRSUzlCdkwwcnAyOFhuSllHSm1jVUlp?=
 =?utf-8?B?NkMrcFp0eDBvdUFsNmJGTGliUXlWRDNjQmFLcEJ0WE9pNkVBRTViT01kZXFn?=
 =?utf-8?B?eFpsalAzVVpyUTA2NTJxR1o4T1NmYUowK2duK3ZkUVljbTZ5V3BSb1lsWTFQ?=
 =?utf-8?B?emt0OTFobUl1eVR4YmJrMGhrdzBGTCtJY0tla2pBa3R3ZE5ETTBtOXdnQWRI?=
 =?utf-8?B?SHFmWTJIK1JqVU5oQ2pzdkpPMGxvd25RbkxJK1ZHQ0FxTG5peWFLUDNLcHps?=
 =?utf-8?B?S1V5YUxibmk1ZmF5ajIrMGFLaXpacUJBSHBnajJvLzV4WnlySXdNMUtFTG1z?=
 =?utf-8?B?cmJJRVh2RnYzQmlHRUZuaTl1cWlnaWRwcE9mbWorV2t1YXpLWGJJYWcvNVZz?=
 =?utf-8?B?T2NKZGJFa1VleU1EZU9KM2FYL2plMHZqeFdoRGhnUFJJUjdhVW5PbnNvK0hz?=
 =?utf-8?B?M2JtZ216M3B0QmxQWVEwQjFMbkhkaGpnNityU0FRLzY0RjJSV0lnRWc2NlBK?=
 =?utf-8?Q?z96cee7MXWDqBs7IR8l9Vy73q?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6719c7b9-32c0-4196-27a7-08dc4da01f18
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB3109.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Mar 2024 14:22:09.3118
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lOhaVtTGuM/38SPUwY7DiKjzZMqA8cMd+foa9DRE4zH3Q62gat9ms54TfcyOeU3NJzBxL5007UFDJ/Qx8zAG5Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB8780

On 3/26/24 10:07, Borislav Petkov wrote:
> On Tue, Mar 26, 2024 at 09:41:41AM -0400, Yazen Ghannam wrote:
>> This isn't true which is why the module doesn't fail to load if debugfs
>> is not available.
> 
> How useful is this thing really without debugfs to dump records?
>

The goal of the module is to save and restore records across reboots.

The debugfs thing came later and the commit message states that it is
optional.

7d19eea51757 ("RAS/AMD/FMPM: Add debugfs interface to print record entries")

>> This was my first thought too. However, besides not true as stated
>> above, this also leaves the issue open for others to hit.
> 
> The others to hit? I don't get that part.
>

Sorry, I mean that if there's another user of ras_get_debugfs_root()
that doesn't depend on CONFIG_DEBUG_FS.

>> I think the fix below (not tested) would be more appropriate.
>>
>> What do you think?
> 
> Sure, remove my fix and send me a tested version of yours and I'll swap
> them if the driver is useful without debugfs...

Okay, will do.

Thanks,
Yazen