Received-SPF: pass (google.com: domain of linux-kernel+bounces-119178-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <656a7134-4984-4577-93eb-60c0c28adf93@amd.com>
Date: Tue, 26 Mar 2024 10:29:36 -0400
User-Agent: Mozilla Thunderbird
Cc: yazen.ghannam@amd.com,
 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] RAS/AMD/FMPM: Fix build when debugfs is not enabled
Content-Language: en-US
To: A <akira.2020@protonmail.com>, "bp@alien8.de" <bp@alien8.de>,
 "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>
References: <20240325183755.776-1-bp@alien8.de>
 <eede2586-f143-4107-a065-2860ed413d0a@amd.com>
 <i2PhAcMufioQc2nhVgO9T23CcF8UsgJo8CWPOl_7lV3iF00GdywfpQa2Hu-yPX3bD4o5wpfUtIsRBIhFH1j3k9aNoUJfgGALNWUUjMokpFc=@protonmail.com>
From: Yazen Ghannam <yazen.ghannam@amd.com>
In-Reply-To: <i2PhAcMufioQc2nhVgO9T23CcF8UsgJo8CWPOl_7lV3iF00GdywfpQa2Hu-yPX3bD4o5wpfUtIsRBIhFH1j3k9aNoUJfgGALNWUUjMokpFc=@protonmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZkcraVZaT0ZiWDMwdmc4K0xOS2krUDF3TXdKTUhtVGtMRFJVQVZsQ3FWc0k1?=
 =?utf-8?B?bnF0bXlUdXFFdFRnbjBteXFVTTQ4Tk43MStTbjAvT0psOTBZWGJRcGRzOUVl?=
 =?utf-8?B?dS9NZm5McExzcXBseksvVjRJbzAvMTZNaEZFeHNMb251OTc3aGFXR3MzOFR5?=
 =?utf-8?B?SytiZGYzbkpHVFFmOEZKSjRIUGtBVGFmWmVKYzFhempiOFZaMGo2K3c1VUpC?=
 =?utf-8?B?YWlJYmZMUUhwUHpjQjJ6QkFYSDA1YmtuS01RNVJ1cWYyT01zQWdRL0JiOUI5?=
 =?utf-8?B?Z1dqemtGSjgwbkw5a2xCK3Y2TWZmaU5qMUpyNW9saUVkcGQ0NUdTNDhqeGt6?=
 =?utf-8?B?Z09pbDVzTHBOeERmcXBCRkZnZ0w5YTRoZytiS0E2YXVJSHM0QnM3NEJxeDMr?=
 =?utf-8?B?L2hpc3VsZU9hMTc4a1RmVHgza1RwV05BQmtOYXNJWCtqK1RmeHdiN0JOMFpU?=
 =?utf-8?B?ejl6c1drRXA0SXhBd3lVWDA1VHJxZG1KUkRHS1pFZ1owV2x6VElKNWVHY0p4?=
 =?utf-8?B?UnFreml3YXZSTUdUcEYyQS83eVR5Y3VFN0VJeHVrZGN0cVNMVlg2TzYyU01U?=
 =?utf-8?B?WEc0UjBMd1RxZ2h0Q3o1cXI0NEFIeGxOWGl4VW1WM0F6YWQrd2d0N0dNVkEv?=
 =?utf-8?B?QWVQNHhzZmZCQ2FYeHZqUXU1czhCc1dsNDVVNHg4dU9uNlBTeUJRblNXdjEy?=
 =?utf-8?B?UTZZUlUwQ3FMVHV6ZnVVeHBQazhTVkpXNkE4Z3AwOU1NV2lKUnpYU2RTb2Jr?=
 =?utf-8?B?a0piaHdleUVPaU8zMER2K1Y5WXB1SXQ1YmQrc2pWUFpvM3JnRGRzMjJuY2dk?=
 =?utf-8?B?NU9yRWxYNS9SSlQwNmExOTVhMDhTT1NGbWJta0NIb2FNTkl1cEZCZDhGNEw5?=
 =?utf-8?B?UWI3RjBFc3VPK0pGYUU1ZkdKeGFOZnc5VjBmZFk1cU90MHVIWkNBV0RiUDBX?=
 =?utf-8?B?cnpzL0pMQ2p6NFI3cngwbE1vKzB6YnZtVHJUWjB0SzN6Y3RwcXJ4NHEybzBo?=
 =?utf-8?B?RkZEdWlxS0RQWWdGS0l4emN6ZXlIbDRoTWtZUXU0SDc2RDZrOExSK3d4Q2Vk?=
 =?utf-8?B?R3JOT3dGb3dIR21TQ2tkUGFPc2dCZ1k5NUk3eE9MOXFScEJWb2R1L2lYNUhU?=
 =?utf-8?B?ZTlGRGNacmVhM0thT1ovNTRnVDRwYU5ZK2FQV2w1Y2dCMTlZckcxYkJBK0FV?=
 =?utf-8?B?cXFMU3A1KzdBWks0WXhENWh0b3c5WXpFbFA4ZG44Y1pLYW9QU2U3U3B6Nkdi?=
 =?utf-8?B?U0tPNXZRZnZhNi84Q1dGL2lGd21ORlRXd3o0MzBOK2RwN3d0OFEvTjMzbkdL?=
 =?utf-8?B?WTZIeWRMalc0RVRzTFlUVXN6dXVpUjBMeFBwbDhrdnBmRjVHblNQdVFrRHJj?=
 =?utf-8?B?WFBpRWgyM2V6V3lJelp3eFNzTnVxREFKaHRpQlBsaDZQZGpzY011MXBMRStV?=
 =?utf-8?B?YjhWSnRIYU5NYllhZW1Nck9vTXBLRWg3a2dNQjNYRHRzN2NMc1doZXBIRmN2?=
 =?utf-8?B?R3NCM0RoZDlERjVnRFdwc1JGM2h5RFJCUkdmMnFKaDBmZEF6cEp4Z0U5L0g2?=
 =?utf-8?B?K2Fhc1hEa212NnlmNFh1V2lScWhsZFRVTGw2U00rd3Q1dDBsd1pFa2pGSTFW?=
 =?utf-8?B?dTd4azRNZHlaNXIvYVNob3FLa1Z4MGYvVURLdnVBQ2w4dUJMVnRxb3F0Qnkz?=
 =?utf-8?B?WFNEUVplWGxXUEx4OVpFV2piZEM5cGZGSWRaemVzK3hTTHNOTktJSENTZmZF?=
 =?utf-8?B?YjFwY3o3VWlhNU5Gb2dVbkZoamZNUXl3TlBDSktVOVptSW9WZlExYWI4bmFZ?=
 =?utf-8?B?VjlmWW1SbVNJWUxuU2pzZUlVZlFiOWY3UEpjdnVKVU1laEpUWlhjSzBZT3RS?=
 =?utf-8?B?WGxjckVaMzN2L21WVjdvVWZQcnAzSlFkTHNYTkxGYXJTdlhKWlFuV3JhR0pu?=
 =?utf-8?B?UWU3NjZYU3Y3bnFqbWdnYXhPSjVudTBwTjRkTU8xR2lwdThQOGhzOXB2dnJN?=
 =?utf-8?B?eG15WTB2aGYwNVE0TVgvUEZhUDVBcDQ0YTVzVGk3QTFzWGQ1UkRWL2tIYlNt?=
 =?utf-8?B?QkQ3SEdyRXF0VTRjbktDN3JUYWJjdkFVT0Y4bEZrSzdaVElmTkN4cEJLOFlZ?=
 =?utf-8?Q?xDJ7ZUvzSoeEODT6yKWiSrpl0?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1bdce994-2de2-4487-57c0-08dc4da12c56
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB3109.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Mar 2024 14:29:41.0445
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: eB2dlZpvrB6i2T6/lATzmg3wKoGd86EYphp9bMLgRd5p94q9+qcdLrxAILNDBebf7pj9d1KkJCepup3IKaxljg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4354

On 3/26/24 10:20, A wrote:
[...]
>>
>> diff --git a/drivers/ras/debugfs.h b/drivers/ras/debugfs.h
>> index 4749ccdeeba1..ab95831e7710 100644
>> --- a/drivers/ras/debugfs.h
>> +++ b/drivers/ras/debugfs.h
>> @@ -4,6 +4,10 @@
>>
>> #include <linux/debugfs.h>
>>
>>
>> +#if IS_ENABLED(DEBUG_FS)
>> struct dentry *ras_get_debugfs_root(void);
>> +#else
>> +static inline struct dentry ras_get_debugfs_root(void) { return NULL; }
>> +#endif / DEBUG_FS /
>>
>> #endif / RAS_DEBUGFS_H */
> 
> this also works, just tested
> 
> this time round, `make oldconfig` asks if i want to build RAS_FMPM, i built it as module, compilation succeeds.
> 

Thanks for testing!

Would you mind including your "Tested-by" tag? I can include this when I 
send a proper patch.

Thanks,
Yazen