Received-SPF: pass (google.com: domain of linux-kernel+bounces-119172-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Tue, 26 Mar 2024 14:27:00 +0000
From: Simon Horman <horms@kernel.org>
To: Su Hui <suhui@nfschina.com>
Cc: sgoutham@marvell.com, gakula@marvell.com, sbhatta@marvell.com,
	hkelam@marvell.com, davem@davemloft.net, edumazet@google.com,
	kuba@kernel.org, pabeni@redhat.com, nathan@kernel.org,
	ndesaulniers@google.com, morbo@google.com, justinstitt@google.com,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	llvm@lists.linux.dev, kernel-janitors@vger.kernel.org,
	Dan Carpenter <dan.carpenter@linaro.org>
Subject: Re: [PATCH net v2 2/2] octeontx2-pf: remove unused variables req_hdr
 and rsp_hdr
Message-ID: <20240326142700.GX403975@kernel.org>
References: <20240326061233.4133148-1-suhui@nfschina.com>
 <20240326061233.4133148-2-suhui@nfschina.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240326061233.4133148-2-suhui@nfschina.com>

+ Dan Carpenter

On Tue, Mar 26, 2024 at 02:12:36PM +0800, Su Hui wrote:
> Clang static checker(scan-buid):
> drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c:503:2: warning:
> Value stored to 'rsp_hdr' is never read [deadcode.DeadStores]
> 
> Remove these unused variables to save some space.
> 
> Signed-off-by: Su Hui <suhui@nfschina.com>

Hi Su Hui,

as pointed out by Dan in his review of v1 of this patch, it is not a fix.
This means that it should be targeted at the net-next rather than the net
branch. As the granularity of patch handling on netdev is generally at the
patchset level I believe that this means that you need to separately,
in different email threads, repost:

1. Patch 1/2 of this series, targeted at net

   [PATCH net v3] octeontx2-pf: check negative error code in otx2_open()

2. Patch 2/2 of this series, targeted at net-next

   [PATCH net-next v3] octeontx2-pf: remove unused variables req_hdr

Also, please be sure to wait 24 hours since the posting of this patch-set
before reposting.

Some more information can be found here:
https://docs.kernel.org/process/maintainer-netdev.html

..

-- 
pw-bot: changes-requested