Received-SPF: pass (google.com: domain of linux-kernel+bounces-119179-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: SeongJae Park <sj@kernel.org>
To: David Gow <davidgow@google.com>
Cc: SeongJae Park <sj@kernel.org>,
	Rae Moar <rmoar@google.com>,
	Mark Brown <broonie@kernel.org>,
	Johannes Berg <johannes.berg@intel.com>,
	linux-kselftest@vger.kernel.org,
	kunit-dev@googlegroups.com,
	linux-kernel@vger.kernel.org,
	Shuah Khan <skhan@linuxfoundation.org>,
	damon@lists.linux.dev
Subject: Re: [PATCH] kunit: configs: Enable CONFIG_DAMON_DBGFS_DEPRECATED for --alltests
Date: Tue, 26 Mar 2024 07:30:06 -0700
Message-Id: <20240326143006.15839-1-sj@kernel.org>
In-Reply-To: <20240326100740.178594-1-davidgow@google.com>
Precedence: bulk

On Tue, 26 Mar 2024 18:07:38 +0800 David Gow <davidgow@google.com> wrote:

> This is required, as CONFIG_DAMON_DEBUGFS is enabled, and --alltests UML
> builds will fail due to the missing config option otherwise.
> 
> Fixes: f4cba4bf6777 ("mm/damon: rename CONFIG_DAMON_DBGFS to DAMON_DBGFS_DEPRECATED")
> Signed-off-by: David Gow <davidgow@google.com>
> ---
> 
> This is breaking all UML alltests builds, so we'd like to fix it sooner
> rather than later. SeongJae, would you rather take this yourself, or can
> we push it alongside any other KUnit fixes?

Both are ok for me, but I think you pushing it with other kunit fixes may make
things simpler.  Please let me know if you'd prefer me to take this, though.

Sorry for the breakage, and thank you for making this nice fix!


Thanks,
SJ

> 
> Johannes: Does this conflict with the CONFIG_NETDEVICES / CONFIG_WLAN
> fixes to all_tests.config? I'd assume not, but I'm happy to take them
> via KUnit if you'd prefer anyway.
> 
> Thanks,
> -- David
> 
> ---
>  tools/testing/kunit/configs/all_tests.config | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/testing/kunit/configs/all_tests.config b/tools/testing/kunit/configs/all_tests.config
> index aa5ec149f96c..f388742cf266 100644
> --- a/tools/testing/kunit/configs/all_tests.config
> +++ b/tools/testing/kunit/configs/all_tests.config
> @@ -38,6 +38,7 @@ CONFIG_DAMON_VADDR=y
>  CONFIG_DAMON_PADDR=y
>  CONFIG_DEBUG_FS=y
>  CONFIG_DAMON_DBGFS=y
> +CONFIG_DAMON_DBGFS_DEPRECATED=y
>  
>  CONFIG_REGMAP_BUILD=y
>  
> -- 
> 2.44.0.396.g6e790dbe36-goog