Received: by 2002:ab2:6857:0:b0:1ef:ffd0:ce49 with SMTP id l23csp3377813lqp; Tue, 26 Mar 2024 07:41:14 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVnyEmSomsNZ/2dBaAHzgldRwKsLBCyiiq+nwurJirhEP8wkJ8Pk5H/Bbk0b4qROWzOyyv41Y0PBZ0lZ+trFqRxeF2qeda8TVt+cj7aXg== X-Google-Smtp-Source: AGHT+IEWGPaJMdk24Zf0xePd76UABvm3vMg9fDEwE19riM3PxEBjqy0h29vKBVFqvzEZIuBCGgrg X-Received: by 2002:a19:5e58:0:b0:513:a724:3b9f with SMTP id z24-20020a195e58000000b00513a7243b9fmr6868840lfi.7.1711464072999; Tue, 26 Mar 2024 07:41:12 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711464072; cv=pass; d=google.com; s=arc-20160816; b=A9Pyd1eYyuJFR6UAZDNUX3N15SUajj/pgeMUbk7RjOsk+DpEiiZmBvrT3tVfzoIFQP 4pAETAOl89cL1LsvUHY6a/RgyjKwSalhCOib/Mo08//n4L8Pdx22wJaasFFHi68ouiHW UqBV1ZzdE1YQcq+h+R+vjjeYUI2HSCu7qF+FZok6TUGpULnT/nwGw4zwVMrw8SX7rq/y hq6qsvPSC1jUUSqJHlfR4MhTjKF0WJqLJOI/koy2aFX/9YJVCxiOEiBoZp5bZu5uCcQO qKk8Kp6djZP/JC4uAOasyw43oLWo0e8VrYvRGQJDB/Om+9k0zpu0z1eftgwvTpxqr3y/ Ln/w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=organization:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :message-id:subject:cc:to:from:date:dkim-signature; bh=mHHewP06Xeo64L6yi+xQLvG4NAgcAQz80V0j0Rmu87g=; fh=rrol6owgu1HX4cyP0zyKBKsf0w92vkebkTyZh6/QYQM=; b=hdytWEfNabhvIuUXgmIpMam2k6I4lU7qOd8fAKf7sta7jLrjgw1XsFd9sCNwmww6iQ cBNGXId2XkLfIRssAn+KfCCumjOONJstWCH5FjStboSQCmbudW93sNX07hvs6OMtVBRO r7Dzja5s9hceBada7VnwwMiKVKP2xEKwRN4r0cvch2/MhLzfBSr7ljXP+SJLfeTeyoYZ //hIW1HEtqhHYMtmJw+ne3ppXv5QEXWmjvxSDlSweXzDm/wGIcOHnt6Pf5A2KGon85R1 2uRY33OB5YqTHy+3HLQ7QxYef4k13fsjKalFEYaB7Av9ClYIq69UxqLpRMkKhXRUFYjZ mo2Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=fGyhhm8U; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-119196-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-119196-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id sh9-20020a1709076e8900b00a4a398f312bsi1730353ejc.321.2024.03.26.07.41.12 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Mar 2024 07:41:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-119196-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=fGyhhm8U; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-119196-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-119196-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id B301F1F3D363 for ; Tue, 26 Mar 2024 14:41:12 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id CC83E13C3E9; Tue, 26 Mar 2024 14:41:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="fGyhhm8U" Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92183763E6 for ; Tue, 26 Mar 2024 14:41:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.9 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711464067; cv=none; b=JW+gtgwFNedf/55EPScj5bdh0wZMVmLGejLEB0dz4UCLRf7jOh5j1uKU7oi4ObPOU5cPwAclr2RW2EQx9XGb8Lfd8rePz5EInMdN6SsP10jog5PlORh+HG8V7t4xjZYQQGmSXBH5W2moHJEcORKVnYhg9ird1MokTM2aWzBoH5k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711464067; c=relaxed/simple; bh=Xppa6CV0HLfckPVMV8bTEk6yGO0xhJtUZzkAo69EJjs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QF8vPlXQzlyoBfInA5udGSBrgfh/lnUj9rQsSeteEElYGvQUaZTUe9VSI1gaDsSEqLOXVfiAEywNNuPg5rcTR3rOETJFp6IWTfWrDfRfdMHNaLD2x+o81rbdmZnz4L0cvAnft9bMjUq9ltIT5+hWUk35G7JVclgcNoKaLhofyRc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=fGyhhm8U; arc=none smtp.client-ip=198.175.65.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1711464065; x=1743000065; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Xppa6CV0HLfckPVMV8bTEk6yGO0xhJtUZzkAo69EJjs=; b=fGyhhm8UAQ2Wd3Za4W1bg1q6DCikL94IXroCI+NFg2FHF29doGr6ZhMP 2/CJFR6gZZsrJQ6ogyfm7vzANb0vIeNUutUPQuPnAflq8nq8wSgvYk8BE i2q6Z8A9+9HUluxLMnYlyY7Yd1ErAqLL0NMp1n0un8iv1zKDMZPWfJSwR zjpJeDmVyQNWLh4dhklJSwat4I0naEBYp4slaVSAURM5dXfQeefzibqE5 3hAl9VgIAmt/c3zaOhO7P7jequC/KZXYlwzVmBfU1v77/a+wa9uuBfxC4 xxNZtbq/BQOr3m1SZznZp2tmaMsWPzB93OoEER1N7FKLcFeWFcyj9bATu g==; X-CSE-ConnectionGUID: 7PnIYszMRKmIFt4Jjms30g== X-CSE-MsgGUID: LWSDPzLFSdeoh/0pLz67uA== X-IronPort-AV: E=McAfee;i="6600,9927,11025"; a="28997581" X-IronPort-AV: E=Sophos;i="6.07,156,1708416000"; d="scan'208";a="28997581" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2024 07:41:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,11025"; a="914882242" X-IronPort-AV: E=Sophos;i="6.07,156,1708416000"; d="scan'208";a="914882242" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2024 07:41:03 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rp7z3-0000000GKQw-0bLz; Tue, 26 Mar 2024 16:41:01 +0200 Date: Tue, 26 Mar 2024 16:41:00 +0200 From: Andy Shevchenko To: Mateusz K Cc: Bjorn Helgaas , Lee Jones , linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 1/1] mfd: intel-lpss: Switch over to MSI interrupts Message-ID: References: <20240312165905.1764507-1-andriy.shevchenko@linux.intel.com> <20240325211915.GA1449994@bhelgaas> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Tue, Mar 26, 2024 at 11:06:38AM +0100, Mateusz K wrote: > I tried the patch that changes PCI_IRQ_LEGACY into PCI_IRQ_ALL_TYPES > and it seems I get some other error now > > [ 1.477341] intel-lpss 0000:00:15.0: enabling device (0004 -> 0006) > [ 1.477466] intel-lpss 0000:00:15.0: can't derive routing for PCI INT A > [ 1.477468] intel-lpss 0000:00:15.0: PCI INT A: not connected > [ 1.477488] intel-lpss 0000:00:15.0: probe with driver intel-lpss > failed with error -2147483648 > [ 1.489572] intel-lpss 0000:00:15.2: enabling device (0004 -> 0006) > [ 1.489688] intel-lpss 0000:00:15.2: can't derive routing for PCI INT C > [ 1.489689] intel-lpss 0000:00:15.2: PCI INT C: not connected > [ 1.489715] intel-lpss 0000:00:15.2: probe with driver intel-lpss > failed with error -2147483648 > [ 1.501886] intel-lpss 0000:00:19.0: enabling device (0004 -> 0006) > [ 1.502034] intel-lpss 0000:00:19.0: can't derive routing for PCI INT A > [ 1.502036] intel-lpss 0000:00:19.0: PCI INT A: not connected > [ 1.502067] intel-lpss 0000:00:19.0: probe with driver intel-lpss > failed with error -2147483648 > [ 1.514288] intel-lpss 0000:00:19.1: enabling device (0004 -> 0006) > [ 1.514535] intel-lpss 0000:00:19.1: can't derive routing for PCI INT B > [ 1.514538] intel-lpss 0000:00:19.1: PCI INT B: not connected > [ 1.514570] intel-lpss 0000:00:19.1: probe with driver intel-lpss > failed with error -2147483648 > [ 1.526291] intel-lpss 0000:00:1e.0: enabling device (0004 -> 0006) > [ 1.526555] intel-lpss 0000:00:1e.0: can't derive routing for PCI INT A > [ 1.526557] intel-lpss 0000:00:1e.0: PCI INT A: not connected > [ 1.526604] intel-lpss 0000:00:1e.0: probe with driver intel-lpss > failed with error -2147483648 > [ 1.538130] intel-lpss 0000:00:1e.3: enabling device (0004 -> 0006) > [ 1.538233] intel-lpss 0000:00:1e.3: can't derive routing for PCI INT D > [ 1.538235] intel-lpss 0000:00:1e.3: PCI INT D: not connected > [ 1.538253] intel-lpss 0000:00:1e.3: probe with driver intel-lpss > failed with error -2147483648 Hmm... I have a unique board to test :-) Let's revert it then. Bjorn, in such case your tree should keep conversion one. Lee, do you prefer a revert or can you simply drop this from the queue? -- With Best Regards, Andy Shevchenko