Received-SPF: pass (google.com: domain of linux-kernel+bounces-119243-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Tue, 26 Mar 2024 10:57:27 -0400
From: Frank Li <Frank.li@nxp.com>
To: Xu Yang <xu.yang_2@nxp.com>
Cc: will@kernel.org, mark.rutland@arm.com, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de,
	festevam@gmail.com, john.g.garry@oracle.com, jolsa@kernel.org,
	namhyung@kernel.org, irogers@google.com, mike.leach@linaro.org,
	peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
	alexander.shishkin@linux.intel.com, adrian.hunter@intel.com,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
	imx@lists.linux.dev
Subject: Re: [PATCH v8 8/8] perf vendor events arm64:: Add i.MX93 DDR
 Performance Monitor metrics
Message-ID: <ZgLiV8/1Pox1zSqa@lizhi-Precision-Tower-5810>
References: <20240322063930.749126-1-xu.yang_2@nxp.com>
 <20240322063930.749126-8-xu.yang_2@nxp.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240322063930.749126-8-xu.yang_2@nxp.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?4KKMZb0h0XlhvUNNK+WzBsu2ExGibBHONcTgzgIqeBc1nKNBhRqodG3tOSP5?=
 =?us-ascii?Q?1Y9t8ddUSvPPW95YpSKmM3kfW+/ryQ7p1R0kr/RqZM/9phyjxo3dZyS5i2iK?=
 =?us-ascii?Q?edF5iluGCh0v6rLA2zNlxuDTW5uA7qM1SAOBcsXLQuu1GTJCv4pG/n/aujjV?=
 =?us-ascii?Q?vBulUenM8i8MsWrbxE8BSDlvF7bxZSRGxsWP73jSEpGKsa2Jquk+1fUmDhQI?=
 =?us-ascii?Q?/akisx+/o8AxMyZOSu3cs+UyocB3ir7TtvvN5bYBD4SMPMXSwbibULjNJ8m9?=
 =?us-ascii?Q?v93NFKnNxZJ2RajyKdLef+vxR5Bv21NTOO6zPtE2y3bSQDGLXntGeSFpAxPE?=
 =?us-ascii?Q?sjD5jeHDwIufgzRG928UgVyouBly8oD8T2oGJMXD5GOhu9VJrv3C/Dj3om4e?=
 =?us-ascii?Q?glbAjsepy3nUdZWLdQ9EF0tCg3+28Qy+Xe2kQ/wRPuITnsAg+QLCSXvw1Y6j?=
 =?us-ascii?Q?+fi587+5R05dhzB+ZNDRWYnv/5PkRqvtUVEZu6gcmlX0x+hHGJS+P0iPgnO1?=
 =?us-ascii?Q?/WY6XxyWKlZcmbGMWPyl8cZM3oJLnN8PG45/ggGQNF1bGpXS11SFw4VWTyou?=
 =?us-ascii?Q?5WvjsxWHSlsfXm0uy9EhKyZxHW7oswvxOJnMbCFRHlZlWRqXIqSNihVwEa04?=
 =?us-ascii?Q?vUPQQMM1BS4/bBWSNrZYIfuuMrNhrhgjl5o4hfTgP+ds7j5fZhxO+4Yg3xA5?=
 =?us-ascii?Q?Md3gHkwyaDPA9QoLEze2ya3uV2fBNtiCRNg6bLEm1uQPzamQrqYCC6mP6E8Z?=
 =?us-ascii?Q?yTbqnoEIgy8DrQM0RN1GYrDgGA1uupDxtmMkkASoIz9/dipcmSC3V3vDZRQ1?=
 =?us-ascii?Q?L2RpNbIXn2/r7M9WRNRSuCFCwnNJW0LAapaOrYgqopAIFcfVAlOa+5VMeXrq?=
 =?us-ascii?Q?kcDRrpLwhf+TdXoIuZxWUSc9PwVrJSsP8L53I7VMLyoENxVVa7CcSr3F7fhk?=
 =?us-ascii?Q?iT0Om+l44a7CNKkBomn7GuxrDI4x0x8UL7/sw5oFeAgbVGowU8SlFnp5e9oV?=
 =?us-ascii?Q?Qs21kV0nU8NICQf5TkEXOizu1mPnkzoYKsZuHmxrYOz1wJ6DdnF6nzngfuwf?=
 =?us-ascii?Q?07JSVJ7YcBsaSbvqJ9g9dOREkBSLhEHCYP6gmt8Lffpsw1BOAKm/AMm5pijL?=
 =?us-ascii?Q?43c/C7so34pfjM3IIxCUoL2DUlmAREQFUQsm6DcFD0PK5paaNiuYYmdh8rLs?=
 =?us-ascii?Q?flbW4dIaZ53FXXBjrHdf3d+ixJYNoZqo93+143q9WWEfx6jrDz29ANwoAfS5?=
 =?us-ascii?Q?dfuBlk4fslhILQCwbyTzBFnozNj807T42n9SREU9bMe6ltm+9s1Skeq353nQ?=
 =?us-ascii?Q?fksyItw86jDv63BsMqPmkp7eeOFQISZblUEfT50GhpXHhLzCNuqGDsnv1AML?=
 =?us-ascii?Q?gvPrxcfOIF/X2VjC0vMvu9oY8QIXtWT2j8HyXVAR1KFxVEQyCmVMdGUXEY1c?=
 =?us-ascii?Q?ipHEU35UUksMmUop/hztRHOGVXI5w2KEKboBmbKZUeNXJT4sm51HmeQmjujM?=
 =?us-ascii?Q?2LfGzto7oO9s2xs8zr4nL/IOP3zauFDo2BJnepB8IGc6lkXOU71rtNDHh7zD?=
 =?us-ascii?Q?gtROKMfSrH7IV/onk264t8fetiWT1DoNbxAntEyu?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cee85c27-6a04-452d-8bc4-08dc4da513e5
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Mar 2024 14:57:37.9755
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yW4jHWw66YMfEE4Z+TKf7fTRjeLuX5fpqCGmuAStHHAFnt7AFGDzqCWNJrEHRBQvotQMqI8M5g2/laENHow81w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR04MB9691

On Fri, Mar 22, 2024 at 02:39:30PM +0800, Xu Yang wrote:
> Add JSON metrics for i.MX93 DDR Performance Monitor.
> 
> Signed-off-by: Xu Yang <xu.yang_2@nxp.com>

Reviewed-by: Frank Li <Frank.Li@nxp.com>

> 
> ---
> Changes in v7:
>  - new patch
> Changes in v8:
>  - no changes
> ---
>  .../arch/arm64/freescale/imx93/sys/ddrc.json  |  9 +++++++
>  .../arm64/freescale/imx93/sys/metrics.json    | 26 +++++++++++++++++++
>  2 files changed, 35 insertions(+)
>  create mode 100644 tools/perf/pmu-events/arch/arm64/freescale/imx93/sys/ddrc.json
>  create mode 100644 tools/perf/pmu-events/arch/arm64/freescale/imx93/sys/metrics.json
> 
> diff --git a/tools/perf/pmu-events/arch/arm64/freescale/imx93/sys/ddrc.json b/tools/perf/pmu-events/arch/arm64/freescale/imx93/sys/ddrc.json
> new file mode 100644
> index 000000000000..eeeae4d49fce
> --- /dev/null
> +++ b/tools/perf/pmu-events/arch/arm64/freescale/imx93/sys/ddrc.json
> @@ -0,0 +1,9 @@
> +[
> +   {
> +           "BriefDescription": "ddr cycles event",
> +           "EventCode": "0x00",
> +           "EventName": "imx93_ddr.cycles",
> +           "Unit": "imx9_ddr",
> +           "Compat": "imx93"
> +   }
> +]
> diff --git a/tools/perf/pmu-events/arch/arm64/freescale/imx93/sys/metrics.json b/tools/perf/pmu-events/arch/arm64/freescale/imx93/sys/metrics.json
> new file mode 100644
> index 000000000000..4d2454ca1259
> --- /dev/null
> +++ b/tools/perf/pmu-events/arch/arm64/freescale/imx93/sys/metrics.json
> @@ -0,0 +1,26 @@
> +[
> +   {
> +	    "BriefDescription": "bandwidth usage for lpddr4x evk board",
> +	    "MetricName": "imx93_bandwidth_usage.lpddr4x",
> +	    "MetricExpr": "(((( imx9_ddr0@ddrc_pm_0@ ) * 2 * 8 ) + (( imx9_ddr0@ddrc_pm_3@ + imx9_ddr0@ddrc_pm_5@ + imx9_ddr0@ddrc_pm_7@ + imx9_ddr0@ddrc_pm_9@ - imx9_ddr0@ddrc_pm_2@ - imx9_ddr0@ddrc_pm_4@ - imx9_ddr0@ddrc_pm_6@ - imx9_ddr0@ddrc_pm_8@ ) * 32 )) / duration_time) / (3733 * 1000000 * 2)",
> +	    "ScaleUnit": "1e2%",
> +	    "Unit": "imx9_ddr",
> +	    "Compat": "imx93"
> +   },
> +   {
> +	    "BriefDescription": "bytes all masters read from ddr",
> +	    "MetricName": "imx93_ddr_read.all",
> +	    "MetricExpr": "( imx9_ddr0@ddrc_pm_0@ ) * 2 * 8",
> +	    "ScaleUnit": "9.765625e-4KB",
> +	    "Unit": "imx9_ddr",
> +	    "Compat": "imx93"
> +   },
> +   {
> +	    "BriefDescription": "bytes all masters write to ddr",
> +	    "MetricName": "imx93_ddr_write.all",
> +	    "MetricExpr": "( imx9_ddr0@ddrc_pm_3@ + imx9_ddr0@ddrc_pm_5@ + imx9_ddr0@ddrc_pm_7@ + imx9_ddr0@ddrc_pm_9@ - imx9_ddr0@ddrc_pm_2@ - imx9_ddr0@ddrc_pm_4@ - imx9_ddr0@ddrc_pm_6@ - imx9_ddr0@ddrc_pm_8@ ) * 32",
> +	    "ScaleUnit": "9.765625e-4KB",
> +	    "Unit": "imx9_ddr",
> +	    "Compat": "imx93"
> +   }
> +]
> -- 
> 2.34.1
>