Received-SPF: pass (google.com: domain of linux-kernel+bounces-119253-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Tue, 26 Mar 2024 12:01:18 -0300
From: Jason Gunthorpe <jgg@nvidia.com>
To: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: Andrew Morton <akpm@linux-foundation.org>, Peter Xu <peterx@redhat.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [RFC PATCH 1/8] mm: Provide pagesize to pmd_populate()
Message-ID: <20240326150118.GI6245@nvidia.com>
References: <cover.1711377230.git.christophe.leroy@csgroup.eu>
 <54d78f1b7e7f1c671e40b7c0c637380bcb834326.1711377230.git.christophe.leroy@csgroup.eu>
 <20240325161919.GD6245@nvidia.com>
 <6e16e042-0143-4a52-b4b7-09cf0022bc3e@csgroup.eu>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <6e16e042-0143-4a52-b4b7-09cf0022bc3e@csgroup.eu>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?ZoQo4pmnp7qsaVBP32roq37B79KrTyA11vdkKeV3tlwB6gwQFBiZe7LstTcX?=
 =?us-ascii?Q?SxtSH+I2xCMjI6tQlldOFaVcHD7jk4PGInH6+xQWiYhqlhHfaJm8kXRC+8s/?=
 =?us-ascii?Q?yabiseWpdlZ48ZjKri+OlTknjkGThJh6nATVugCnzym1APVcZSEmcSEZstgp?=
 =?us-ascii?Q?Pkg2spMvjh/qpZOF31DouXm1PQjEYoPNSeDCCgyqqWpYe5dJxOUAE3SWoddh?=
 =?us-ascii?Q?tQR2g25QMLBCnPjIQn0OKGcQ8e+WR9hlYJHROcaSUpJPCa5J2bYRlOOfOiCU?=
 =?us-ascii?Q?6n6LzLRB5JtsU0jzgtOTfuK1XxDtqQYBwQ/4fZSp7jEH4tB3xMvWBIiPlDKT?=
 =?us-ascii?Q?EHhOzBUA9PBwODpUcgxmgR6JYMRdtaND2dIwHrsW8N23SWoZ2JM9So3qRbD5?=
 =?us-ascii?Q?LeSZDGNrsecbyBWlScmbPOlxAiHvHWyNb0ghRVXWltmOgftUZGCIMntC93FG?=
 =?us-ascii?Q?0AG7Yc01cOUauvLkYd5ab5LdxnlRNr805S9WgLPc7qQUvtWbWutOzJQO/w1q?=
 =?us-ascii?Q?FASEh8FvH150HV9uUirt6+hjv2gWR5intP2xk5pPR0NNLWiHaOFzrXV1YqKL?=
 =?us-ascii?Q?tNLqMHTDA2RSG6htkeLNrgqjPHquEwta8IEjW1WECxEz9qOp0QjCyrrtN8ZP?=
 =?us-ascii?Q?Ia8vNM1kU0kK9VL0WUN8zcttV/ym0jAstUV0Wte9LEyzgUpyy54hQ4s6Wl5a?=
 =?us-ascii?Q?/NShY2mVQX84+NxoGK54n00NbYipjrh8bQvwmQumIkUaZPlns4KcGYWymYlQ?=
 =?us-ascii?Q?LDJmyrlZkFLFKkrZEGr/LKHfsRnLzy35V5yLWxfRrhudUfle0bx68O9N1cLd?=
 =?us-ascii?Q?a2iBencaouVSgFjkKP2f0Uku4wrxPKcKXrbpTy0X118XnlJUU4WBeSdLZ+gw?=
 =?us-ascii?Q?50DUWH+Fmw0JjtBeZ+G04yKpNUDVMuxXcT/QFR3geU4BRhxsuzJE8oOpPPln?=
 =?us-ascii?Q?VCpl8r4AmQTlHbfcuitU/QX2YYwXy/zYWLO26PSElf4h7HL1ZRwReLmq7E/4?=
 =?us-ascii?Q?L+8VpS6q3cE+eVi8ObxJteDpKaI6WniQpH3fXnw5DE6/QS0Kdr6lNwzjr3oN?=
 =?us-ascii?Q?B5h8T60KUQ6DSpGju/6Jy0VEvuKAWipz4cAL9urOhY/yK2amzEmkQtrUTPZB?=
 =?us-ascii?Q?6Ds6gMLCiFLHn//6MOGqyP7Z2PZUp0PPVVW+HGhRZZKjjCJUHiicXzKoy9pu?=
 =?us-ascii?Q?s87hxC8wZASI8nlg1aMDIiqyc1C9rjIbAc+r0+MbvauvfWp6KFr5IkRMjW5y?=
 =?us-ascii?Q?a6atebeZQJW9vRRfHgAZJ4mqRNgg4daZZEIucY6ViCVRnRzkOBFatG3PgaGu?=
 =?us-ascii?Q?sEpuAZjEe9nitBXkDHyXsq2/KEGb3/v2ZbuPrJOvdoGrBcpxLd/9ZH4rbVWw?=
 =?us-ascii?Q?cxFB/MrdsJV4us6CoDRouv+A39So72aIb8kVN8rQrAj525a+bkAViqXI2Io4?=
 =?us-ascii?Q?6fsDSs5neOZvfTjuFYDnrAZ32O7pBBdx1a3grZOeegkK+RBxPo1m3TgoDzbb?=
 =?us-ascii?Q?okEfwpfSoO1Ba2chJF5plXNpX+YfR43wn3YN8dMEYlDIf+F2yHgQrhv2S7Va?=
 =?us-ascii?Q?+Ji0pXqZHAjY4Pf4ROSMVklWvzyZT3BJUH3SLSFb?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8e08161f-dca7-446c-0c46-08dc4da59790
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3849.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Mar 2024 15:01:18.8821
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NFoWD8HximVzLgKaSeveenFyXnq/nHIglRgkU7JnrDz5VPvuBFtoy6atNcpKkpYk
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB8986

On Mon, Mar 25, 2024 at 07:05:01PM +0000, Christophe Leroy wrote:

> Not looked into details yet, but I guess so.
> 
> By the way there is a wiki dedicated to huge pages on powerpc, you can 
> have a look at it here : 
> https://github.com/linuxppc/wiki/wiki/Huge-pages , maybe you'll find 
> good ideas there to help me.

There sure are alot of page tables types here

I'm a bit wondering about terminology, eg on the first diagram "huge
pte entry" means a PUD entry that is a leaf? Which ones are contiguous
replications?

Just general remarks on the ones with huge pages:

 hash 64k and hugepage 16M/16G
 radix 64k/radix hugepage 2M/1G
 radix 4k/radix hugepage 2M/1G
 nohash 32
  - I think this is just a normal x86 like scheme? PMD/PUD can be a
    leaf with the same size as a next level table. 

    Do any of these cases need to know the higher level to parse the
    lower? eg is there a 2M bit in the PUD indicating that the PMD 
    is a table of 2M leafs or does each PMD entry have a bit
    indicating it is a leaf?

 hash 4k and hugepage 16M/16G
 nohash 64
  - How does this work? I guess since 8xx explicitly calls out
    consecutive this is actually the pgd can point to 512 256M
    entries or 8 16G entries? Ie the table size at each level is
    varable? Or is it the same and the table size is still 512 and
    each 16G entry is replicated 64 times?

    Do the offset accessors already abstract this enough?

 8xx 4K
 8xx 16K
   - As this series does?

Jason