Received-SPF: pass (google.com: domain of linux-kernel+bounces-119284-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Tue, 26 Mar 2024 16:15:03 +0100
From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Rob Herring <robh@kernel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, 
	Tony Lindgren <tony@atomide.com>, devicetree@vger.kernel.org, linux-omap@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: hsi: hsi-client: convert to YAML
Message-ID: <5z2b74h2zvo7fwc4624hy5vegvlkyfdflijr35byqeemoiwd6l@vfebii4m2mim>
References: <20240325-hsi-dt-binding-v1-0-88e8e97c3aae@collabora.com>
 <20240325-hsi-dt-binding-v1-1-88e8e97c3aae@collabora.com>
 <2905247d-03b0-45c1-add5-d3c2a986d87c@linaro.org>
 <hz4fbdix5yaz2wtdkjkf23pc3m4kbeavynvjagundqvv3bisor@lc7dev4667i5>
 <1c6d995a-b1f1-48ca-b85c-f69071e7e3bb@linaro.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="yeqb2gbu3cd3r5gn"
Content-Disposition: inline
In-Reply-To: <1c6d995a-b1f1-48ca-b85c-f69071e7e3bb@linaro.org>


--yeqb2gbu3cd3r5gn
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Tue, Mar 26, 2024 at 01:56:22PM +0100, Krzysztof Kozlowski wrote:
> >>> +allOf:
> >>> +  - if:
> >>> +      required:
> >>> +        - hsi-mode
> >>> +    then:
> >>> +      properties:
> >>> +        hsi-rx-mode: false
> >>> +        hsi-tx-mode: false
> >>
> >> I don't understand what you are trying to achieve here and with anyOf.
> >> It looks like just oneOf. OTOH, old binding did not exclude these
> >> properties.
> >=20
> > So the anyOf ensures, that either hsi-mode or hsi-rx-mode +
> > hsi-tx-mode are specified. Those properties were previously
>=20
> Not entirely. anyOf should succeed also when none of them are present,
> which is not what you want in such case.

Right, this should be oneOf instead of anyOf. I fixed that for v2.

> > listed as required and they are indeed mandatory by the Linux
> > kernel implementation.
> >=20
> > The old binding also has this:
> >=20
> > hsi-mode:		May be used ***instead*** hsi-rx-mode and hsi-tx-mode
> >=20
> > So it's either hsi-rx-mode + hsi-tx-mode OR hsi-mode, but not
> > all properties at the same time. That's what the allOf ensures:
> > if hsi-mode is specified, then hsi-rx-mode and hsi-tx-mode may
> > not be specified.
>=20
> Then wouldn't this work for you:
> https://elixir.bootlin.com/linux/v5.17-rc2/source/Documentation/devicetre=
e/bindings/reserved-memory/reserved-memory.yaml#L91

I suppose you mean using "then: not: required: PROPERTY" instead of
"then: PROPERTY: false"? The variant using "PROPERTY: false" is what
is being used in example-schema.yaml:

https://elixir.bootlin.com/linux/v6.8/source/Documentation/devicetree/bindi=
ngs/example-schema.yaml#L225

IMHO the "not: required: property" is harder to understand. I would
expect that to mean "the property is not required (i.e. optional)"
instead of "the property is not allowed".

-- Sebastian

--yeqb2gbu3cd3r5gn
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmYC5mkACgkQ2O7X88g7
+pookw/+Pk8sDVd/2OVqArL9SX+OsfGAfU13EfiTc7IofAwKSmoJWYpOAllEZZSO
AYjajSdUP2dCNA6p///aeYQWWBprdqEquthQqJo5XD7kOPoU1N9uOLiaRSNbizC6
TGzmcsrMWv/gHb72YgVrIcEdnmQ+md1ssnIwW70ZUW+piAlcAcvHoygZXrPk2nGa
lgBdraeg+jCIc3s+1g+rQR2Lr1EEvgAUGTnLHceEORpwsIkfq3UhOZfgtyVwWHiv
iF42GYBz6Jes+SO+YdB2hch8IrpoHjqjMUbmiZn9s/0QIHcHPl/EOQz8E6Blz557
4/L0X6cOMVffdhJ7lK3kaGVns1Bacgtw0pQs1RrZppG+ri+0s0nfPQA2WYzgcojy
t2/S5eopdtzbAWPYHcl26xvMUHxxY7RwhaSyWBNOFSr6O3V72juCT7uWDDisyXqu
tD8anKrqGiGa38JA6AXboqV8f+V7ijrs6cbZCTCtfBU+m5k/lR7GKz8Aaf9fuOad
QDniPipbNyfh3dbxirx7fOsRaMB42ncqpsxXkupzD1fEetPcq2qEWFgxo0eZr3Hk
V7kkqUvqorVGuk9n2F4ZW8S/Cw9VrSrNwWnpuRTslZUph4g23BGSHavHS/xcsgPn
oU+WIqjq7ylcMka7Er94D041Er7Mr2bqhAbuPdVStry8j265S7U=
=hn9F
-----END PGP SIGNATURE-----

--yeqb2gbu3cd3r5gn--