Received: by 2002:ab2:6857:0:b0:1ef:ffd0:ce49 with SMTP id l23csp3407713lqp; Tue, 26 Mar 2024 08:22:42 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUoU5SrZ/zNzEoeLPUlnIOtxwOJBC5hnTLhjwd0qjOM2aszg5exRbQF6LKYoH5OcFeIn6sUaeQWDXJJsxqZXHehI9q2xCEhaoE2t523SA== X-Google-Smtp-Source: AGHT+IFwjwQ4ziOsv8QEVUWkESIyeUS2f/9+7P3o7hLO+k0umKlLbkWT8JakcdeC12jgttr8k8SB X-Received: by 2002:ac8:594d:0:b0:430:c05c:86ef with SMTP id 13-20020ac8594d000000b00430c05c86efmr13266668qtz.1.1711466562379; Tue, 26 Mar 2024 08:22:42 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711466562; cv=pass; d=google.com; s=arc-20160816; b=CPD1lN9KAMj12bhRXbWdSccBO2ZR0DhIWnYk+Rb4WTxjme6aQE/UxrjeM3sBhSqbg4 JVFAVEbex84MbrE3Cotm7n+888CVNqH8xyOeTIXtTakfEskJZMlT3tPo5W8AYX7ylNVm PexWLZ3fIbNQFaTGkWolm65234stm/LDcXBWYnni0elqC4zD6DecBGG1sNx6mDdIzcyO Twda3ukliK8F9UnNI609URf9scZuCgS/o6AjDvZGRkFELpXHfPn3/GFoD7ChSgxE8GYU NxZuUWOkju6DpkRThCkdfuHIZNMu4zP0XPSUrwsXYLrf7r7YocfjectzwWKuWYXHzAdZ cVZA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:references:in-reply-to:subject:cc:to:from:message-id :date:dkim-signature:dkim-signature:dkim-signature:dkim-signature; bh=KXH5uUDLtBRAB47YTVHB6bZditscTqY6M49f3hWQIm0=; fh=NYqTGl0D2RymSzNVDiSaYFWMZuf7DfV7CbcTQvt80Sc=; b=u2ZQtjIGxKBFSI7sfGsg+bYLfBMnICTEz9szVMH/f9I5bvCHyiezhhR0EVRLrVzVqQ QWQCumdaxHoqOGe7/d+AkIIpdhhU4CQWMYamDXHstBRl4pezRPLfWOgfPxC3snAEyG89 0KXKwXRi2G/BFo6gdL1beOXuxb14I+cbIt4C/deSho0XfPGu5J7VIhz8rLDhayI7sywV 1O1gxHoN/x21RmKhGVN/JFbj2psQBhWlh4Y9xumBMshvgh4Nsu5wUYIWDQCXj3VXeQ4s fwm0fDwXkAyDYWy5WjiatayJoQ5i1JMZTU6UBY7V+DEOhNFdcP5D+yzHVYr+DXemfeYW BnOQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=hWjOzW1H; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=pNMv7idU; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=hWjOzW1H; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; arc=pass (i=1 spf=pass spfdomain=suse.de dkim=pass dkdomain=suse.de dkim=pass dkdomain=suse.de dmarc=pass fromdomain=suse.de); spf=pass (google.com: domain of linux-kernel+bounces-119295-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-119295-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id w10-20020a05622a134a00b00430c8e65eeasi7319257qtk.4.2024.03.26.08.22.42 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Mar 2024 08:22:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-119295-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=hWjOzW1H; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=pNMv7idU; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=hWjOzW1H; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; arc=pass (i=1 spf=pass spfdomain=suse.de dkim=pass dkdomain=suse.de dkim=pass dkdomain=suse.de dmarc=pass fromdomain=suse.de); spf=pass (google.com: domain of linux-kernel+bounces-119295-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-119295-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 1DD021C2FBAF for ; Tue, 26 Mar 2024 15:22:42 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D305513C823; Tue, 26 Mar 2024 15:22:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="hWjOzW1H"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="pNMv7idU"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="hWjOzW1H"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="pNMv7idU" Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 441C458220 for ; Tue, 26 Mar 2024 15:22:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711466558; cv=none; b=TUIMVaLAofTfsv3n3McK1tZZZYl8DV4fOvthFoWl02Vo9i6gsTdnkH0n7PeswKvC6OStXuYwbWfWuySlD00TMeb4fULyhBMoci+X/7ej+zZlHBR0RriiQTNbmxpGQMIAZrBNd1QuCC/gyuyMwWs3mB3wix+S3cQfnkDSOdT7Ui4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711466558; c=relaxed/simple; bh=fBNcQUHOtvyZsysftwY23WAq61KVO16Ox520bWwmTKE=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=oG4uCNPmHP8/PE8hPBltfOGQsu3IJ+cHzNOVf2tOWXVoram7vZYbixZKEAVZB2mHY72IxwpyiV+ISehRO7/6au8jo43YHWoQECj10IuJcw/L2v2oQNOLfbTXUC+bV19Z1RZLpQIkdaXzqx2mIb6mf1uos0qP5PTBVe8+qOK1LPg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=hWjOzW1H; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=pNMv7idU; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=hWjOzW1H; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=pNMv7idU; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 73B3221E3D; Tue, 26 Mar 2024 15:22:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1711466554; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KXH5uUDLtBRAB47YTVHB6bZditscTqY6M49f3hWQIm0=; b=hWjOzW1HqNS1ii0R8rstNDFJMG0KONLVKpbkNxwUISXQ3rq84H7y7dbv2TAc/G9D5vxGTU uY7/9kFo2jqr45S8FQXU8mZjC4ur4oIIdBddNeYGV0KekJFMeOoCzUTvYu36tcy1KCLiPG YSH1+bY0pSP7F6HFSgaKsc9lSy1i/LQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1711466554; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KXH5uUDLtBRAB47YTVHB6bZditscTqY6M49f3hWQIm0=; b=pNMv7idUbMhs/IcgPQmJKVhGDE3oaaAPdU69K4zrkrZ8OkyivBHN1W9uDLa8fagjaOvHhx booslhzqaTBZz0Ag== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1711466554; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KXH5uUDLtBRAB47YTVHB6bZditscTqY6M49f3hWQIm0=; b=hWjOzW1HqNS1ii0R8rstNDFJMG0KONLVKpbkNxwUISXQ3rq84H7y7dbv2TAc/G9D5vxGTU uY7/9kFo2jqr45S8FQXU8mZjC4ur4oIIdBddNeYGV0KekJFMeOoCzUTvYu36tcy1KCLiPG YSH1+bY0pSP7F6HFSgaKsc9lSy1i/LQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1711466554; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KXH5uUDLtBRAB47YTVHB6bZditscTqY6M49f3hWQIm0=; b=pNMv7idUbMhs/IcgPQmJKVhGDE3oaaAPdU69K4zrkrZ8OkyivBHN1W9uDLa8fagjaOvHhx booslhzqaTBZz0Ag== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 0B83613306; Tue, 26 Mar 2024 15:22:34 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap1.dmz-prg2.suse.org with ESMTPSA id JwdzATroAmYETQAAD6G6ig (envelope-from ); Tue, 26 Mar 2024 15:22:34 +0000 Date: Tue, 26 Mar 2024 16:22:35 +0100 Message-ID: <877chpuif8.wl-tiwai@suse.de> From: Takashi Iwai To: Baojun Xu Cc: Andy Shevchenko , robh+dt@kernel.org, lgirdwood@gmail.com, perex@perex.cz, pierre-louis.bossart@linux.intel.com, kevin-lu@ti.com, 13916275206@139.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, liam.r.girdwood@intel.com, yung-chuan.liao@linux.intel.com, broonie@kernel.org, soyer@irl.hu Subject: Re: [PATCH v1 2/8] ALSA: hda/tas2781: Add tas2781 SPI-based driver In-Reply-To: References: <20240326010905.2147-1-baojun.xu@ti.com> <20240326010905.2147-2-baojun.xu@ti.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Authentication-Results: smtp-out1.suse.de; none X-Spam-Level: X-Spam-Score: 0.12 X-Spamd-Result: default: False [0.12 / 50.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; R_RATELIMIT(0.00)[to_ip_from(RL3kqsx7g8wwj8c3joodxqsamu)]; RCVD_COUNT_THREE(0.00)[3]; NEURAL_HAM_SHORT(-0.20)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; BAYES_HAM(-1.08)[88.02%]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; FREEMAIL_ENVRCPT(0.00)[139.com,gmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TAGGED_RCPT(0.00)[dt]; MIME_GOOD(-0.10)[text/plain]; NEURAL_HAM_LONG(-1.00)[-1.000]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCPT_COUNT_TWELVE(0.00)[14]; MID_CONTAINS_FROM(1.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; FREEMAIL_CC(0.00)[linux.intel.com,kernel.org,gmail.com,perex.cz,ti.com,139.com,alsa-project.org,vger.kernel.org,intel.com,irl.hu]; RCVD_TLS_ALL(0.00)[]; SUSPICIOUS_RECIPS(1.50)[] X-Spam-Flag: NO On Tue, 26 Mar 2024 16:00:19 +0100, Andy Shevchenko wrote: > > On Tue, Mar 26, 2024 at 09:08:59AM +0800, Baojun Xu wrote: > > Add TXNW2781 support in smi. > > Same comment WRT the commit message. Yeah, in general, all patches in this series have too short patch descriptions. Baojun, please give more words to explain what those patches do, and more importantly tell why they are needed in that way. Silence isn't golden in the case of patches. So, please resubmit the patch set with the proper descriptions in each patch. thanks, Takashi