Received: by 2002:ab2:6857:0:b0:1ef:ffd0:ce49 with SMTP id l23csp3419351lqp; Tue, 26 Mar 2024 08:40:29 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUk2X924QNuGUDJyvosGrFSWL5jjXW28XJh21ntK+bsmzLfxpCy4BEchkAQLZ41SibYJOmGBX2gJPJCjuLzXa8/8qrQaoRoXHAi3Qm19g== X-Google-Smtp-Source: AGHT+IHBZj+8LxS9Xnd4MB1LFFkg4DsYPwoIxJBQ6C/sEF3Aydrxm6c50FOXJtCU4zCnwGnGtGUD X-Received: by 2002:a2e:aa98:0:b0:2d6:c749:17bc with SMTP id bj24-20020a2eaa98000000b002d6c74917bcmr11565ljb.31.1711467628874; Tue, 26 Mar 2024 08:40:28 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711467628; cv=pass; d=google.com; s=arc-20160816; b=sEIf6GfUA1kUOXck8M2tjp6VhPC7ti13j6nhwVwPgJ+MIINchAlLDDxRjvAukXPHcx MCYZipJwRAxHYVCLkJq+MD7UGPSsdw9iffY2Vl4zcKudqTr5l12Qaiq5kzUgXTOHDroi D5vxDmKxjYoznAH+Teo8S60qR7BwYfGrBpRQRw5epEaaZ9thDtaQcwAYcd1oWh3mUZyq ts4K+SR40/ceD66r77nIEoFeFgsfK7EfBr1BWydi6pYHM/+xuirbX34sW5XO/3X1Bk6N GS19GEo6O8sA/9jikDTWvHilhrBnETIi8BybaUH9T8WGtT41K1xq775TDeu69zS6mZit hX2g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :message-id:date:references:in-reply-to:subject:cc:to:from :dkim-signature:dkim-filter; bh=cpbePfHGBKTWOTvvus/3XrPd8U/PqtNlq98UXTNxgtc=; fh=c/9fdANTCRRqrSSoCCWLNpAEi56IbVmwzBP+tsmttHc=; b=K/euHHp+iHCcAvBbK3MOHHsRAGBAlORvPDGbfHB7+JyTp2D3pSv+KTfLPTA/e9drdY TY39rWoJBDea+DrYupzi5hXwNGr8wlRCKjd1FyWsZBmDrsyaRxtOLnhwBjwskqOp8wrH Dj3ivm6w3mKsUeEn3mAMrVRIZKNVgSW1jDjZ34juMtK/1IE7FumOBvDvlFoZQWUi9Jtc t31KFQr3XS/R/481OmtyB3Oqa0ix76R4ZrTsvgVxVPuvLT9FtGaN1N9EiVpu9zsuEhWI lpghCLk1+iAWAXMMZz+PD3IC4KriKdHbnNa8yWBXHOOcGtpH4KWNdU8CsB12NlTfuRW4 O+aQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@lwn.net header.s=20201203 header.b=FFvn4P5i; arc=pass (i=1 spf=pass spfdomain=lwn.net dkim=pass dkdomain=lwn.net dmarc=pass fromdomain=lwn.net); spf=pass (google.com: domain of linux-kernel+bounces-119348-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-119348-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lwn.net Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id uz12-20020a170907118c00b00a4a399a97e2si1731303ejb.726.2024.03.26.08.40.28 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Mar 2024 08:40:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-119348-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@lwn.net header.s=20201203 header.b=FFvn4P5i; arc=pass (i=1 spf=pass spfdomain=lwn.net dkim=pass dkdomain=lwn.net dmarc=pass fromdomain=lwn.net); spf=pass (google.com: domain of linux-kernel+bounces-119348-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-119348-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lwn.net Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 6F7171F67D71 for ; Tue, 26 Mar 2024 15:40:28 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 262A713CFA3; Tue, 26 Mar 2024 15:35:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lwn.net header.i=@lwn.net header.b="FFvn4P5i" Received: from ms.lwn.net (ms.lwn.net [45.79.88.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9357513CC79; Tue, 26 Mar 2024 15:35:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.79.88.28 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711467346; cv=none; b=lj1NjNFTwp/rl3h56yQPzoq/wLOVJaQajz56cEWo7H55sGz1zgmxlG5DncP1KHZgb855TwPdnmfq2kzz+Tak6Txv+bYEb18IIH4x/iCKSArvTbQbNvVhz3gyvcFlH0Q7T8nXm7kPdPr7jxPuJUoLYKhkoDmXydv4C3JAX+m9Prg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711467346; c=relaxed/simple; bh=cpbePfHGBKTWOTvvus/3XrPd8U/PqtNlq98UXTNxgtc=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=gehvnzHc4+1qTVJV6wuqwzyjonQabq7jTaDii8oRNZF7ACvUNaTYbZR2LozeQt8pcD7KAQmxGbiRIggJ9qlG1Ks55FJjbcLiWRBNGViDZmLf+ZTT1qo8JVkdKQYot+TH6WHmpZOvXAyUDOQ/boofeao4Hw7qUUYrl9vjqBHXlDI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lwn.net; spf=pass smtp.mailfrom=lwn.net; dkim=pass (2048-bit key) header.d=lwn.net header.i=@lwn.net header.b=FFvn4P5i; arc=none smtp.client-ip=45.79.88.28 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lwn.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lwn.net DKIM-Filter: OpenDKIM Filter v2.11.0 ms.lwn.net 3B44047AA3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lwn.net; s=20201203; t=1711467336; bh=cpbePfHGBKTWOTvvus/3XrPd8U/PqtNlq98UXTNxgtc=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=FFvn4P5iUGFV/C84IYrDeszQ3l4X72UHM7BHMKC4XcgtG2N2QFnXn6xdz0VAqxRNV Emf24AR4aL0OrPrXsmrgJ6afMPpl3nOT6W+g4eCOIq1Zb49xxCQfd0ZPOR7F+HeUsB cszy1ZEszzufBkmfeD58hXM6Y1PQwAVM8L/JbuH3uljqBmQG1i/t4fu4czw9AASV1+ tP3xaIaLK7HMDBQYt7UYjixP6/QkqTyb1P82r4FZdhCFrnxysGhznSXe++ZIzncHOp HhyJBHmAYmO5JH6rjBTuz2Y8F0E14H4E6waBB9ouTuV6DyZbC4z0RnJ11jbDgu4k23 9uOORglGwpt9w== Received: from localhost (unknown [205.220.129.20]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ms.lwn.net (Postfix) with ESMTPSA id 3B44047AA3; Tue, 26 Mar 2024 15:35:35 +0000 (UTC) From: Jonathan Corbet To: Dan Williams , peterz@infradead.org, torvalds@linux-foundation.org Cc: Bjorn Helgaas , Ira Weiny , Jonathan Cameron , Jesse Brandeburg , Ilpo =?utf-8?Q?J=C3=A4rvinen?= , Lukas Wunner , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, linux-doc@vger.kernel.org Subject: Re: [PATCH v2] cleanup: Add usage and style documentation In-Reply-To: <171140738438.1574931.15717256954707430472.stgit@dwillia2-xfh.jf.intel.com> References: <171097196970.1011049.9726486429680041876.stgit@dwillia2-xfh.jf.intel.com> <171140738438.1574931.15717256954707430472.stgit@dwillia2-xfh.jf.intel.com> Date: Tue, 26 Mar 2024 09:35:28 -0600 Message-ID: <8734sd0zwf.fsf@meer.lwn.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain One little nit... Dan Williams writes: > + * The DEFINE_FREE() macro can arrange for PCI device references to be > + * dropped when the associated variable goes out of scope: > + * > + * :: > + * This can be written a bit more concisely as: ...goes out of scope:: without the separate "::" line, reducing the markup noise a bit more. Thanks, jon