Received: by 2002:ab2:6857:0:b0:1ef:ffd0:ce49 with SMTP id l23csp3423631lqp; Tue, 26 Mar 2024 08:47:43 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVpmmXuwrbyfKI28zEaV5DF0FZpmpX1b1/+SCmcLpT/tL4azAnFbgtbK6weSoWh5ixJE9yNYdfkNKYrgy33OzFErwaMmZU1Cln+cuqiBQ== X-Google-Smtp-Source: AGHT+IEr/L+8qM7Lska31uqSEp6hzEY1QOs86ySqgHfSt0f/+J3cPSzmY7/voA8paVJ/j/E287hH X-Received: by 2002:a17:906:1951:b0:a47:4779:ba7f with SMTP id b17-20020a170906195100b00a474779ba7fmr97552eje.7.1711468063425; Tue, 26 Mar 2024 08:47:43 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711468063; cv=pass; d=google.com; s=arc-20160816; b=aghy+bXkz/v1JFYfnYLxSboYDWdMXCvhrtpU+eFAFG+8qF4O/0nFUG/Tm1rTXowJvn CZFnzYcpkCMVtRD552uJxxwBbBnwPAsp+0eXFGpNfRy4Y+Plp84qfTNZVYo6P9S+wPyd 8R3q9d6fXS1ggokpV6Kf/2IO/ZiGQAMglA0KCIFSz7aFLD5ea/MZFYZYg7qyTlWHbSCi bGjf0bzuz0fXdl1PScJrYldtD1SAd+YMx9BTFFAnsz1Yx5HyvOyFkuiOjmSXL0tKWTkq HR+LJgtTKVEmmohcgsBju7703TLxXSsV8aXJrUUIkWMLkcj8vZvexK82j5QRcHtiv+3Z 95dA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=3IoP/uIjCVx3xjBmhXcu+ibQvDzjCyC7N9xRWM9JDXA=; fh=KdF3cNJuUaxv6urTZqYniYblVaglqmbvXPmwPm3RR60=; b=Jjda8RXUheIlAKv0BmGlu3PQlUjxc3clgv/hrnVS+EzRSxKLAt0ODqG3/MUWy+jfAq F+JzLjy7EEC2TxGv2sKBMB+Ly1HWeRCYwDvVbfQlzBJSkh4SpsF2a/FgL35xheQlCdNi Vk01q9DRtvSjK3kfPJ1IfggCuxXlOBakIRU5uNlRe6df3wTy6ZP8OyIiKpGbPG2xFCdh ZetA9MrKgXQ/nhhHNcn3g2l2yzjwLFJlx7Nqm9fiISg73bIkzqwpn0DuDXPpE8mdMv+K jyK9TAIJrBQpd8wcnIeT/MuJ29Y9kwS893rUvRRPwAYvMIjr2II10i+Z/nMJ0IqTWW2E /KGw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=U322PJeN; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-119349-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-119349-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id u26-20020a1709064ada00b00a4dfc4b4729si152987ejt.610.2024.03.26.08.47.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Mar 2024 08:47:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-119349-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=U322PJeN; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-119349-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-119349-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 08ABD1F67F38 for ; Tue, 26 Mar 2024 15:40:57 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B07A013C916; Tue, 26 Mar 2024 15:36:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="U322PJeN" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 08ECF13C8ED for ; Tue, 26 Mar 2024 15:36:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711467386; cv=none; b=vFbfLYMcSlijnHW/PfYgDP8KHsIctmtge9kjHCsIx4H4P9VNkLWC8h58NrEh8alh5i/4UyKxuhNDbdMFaxm/H0WS23PNhnWOYhoCOw7DdYi6Lp6kWHvBAhenVZZt4QfHY46NyeS//FkHGtnbFHpvmrRch75SjQcAnf+T8mhu2tg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711467386; c=relaxed/simple; bh=WjduyezMyJgXE+CV4glcOFAh/2FSU2yWbLJarIfwxXk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=twtidYVKMTE5nu+F0F6K9mYslC5S1J4ajGLqwEFWYOB6j7DmU20T/HAFogvxy5DX+vYED2kOmz3lnC/4Qj3p12Js/j0ygHf0X5k1Dgm689IOI/aTDz1zkUXIt2oNnBx+rURGbbfWCzBu+1Au78k8vxpaHmQ9MbMOoqRVgcHyLss= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=U322PJeN; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711467382; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=3IoP/uIjCVx3xjBmhXcu+ibQvDzjCyC7N9xRWM9JDXA=; b=U322PJeNOq96axtTUEQOAlEqCjy1vTxLpFqCH+imH4nHImeirlnmlbyxIlrgWFrdqeh7r7 pG1GqwR5OjJX65rtu3pnA9myx0Md7GbThQ6GtWDIImKXMpGsM4tyJClIIgMDSElMW4jSAX x4bsN+HwR8HkWtatsP9r7sEJ3QOZ+MU= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-49-kckh0Hd9Ng-Xtf2PqOXYSQ-1; Tue, 26 Mar 2024 11:36:19 -0400 X-MC-Unique: kckh0Hd9Ng-Xtf2PqOXYSQ-1 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-2d49fa5dfadso47746461fa.0 for ; Tue, 26 Mar 2024 08:36:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711467378; x=1712072178; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3IoP/uIjCVx3xjBmhXcu+ibQvDzjCyC7N9xRWM9JDXA=; b=tFp0k++G5sswVOqZJxO9X4BXyD9Dqt5igHEYgd5bo2ZfYqR1UFRCja5mdzE3NcO/5Q 9OT2WASxbUtbOXxoSeMlUHK4hsw2L3DY9h2Vcs53dk1BNlRBxiRXimUCXCq5wHGa6yTK BbAvSi1EzpgzMkcZJZ8mEDHGevbsm/H/SmoekEzuCQmQgNZ39Ssv/417g7y9RN3bFkPt IWXsLLztHbVIt1W9qDrQCHS8h+RltZTLm8vou4GMaccdRK8FyF5lou/g2uBsli5suEI/ nCXxues00rHCKXTPcH26mSnAUqlFUi/xvrC4WGt7/Hz2Wy0Rkw5MmlND5RNAFSiuWJZq VahA== X-Gm-Message-State: AOJu0Yx8HcBB+0PcgL6W4Cia10B2+xWMcaz+tSrAPsxXvdGT8vU2AwHG ONEDCP4Xk5ORIJWfCvmgDYBthqDRC4aLWF5n+OUFpoqIRic3Kvu433D0F4xWsZiU3/aD4dtjflH Wiqpgxv2eBU4n1MCy7rYfifzFdwiEzLwhkOdGnZGaysBbYTiE9rXW9IJbJgqoyA== X-Received: by 2002:a2e:9e17:0:b0:2d3:3305:c373 with SMTP id e23-20020a2e9e17000000b002d33305c373mr4435ljk.3.1711467377979; Tue, 26 Mar 2024 08:36:17 -0700 (PDT) X-Received: by 2002:a2e:9e17:0:b0:2d3:3305:c373 with SMTP id e23-20020a2e9e17000000b002d33305c373mr4421ljk.3.1711467377601; Tue, 26 Mar 2024 08:36:17 -0700 (PDT) Received: from ?IPV6:2003:cb:c741:c700:3db9:94c9:28b0:34f2? (p200300cbc741c7003db994c928b034f2.dip0.t-ipconnect.de. [2003:cb:c741:c700:3db9:94c9:28b0:34f2]) by smtp.gmail.com with ESMTPSA id t21-20020a05600c451500b004146e58cc35sm11991594wmo.46.2024.03.26.08.36.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Mar 2024 08:36:17 -0700 (PDT) Message-ID: <1365c52b-2883-4b1a-aa9f-f587e38df695@redhat.com> Date: Tue, 26 Mar 2024 16:36:16 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/3] selftests/memfd_secret: add vmsplice() test Content-Language: en-US To: Miklos Szeredi Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Mike Rapoport , Lorenzo Stoakes , xingwei lee , yue sun References: <20240326143210.291116-1-david@redhat.com> <20240326143210.291116-3-david@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit >> +static void test_vmsplice(int fd, const char *desc) >> +{ >> + ssize_t transferred; >> + struct iovec iov; >> + int pipefd[2]; >> + char *mem; >> + >> + if (pipe(pipefd)) { >> + fail("pipe failed: %s\n", strerror(errno)); >> + return; >> + } >> + >> + mem = mmap(NULL, page_size, prot, mode, fd, 0); >> + if (mem == MAP_FAILED) { >> + fail("Unable to mmap secret memory\n"); >> + goto close_pipe; >> + } >> + >> + /* >> + * vmsplice() may use GUP-fast, which must also fail. Prefault the >> + * page table, so GUP-fast could find it. >> + */ >> + memset(mem, PATTERN, page_size); > > Shouldn't the non-prefault case be tested as well? That's the "easy" case where GUP-fast is never involved, and it should mostly be covered by the ptrace/process_vm_read() tests already. -- Cheers, David / dhildenb