Received: by 2002:ab2:6857:0:b0:1ef:ffd0:ce49 with SMTP id l23csp3427593lqp; Tue, 26 Mar 2024 08:54:13 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXD2STlBcAZemKp+S5tRRhBESYdoM7aJofYWxKfGKWY3mcuxgdJlKGb6JkpHIYMk54b6ILl2TUp9KPWidE6SDprCp2d1FRRoTijvaHqZA== X-Google-Smtp-Source: AGHT+IHObtv72Lxe2Zbj8TIL+rxYVCxl1X/Qv36WgSISvHdJCwFgpGMmpY4tC/ylgIw+ahkmCeun X-Received: by 2002:a05:6a00:4b4a:b0:6ea:ba4e:f1f8 with SMTP id kr10-20020a056a004b4a00b006eaba4ef1f8mr2183272pfb.19.1711468452647; Tue, 26 Mar 2024 08:54:12 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711468452; cv=pass; d=google.com; s=arc-20160816; b=G7okgvj/+CAlqkKknNBhGZjuGvc161F9eQs2aBCeloK8Miwyo9W7Zwpr3xhK20UQyG um1ouc6yJ+MiTxlyjefpI0JPwmKgrj5SdwYsZCmz87gSDN+FUfgaNzC1ttu+90BOIphE 9USGKloXA/vqY5w+igLIq/sh84pqkoyC6fa3bSm5E4M9znGPxfWZZLkwEYcEsbufXVfg 0gluT5Gaj4Xrsdsys6/nS2bDUUgjjp4YkQ22+au7EvgTyvCVGowmppLi7cJ5GxA9XDPy A2E4+CfUgURtH8jQCooiiT13qg3UZmnrzdaeJG3P+CbqFgxclXZUO2xMiRCysdMeQvLj CuIg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :subject:date:from:dkim-signature; bh=5P3Shu+dacTpXZVtFjUGEe5YOw/QpGfJn1rpC7aGJ5k=; fh=8wcoxKk21hICD+6obVirG13fsSSMhKa/pufykSf87d0=; b=h/vAc+/OMMtI6ZDyIp4GGr0hggjb8wep8oPdFmGrVWblnBRV0wQaRnnn4OhfaVnhi3 hS6wQh6bz8PAixBYuOvYHWJyptWhFo1F4i5CfjmYZnNDBAlH5ySSuB3bZ203VvvDTxLQ R/SF8vOgfcCxF7p6kcGsU+bduyN4yfbj8Bqy86N2H9kGYWkOwI4nPuVhiBILThuANnfA 4aFXU0D+nHDv5STY6GSczE+Dhrd0g8RGGsjYLr2l644JWN/hRcsVQamXPgqIBWJmoulA LuilCU6WX9VErT7lSzjFL1uTHn0G3VNRHqk8IfJXBXHlWt3D4sTukXVQSr8Zoq2zWbQC resA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=MTESZzTv; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-119368-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-119368-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id gx2-20020a056a001e0200b006e56d29f455si7375070pfb.268.2024.03.26.08.54.12 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Mar 2024 08:54:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-119368-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=MTESZzTv; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-119368-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-119368-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 51B61322D3A for ; Tue, 26 Mar 2024 15:46:51 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7C3F513E3F6; Tue, 26 Mar 2024 15:40:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="MTESZzTv" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E5A113E057; Tue, 26 Mar 2024 15:40:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711467657; cv=none; b=if9YKbNR94PE1PGXfxCuWML+CAwB1kt4QJs2yKb6Wnsssb2czGK3Q5wuMQLdMALSQIrQcgME0Zuh28CfSjkz1Jsf7LE+lcONA6oixB3twrluJuPB0lKthQv88lXc4JvCeJaSWaDSpueMqWqTtPpyLVHiiyB7lywItjn5WXayJwU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711467657; c=relaxed/simple; bh=ZS3wISB0X/kpWLhWogqJqYoscE5+wIH8Om8Y+yVdq+w=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=VC9clhM3qtMF8YzrWM6wRHCEoT+BVVnqumjcUc0ejO49K7N8eAb1H/wksiAUmyTrbyr61SChSipz8fhXXNfAuZ/pLs7ybXf8/b6XdgujJOywtqrYmlmDjGAi/oZMDC0Va40pXi8fk78iu81qpOUk+MeMjaigSYrPgniWGZ7qvXI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=MTESZzTv; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id A7B99C433F1; Tue, 26 Mar 2024 15:40:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711467657; bh=ZS3wISB0X/kpWLhWogqJqYoscE5+wIH8Om8Y+yVdq+w=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=MTESZzTvtZX7Al2McGXBjbqxhwa2AQckfMaF/LBiQu1AokgzSuzfrXwH0O2lcgOzp owZfBl6UNydsnfN/g3z6rAkIuI3ZjqUlfoW9+lIMh/fDtxEpYjotXpzV1KX+E4zxDB P8l4p27bn5xdWuhR/Blxsknu6JbDsgpUdvOuzJv2Agx6TI9JmmV2zPnV+KvPU9b9LH 6JOLl1djw1Xi2K8fTYer4S+3avm32owl8Y5OqN2hkGIn6kxpDgHys4su7G9mNmPiOx tefmFuwXWB8essZR9Mtkt/qAW/9AhLWzMNbDhR+NsuMhoKkSHp1R1iyfsIRil/7dvU fA6nuVsxGEkIg== From: Maxime Ripard Date: Tue, 26 Mar 2024 16:40:13 +0100 Subject: [PATCH v11 09/28] drm/display: hdmi: Add HDMI compute clock helper Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20240326-kms-hdmi-connector-state-v11-9-c5680ffcf261@kernel.org> References: <20240326-kms-hdmi-connector-state-v11-0-c5680ffcf261@kernel.org> In-Reply-To: <20240326-kms-hdmi-connector-state-v11-0-c5680ffcf261@kernel.org> To: Maarten Lankhorst , Thomas Zimmermann , David Airlie , Daniel Vetter , Jonathan Corbet , Sandy Huang , =?utf-8?q?Heiko_St=C3=BCbner?= , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland Cc: Hans Verkuil , Sebastian Wick , =?utf-8?q?Ville_Syrj=C3=A4l=C3=A4?= , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-sunxi@lists.linux.dev, Maxime Ripard , Dave Stevenson X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=3675; i=mripard@kernel.org; h=from:subject:message-id; bh=ZS3wISB0X/kpWLhWogqJqYoscE5+wIH8Om8Y+yVdq+w=; b=owGbwMvMwCmsHn9OcpHtvjLG02pJDGlMb5KixIxX/k3k4XbKORnb/3ftnRNWj66qLi8RvX3u5 aclP56/75jKwiDMySArpsjyRCbs9PL2xVUO9it/wMxhZQIZwsDFKQAT+faWseFbTY7Hiv5TDj3/ q39q1M9oLnupqnmu4+i62gVrKlNUPddXHXq9/z57lQ1X/a0WkeL4g4wN7beNNz+dMUvVbUuR2Gn DzjdXg5u7kr+Ul3erOZad+Vx3iJfrnYqtqFjWwfAHyWJvWWoB X-Developer-Key: i=mripard@kernel.org; a=openpgp; fpr=BE5675C37E818C8B5764241C254BCFC56BF6CE8D A lot of HDMI drivers have some variation of the formula to calculate the TMDS character rate from a mode, but few of them actually take all parameters into account. Let's create a helper to provide that rate taking all parameters into account. Reviewed-by: Dave Stevenson Signed-off-by: Maxime Ripard --- drivers/gpu/drm/display/drm_hdmi_helper.c | 70 +++++++++++++++++++++++++++++++ include/drm/display/drm_hdmi_helper.h | 4 ++ 2 files changed, 74 insertions(+) diff --git a/drivers/gpu/drm/display/drm_hdmi_helper.c b/drivers/gpu/drm/display/drm_hdmi_helper.c index faf5e9efa7d3..2518dd1a07e7 100644 --- a/drivers/gpu/drm/display/drm_hdmi_helper.c +++ b/drivers/gpu/drm/display/drm_hdmi_helper.c @@ -193,5 +193,75 @@ void drm_hdmi_avi_infoframe_content_type(struct hdmi_avi_infoframe *frame, } frame->itc = conn_state->content_type != DRM_MODE_CONTENT_TYPE_NO_DATA; } EXPORT_SYMBOL(drm_hdmi_avi_infoframe_content_type); + +/** + * drm_hdmi_compute_mode_clock() - Computes the TMDS Character Rate + * @mode: Display mode to compute the clock for + * @bpc: Bits per character + * @fmt: Output Pixel Format used + * + * Returns the TMDS Character Rate for a given mode, bpc count and output format. + * + * RETURNS: + * The TMDS Character Rate, in Hertz, or 0 on error. + */ +unsigned long long +drm_hdmi_compute_mode_clock(const struct drm_display_mode *mode, + unsigned int bpc, enum hdmi_colorspace fmt) +{ + unsigned long long clock = mode->clock * 1000ULL; + unsigned int vic = drm_match_cea_mode(mode); + + /* + * CTA-861-G Spec, section 5.4 - Color Coding and Quantization + * mandates that VIC 1 always uses 8 bpc. + */ + if (vic == 1 && bpc != 8) + return 0; + + /* + * HDMI 2.0 Spec, section 7.1 - YCbCr 4:2:0 Pixel Encoding + * specifies that YUV420 encoding is only available for those + * VICs. + */ + if (fmt == HDMI_COLORSPACE_YUV420 && + !(vic == 96 || vic == 97 || vic == 101 || + vic == 102 || vic == 106 || vic == 107)) + return 0; + + if (fmt == HDMI_COLORSPACE_YUV422) { + /* + * HDMI 1.4b Spec, section 6.2.3 - Pixel Encoding Requirements + * specifies that YUV422 is 36-bit only. + */ + if (bpc != 12) + return 0; + + /* + * HDMI 1.0 Spec, section 6.5 - Pixel Encoding + * specifies that YUV422 requires two 12-bits components per + * pixel clock, which is equivalent in our calculation to three + * 8-bits components + */ + bpc = 8; + } + + /* + * HDMI 2.0 Spec, Section 7.1 - YCbCr 4:2:0 Pixel Encoding + * specifies that YUV420 encoding is carried at a TMDS Character Rate + * equal to half the pixel clock rate. + */ + if (fmt == HDMI_COLORSPACE_YUV420) + clock = clock / 2; + + if (mode->flags & DRM_MODE_FLAG_DBLCLK) + clock = clock * 2; + + clock = clock * bpc; + do_div(clock, 8); + + return clock; +} +EXPORT_SYMBOL(drm_hdmi_compute_mode_clock); diff --git a/include/drm/display/drm_hdmi_helper.h b/include/drm/display/drm_hdmi_helper.h index 76d234826e22..57e3b18c15ec 100644 --- a/include/drm/display/drm_hdmi_helper.h +++ b/include/drm/display/drm_hdmi_helper.h @@ -22,6 +22,10 @@ drm_hdmi_infoframe_set_hdr_metadata(struct hdmi_drm_infoframe *frame, const struct drm_connector_state *conn_state); void drm_hdmi_avi_infoframe_content_type(struct hdmi_avi_infoframe *frame, const struct drm_connector_state *conn_state); +unsigned long long +drm_hdmi_compute_mode_clock(const struct drm_display_mode *mode, + unsigned int bpc, enum hdmi_colorspace fmt); + #endif -- 2.44.0