Received-SPF: pass (google.com: domain of linux-kernel+bounces-119358-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <59998760-491d-408b-a452-852d3250b5db@suse.cz>
Date: Tue, 26 Mar 2024 16:40:24 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 08/10] mm: page_alloc: set migratetype inside
 move_freepages()
Content-Language: en-US
To: Johannes Weiner <hannes@cmpxchg.org>,
 Andrew Morton <akpm@linux-foundation.org>
Cc: Mel Gorman <mgorman@techsingularity.net>, Zi Yan <ziy@nvidia.com>,
 "Huang, Ying" <ying.huang@intel.com>, David Hildenbrand <david@redhat.com>,
 linux-mm@kvack.org, linux-kernel@vger.kernel.org
References: <20240320180429.678181-1-hannes@cmpxchg.org>
 <20240320180429.678181-9-hannes@cmpxchg.org>
From: Vlastimil Babka <vbabka@suse.cz>
In-Reply-To: <20240320180429.678181-9-hannes@cmpxchg.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 3/20/24 7:02 PM, Johannes Weiner wrote:
> From: Zi Yan <ziy@nvidia.com>
> 
> This avoids changing migratetype after move_freepages() or
> move_freepages_block(), which is error prone. It also prepares for
> upcoming changes to fix move_freepages() not moving free pages
> partially in the range.
> 
> Signed-off-by: Zi Yan <ziy@nvidia.com>
> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>

Reviewed-by: Vlastimil Babka <vbabka@suse.cz>

BTW noticed in -mm this has R-b: Zi Yan which is odd as he's the author. In
the subthread for patch 9/10 Zi posted a R-b for patch 9/10 and its fixup,
not this one :)