Received-SPF: pass (google.com: domain of linux-kernel+bounces-119353-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: "Loktionov, Aleksandr" <aleksandr.loktionov@intel.com>
To: ivecera <ivecera@redhat.com>, "intel-wired-lan@lists.osuosl.org"
	<intel-wired-lan@lists.osuosl.org>
CC: "open list:NETWORKING DRIVERS" <netdev@vger.kernel.org>, open list
	<linux-kernel@vger.kernel.org>, Eric Dumazet <edumazet@google.com>, "Nguyen,
 Anthony L" <anthony.l.nguyen@intel.com>, Jakub Kicinski <kuba@kernel.org>,
	Paolo Abeni <pabeni@redhat.com>, "David S. Miller" <davem@davemloft.net>
Subject: RE: [Intel-wired-lan] [PATCH iwl-next 1/7] i40e: Remove flags field
 from i40e_veb
Thread-Topic: [Intel-wired-lan] [PATCH iwl-next 1/7] i40e: Remove flags field
 from i40e_veb
Thread-Index: AQHaeUD928WY4jyDa0CC6tJsTuW2g7FKNJXg
Date: Tue, 26 Mar 2024 15:38:14 +0000
Message-ID: <SJ0PR11MB58666E6D308913A475BC94F7E5352@SJ0PR11MB5866.namprd11.prod.outlook.com>
References: <20240318143058.287014-1-ivecera@redhat.com>
 <20240318143058.287014-2-ivecera@redhat.com>
In-Reply-To: <20240318143058.287014-2-ivecera@redhat.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?R4aOtDobZvq2JnYtpZSHQT/EpdLDxI3qWb+kpuhAj6yq9NbgPhDSUi/4thbS?=
 =?us-ascii?Q?3uJdunb5xw+OOJ+EbaJ3hCdZJvq8IF5LrB4qkr3dTiYo7x9XocADtyqzsiha?=
 =?us-ascii?Q?aObPrwQtgr2p+g+OfirJEDKRySwmZr1uud76Od290vSsfUMXSl8WP5O5A36h?=
 =?us-ascii?Q?OQPgvkAaD0yIFXP9XMp0KjFogVo1SsECqupkwrRMfoVlJQzoOfEa6+/6fFeg?=
 =?us-ascii?Q?m9oqgGHL/BuFTiZ1VEqwNLek0TVufaMNo9rqA7r3nykDLaQH16KggkXhvNOP?=
 =?us-ascii?Q?wO16YaQkfE95+XCcfjyi48EqCXMOf6KZyCQzPiBBm3bcnNx+63/DBfzticq9?=
 =?us-ascii?Q?rhmXJQyxyM10EEkUkUSXV74hjHXz722rd5ATo//aHU0SGfEHylCIks/Z9t6Y?=
 =?us-ascii?Q?lHIFG/2k6vRHGpmrouiVqFaeL7wYPTltSnyxS8Btp9CI8f70ir2fcvYImyRa?=
 =?us-ascii?Q?RMJfcJFogvOYa1RNVFk+cVUzTUh9t+hWu8etBkM5uYq3BXLTtUey1KPBq7ht?=
 =?us-ascii?Q?ICnsiBcso4PnyBJ3x2AMfaKPmPe0DumYEEScERADnLVYyEaDXlM5u5E3B4cb?=
 =?us-ascii?Q?QNg1p7nzZvbo8anoz2wlgBXqPeDMNCkucjEtm1ZY01F5uW62YfgUEiFp2gSk?=
 =?us-ascii?Q?TkJnGqbRfAa4seorPPWQe4xEJ++2aIfSCOd8mv9WcFyQtKDALf7CkjYSleXI?=
 =?us-ascii?Q?pqGsKzkJUI4B9vsppyhgx3jkMGa7TFRn7FvVx2O0msvNyQnuTiEroYaZ1gLb?=
 =?us-ascii?Q?7lfvnSFJivtR39LFllAq4C1N2KkOkMs74zAqromOiSqRDl5VuQv0srHxu6AE?=
 =?us-ascii?Q?zHCnYOL/+jnY3Rgp7WJBfUtElOMZk2XLrCbOr+2kcyIsSekwhoBdqXADJhX/?=
 =?us-ascii?Q?Aaa6mFnVPYgnBOHOvc8upaFUurfks/Vrh4mqhTo46YrlfV91vO42LbZYEhMy?=
 =?us-ascii?Q?dwb858k500IfeMQiAD+aNDwVzLLUJPNpPLBJ5cLFlr25c12wR3eQN5mtd/8L?=
 =?us-ascii?Q?WZYUJze9A3v+QsrhjMz81DdgZBMlnzxByNe6wuhN5M0lfVkV5e88LNj5fumZ?=
 =?us-ascii?Q?kjhjI9F64N378yOsDL8hZi7exiFuYfaFVJP95GXC4XfnP9+SwfD7ShpojyVS?=
 =?us-ascii?Q?EX1sKuI3uu3D6x/P9EXZgE12LvpOXcY7/yF4cKzPCp004C8l5w4CT0unQvPU?=
 =?us-ascii?Q?/oDtaQZrBqE7KrT1V65HmXiMbNqNTEvZfF3FObi+X1I5Mzzso/KRGcD0cdQr?=
 =?us-ascii?Q?kyu66ddsgsBVyqWbEeL5EwUxK1kYLKe+KbD4Ga9RKq3ek6T/90CX0Yqj/fdy?=
 =?us-ascii?Q?lqokMwU4BL8nilQNPv9M0JE9ZCDSSBxkQEslH4AWIBlcSYZ10SusckeLx+HX?=
 =?us-ascii?Q?Gaon+5UQCHUrjK5sPJdhEDOqE/a/jqGj3HN4h5pMyTzAiZ9f+sWKvmJl6fpa?=
 =?us-ascii?Q?4tZRd2C7oCPzNyYlVO1LyYdWc4a9Slv4MY2aXscuQFxjUTetRf9Y/awn92QB?=
 =?us-ascii?Q?rjHc35A6qow5CUFrvpcsavKUYxp1x+LZNDaO265InJ8AsMEcyCr4a2hs5MxI?=
 =?us-ascii?Q?N3YzOmRD+104dtP7xmdXaNa8x2qmEHkXEz+3Zyu/MHRuykcUAWoj31qJiWJ4?=
 =?us-ascii?Q?pQ=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB5866.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3b4d8ac4-be96-49e1-432e-08dc4daac082
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Mar 2024 15:38:14.8945
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: LPvv0Z38bffE2zWxjBneN37WT9H1QrYzr7E9dIwWywYYgLcO4gX31dJQGrrg9IjdDQfoZHNxhRB1ObHyJDYtMf9bUjJVda5rzarNwbzxscA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR11MB7982
X-OriginatorOrg: intel.com


> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On
> Behalf Of Ivan Vecera
> Sent: Monday, March 18, 2024 3:31 PM
> To: intel-wired-lan@lists.osuosl.org
> Cc: open list:NETWORKING DRIVERS <netdev@vger.kernel.org>; open
> list <linux-kernel@vger.kernel.org>; Eric Dumazet
> <edumazet@google.com>; Nguyen, Anthony L
> <anthony.l.nguyen@intel.com>; Jakub Kicinski <kuba@kernel.org>;
> Paolo Abeni <pabeni@redhat.com>; David S. Miller
> <davem@davemloft.net>
> Subject: [Intel-wired-lan] [PATCH iwl-next 1/7] i40e: Remove flags
> field from i40e_veb
>=20
> The field is initialized always to zero and it is never read.
> Remove it.
>=20
> Signed-off-by: Ivan Vecera <ivecera@redhat.com>
> ---
Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>

>  drivers/net/ethernet/intel/i40e/i40e.h         |  3 +--
>  drivers/net/ethernet/intel/i40e/i40e_debugfs.c |  2 +-
>  drivers/net/ethernet/intel/i40e/i40e_main.c    | 13 +++++--------
>  3 files changed, 7 insertions(+), 11 deletions(-)
>=20
> diff --git a/drivers/net/ethernet/intel/i40e/i40e.h
> b/drivers/net/ethernet/intel/i40e/i40e.h
> index 2fbabcdb5bb5..5248e78f7849 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e.h
> +++ b/drivers/net/ethernet/intel/i40e/i40e.h
> @@ -788,7 +788,6 @@ struct i40e_veb {
>  	u16 stats_idx;		/* index of VEB parent */
>  	u8  enabled_tc;
>  	u16 bridge_mode;	/* Bridge Mode (VEB/VEPA) */
> -	u16 flags;
>  	u16 bw_limit;
>  	u8  bw_max_quanta;
>  	bool is_abs_credits;
> @@ -1213,7 +1212,7 @@ void i40e_vsi_stop_rings(struct i40e_vsi
> *vsi);  void i40e_vsi_stop_rings_no_wait(struct  i40e_vsi *vsi);
> int i40e_vsi_wait_queues_disabled(struct i40e_vsi *vsi);  int
> i40e_reconfig_rss_queues(struct i40e_pf *pf, int queue_count); -
> struct i40e_veb *i40e_veb_setup(struct i40e_pf *pf, u16 flags, u16
> uplink_seid,
> +struct i40e_veb *i40e_veb_setup(struct i40e_pf *pf, u16
> uplink_seid,
>  				u16 downlink_seid, u8 enabled_tc);
>  void i40e_veb_release(struct i40e_veb *veb);
>=20
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_debugfs.c
> b/drivers/net/ethernet/intel/i40e/i40e_debugfs.c
> index f9ba45f596c9..6147c5f128e8 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_debugfs.c
> +++ b/drivers/net/ethernet/intel/i40e/i40e_debugfs.c
> @@ -867,7 +867,7 @@ static ssize_t i40e_dbg_command_write(struct
> file *filp,
>  			goto command_write_done;
>  		}
>=20
> -		veb =3D i40e_veb_setup(pf, 0, uplink_seid, vsi_seid,
> enabled_tc);
> +		veb =3D i40e_veb_setup(pf, uplink_seid, vsi_seid,
> enabled_tc);
>  		if (veb)
>  			dev_info(&pf->pdev->dev, "added relay %d\n", veb-
> >seid);
>  		else
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c
> b/drivers/net/ethernet/intel/i40e/i40e_main.c
> index 663b2237eb4e..2f1604ae78c7 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_main.c
> +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
> @@ -13138,7 +13138,7 @@ static int i40e_ndo_bridge_setlink(struct
> net_device *dev,
>=20
>  		/* Insert a new HW bridge */
>  		if (!veb) {
> -			veb =3D i40e_veb_setup(pf, 0, vsi->uplink_seid,
> vsi->seid,
> +			veb =3D i40e_veb_setup(pf, vsi->uplink_seid, vsi-
> >seid,
>  					     vsi->tc_config.enabled_tc);
>  			if (veb) {
>  				veb->bridge_mode =3D mode;
> @@ -14394,10 +14394,10 @@ struct i40e_vsi *i40e_vsi_setup(struct
> i40e_pf *pf, u8 type,
>  		}
>=20
>  		if (vsi->uplink_seid =3D=3D pf->mac_seid)
> -			veb =3D i40e_veb_setup(pf, 0, pf->mac_seid, vsi-
> >seid,
> +			veb =3D i40e_veb_setup(pf, pf->mac_seid, vsi->seid,
>  					     vsi->tc_config.enabled_tc);
>  		else if ((vsi->flags & I40E_VSI_FLAG_VEB_OWNER) =3D=3D 0)
> -			veb =3D i40e_veb_setup(pf, 0, vsi->uplink_seid,
> vsi->seid,
> +			veb =3D i40e_veb_setup(pf, vsi->uplink_seid, vsi-
> >seid,
>  					     vsi->tc_config.enabled_tc);
>  		if (veb) {
>  			if (vsi->seid !=3D pf->vsi[pf->lan_vsi]->seid) { @@
> -14791,7 +14791,6 @@ static int i40e_add_veb(struct i40e_veb *veb,
> struct i40e_vsi *vsi)
>  /**
>   * i40e_veb_setup - Set up a VEB
>   * @pf: board private structure
> - * @flags: VEB setup flags
>   * @uplink_seid: the switch element to link to
>   * @vsi_seid: the initial VSI seid
>   * @enabled_tc: Enabled TC bit-map
> @@ -14804,9 +14803,8 @@ static int i40e_add_veb(struct i40e_veb
> *veb, struct i40e_vsi *vsi)
>   * Returns pointer to the successfully allocated VEB sw struct on
>   * success, otherwise returns NULL on failure.
>   **/
> -struct i40e_veb *i40e_veb_setup(struct i40e_pf *pf, u16 flags,
> -				u16 uplink_seid, u16 vsi_seid,
> -				u8 enabled_tc)
> +struct i40e_veb *i40e_veb_setup(struct i40e_pf *pf, u16
> uplink_seid,
> +				u16 vsi_seid, u8 enabled_tc)
>  {
>  	struct i40e_vsi *vsi =3D NULL;
>  	struct i40e_veb *veb;
> @@ -14837,7 +14835,6 @@ struct i40e_veb *i40e_veb_setup(struct
> i40e_pf *pf, u16 flags,
>  	if (veb_idx < 0)
>  		goto err_alloc;
>  	veb =3D pf->veb[veb_idx];
> -	veb->flags =3D flags;
>  	veb->uplink_seid =3D uplink_seid;
>  	veb->enabled_tc =3D (enabled_tc ? enabled_tc : 0x1);
>=20
> --
> 2.43.0