Received-SPF: pass (google.com: domain of linux-kernel+bounces-119427-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Tue, 26 Mar 2024 12:13:03 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: Maxim Moskalets <maximmosk4@gmail.com>
Cc: bristot@redhat.com, bsegall@google.com, dietmar.eggemann@arm.com,
 juri.lelli@redhat.com, linux-kernel@vger.kernel.org, mgorman@suse.de,
 mingo@redhat.com, peterz@infradead.org, vincent.guittot@linaro.org,
 vschneid@redhat.com, Maxim.Moskalets@kaspersky.com
Subject: Re: [PATCH RESEND] kernel: replace seq_puts by seq_putc
Message-ID: <20240326121303.7633eca8@gandalf.local.home>
In-Reply-To: <20240325192829.6710-1-Maxim.Moskalets@kaspersky.com>
References: <20240325192829.6710-1-Maxim.Moskalets@kaspersky.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Mon, 25 Mar 2024 22:28:29 +0300
Maxim Moskalets <maximmosk4@gmail.com> wrote:

> Using seq_putc for single characters is faster and more appropriate
> than seq_puts, since only one character is passed and there is no need
> to use a more powerful and less fast function.
> 
> Signed-off-by: Maxim Moskalets <Maxim.Moskalets@kaspersky.com>
> ---
>  kernel/bpf/arraymap.c            |  6 +++---
>  kernel/bpf/bpf_struct_ops.c      |  2 +-
>  kernel/bpf/hashtab.c             |  4 ++--
>  kernel/bpf/local_storage.c       |  4 ++--
>  kernel/cgroup/cgroup.c           |  2 +-
>  kernel/cgroup/debug.c            |  6 +++---
>  kernel/latencytop.c              |  2 +-
>  kernel/locking/lockdep_proc.c    | 24 ++++++++++++------------
>  kernel/module/procfs.c           |  4 ++--
>  kernel/module/tracking.c         |  2 +-
>  kernel/sched/cpuacct.c           |  4 ++--
>  kernel/sched/debug.c             | 14 +++++++-------
>  kernel/time/test_udelay.c        |  2 +-
>  kernel/trace/trace_events_hist.c | 26 +++++++++++++-------------
>  kernel/trace/trace_events_user.c |  8 ++++----
>  kernel/trace/trace_hwlat.c       |  4 ++--
>  16 files changed, 57 insertions(+), 57 deletions(-)
> 

It's probably better to break this up per sub-system and send them out as
separate patches. At least that way the maintainers of the subsystems can
take the patch. Otherwise, nobody is going to take ownership of this.

-- Steve


> diff --git a/kernel/bpf/arraymap.c b/kernel/bpf/arraymap.c