Received: by 2002:ab2:6857:0:b0:1ef:ffd0:ce49 with SMTP id l23csp3443632lqp; Tue, 26 Mar 2024 09:14:32 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUmwXcc3a7+l8YlXpDoVeDzcdO4PtP0Vlw6tCJwRov/T2mP5jb7F7IYC3KglGm5KowbOpk66cLHggZ40cr5md9T4g+ybESSCPenKg77Mw== X-Google-Smtp-Source: AGHT+IEpTVn9h8BxO31pKkBUMsFe5l1ZwnlpclU8rkrgY8JD8C55FHmyrSicwIfH+NioH2xie6Cy X-Received: by 2002:a50:8a9a:0:b0:56c:d21:d913 with SMTP id j26-20020a508a9a000000b0056c0d21d913mr210552edj.0.1711469672468; Tue, 26 Mar 2024 09:14:32 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711469672; cv=pass; d=google.com; s=arc-20160816; b=w2n1S0kwU1mK5+Y7bWzj4SIjKbFWkwcCpqKjdDRcKThgfkl1zmnmBYoLnP3a+fa2cA WuLNLzAzegFldXxyI+jxXLwG4f5BxBpGEjibyE0Vc+/OIx9XtE+LmgDD7qOnHj3BxY4B ryEkZDrGS76zeFtI5JoLTt2lK8uuYEDNXDGcOYMOXXaQiZ3Sn2mI7pFHjpYM+6QKG/Qc oNKb3IPySEymqHOSRIOwxkEC0Ysc5gNAlGRWDqdcjaqlVF1S0B05dWk17K45P8Jou79V tyzdrccnofEnZ0dzh9qRRwbjAnww8zdrA41sFY71/HmJJ4amqidxDA4dJuCl9hjuripL Ls7A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:content-transfer-encoding:autocrypt:references :in-reply-to:date:cc:to:from:subject:message-id:dkim-signature; bh=7SawbmnWI7rPJsnre2a+4vB+2de3J0Bbtlxm2lwABJA=; fh=0h8uxYDFF7Ngb6ViKelqXDWfyh0CFvvzT8mxL28N6kc=; b=GqYzrokOPEYM4GFyOEybIUP3gFXILQb4Ovnt8eMtbxKIn8Kq3bVdDTB0WGjHU/vPjY t/auk9a+SHMuMiiTao5nojkv4uGwk89GNmluR4k1dFlfA1Al79WJuQefh5btg6JBsnuU 4n1JtAI2LW3xadFBH8aUhfMKvXxcS1ass4B0ErHFHL00GERWeN0tZhWelI9LgM1bu+jX s3RZ5pf0CkVWNPriFFkihrJfyyt8zviXqb4u9W8rg3Uazes5/SH/+BbKEWcGJcnvi2cr 8Jd4cO2DmyqPgrBkDMVupHq3wMb6DMDFIURZBci29cWRCVSIuJvymF8o1fYBWdEiRh/U iJog==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=PI0CJPiX; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-119433-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-119433-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id y22-20020a056402441600b0056c0a2371a5si2527960eda.229.2024.03.26.09.14.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Mar 2024 09:14:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-119433-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=PI0CJPiX; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-119433-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-119433-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 025271F8184C for ; Tue, 26 Mar 2024 16:14:32 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 80B0713C9D2; Tue, 26 Mar 2024 16:14:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="PI0CJPiX" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B58031A8F for ; Tue, 26 Mar 2024 16:14:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711469660; cv=none; b=uKgx/heSKJaUtaa/Ssdi6rB4i2xGwus3sPDSKRWeE4oYY7MYz+qYAbp/XwULOEYnSY85UOgxvm2qqCwc253bVQFxwKpYvh7FzZUeBxCv4wvawzwh5B+9bJs0Uc219fnGK7o/WpxdugUh/qJina+lWilRsZX607M18znnk8Ml9K8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711469660; c=relaxed/simple; bh=7SawbmnWI7rPJsnre2a+4vB+2de3J0Bbtlxm2lwABJA=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=htjwls7OraNxL1kaEg9cCUIxlREICZEQsEpvLZqYISfv4/VWd4ReK3W4Jyd6B7xGE7HmP6Rvbi1cdeP9G3Yxw/6d92k3fi5R1cBlRv3oKZYhS7sIZel0neqn1AtuHyJ8oq8rdsvsQ+Cdj+qDJoovRmgwBkSSXxOvxd55WzUt9eg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=PI0CJPiX; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711469658; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=7SawbmnWI7rPJsnre2a+4vB+2de3J0Bbtlxm2lwABJA=; b=PI0CJPiXJqcVEbmsJJYemSLNpfCKTqbDZ/4QmB9/Ah6OUAjeMF1M8c9ocxOqwCoMvLX5KW WGL2y+54pArPCsYyfYgLPG3HLNZpB4CbgynI1uAyfAXWOFydGiV9YZ6+IAONYsyaStDSJH 8jBrUsdOiDRoeq6+MHsBZnwpOyvafiI= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-134-9GI1ugOmOY2xSr5GZpJG2g-1; Tue, 26 Mar 2024 12:14:16 -0400 X-MC-Unique: 9GI1ugOmOY2xSr5GZpJG2g-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-341d0499bbdso415367f8f.1 for ; Tue, 26 Mar 2024 09:14:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711469654; x=1712074454; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7SawbmnWI7rPJsnre2a+4vB+2de3J0Bbtlxm2lwABJA=; b=Wku9XdA+UVqr1b21amGeYB2ttqdeA78OqBKL88I4B0hcwj+KbGI1gUI1l5IjHkAaZW 4p7i0AVbEY+DPd6gxvPlz92+0KH9IQYTPrpIHmDfstJ14pKlud6oq3s1szMOlV1wStpk XjULa5MBsjpSabhsH/HFdDQFzVPo7BmKUzZPtDChWuQdFklJVyacod5dtKuXsu74ooMj Lu4uotWrWwrVqG8LfVYAa8jNqRnMDqGbBO3AFsbuevnttPWTavxAoKIwhQofRJnuka0b naCvLe2HAmdYtIklxRT9nERuA/Hu0FPfXLNDQzTpEyksmxxZhzlBBA+sYVS4+NNzD6jQ kuQA== X-Forwarded-Encrypted: i=1; AJvYcCU1DiB/AEEgja6F/jYl2D5io+iDJBJ6UvOt/4Bczg9eO2AGy+SNzkJbzb0n7v0BqKYU9ClpkXViu83eeuDS0gfJHsJBHTebt6pir2lz X-Gm-Message-State: AOJu0YzmzcdK00iJcpy7Uc6CdphpmfODssDYZCrv1V/mP3lF/LwrDmWT TXrAvdVPCmrpzCRpaSi0SHGNM1tuJYsfp5fWfjBOX7sZSttLYk5HuFRAfkxAxqO0MkxD5HB4R1D 13U2vJapnUHXGpgyms4qZhsWjhwnvzB9ByZ4ADTkt092mFOvJaSrX8s1l8yP0EQ== X-Received: by 2002:a05:6000:1d8f:b0:341:cf6a:9edb with SMTP id bk15-20020a0560001d8f00b00341cf6a9edbmr5122116wrb.1.1711469654756; Tue, 26 Mar 2024 09:14:14 -0700 (PDT) X-Received: by 2002:a05:6000:1d8f:b0:341:cf6a:9edb with SMTP id bk15-20020a0560001d8f00b00341cf6a9edbmr5122103wrb.1.1711469654383; Tue, 26 Mar 2024 09:14:14 -0700 (PDT) Received: from gerbillo.redhat.com (146-241-229-159.dyn.eolo.it. [146.241.229.159]) by smtp.gmail.com with ESMTPSA id bf12-20020a0560001ccc00b0033e745b8bcfsm12550390wrb.88.2024.03.26.09.14.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Mar 2024 09:14:13 -0700 (PDT) Message-ID: Subject: Re: [PATCH net-next v4 4/4] net: gro: move L3 flush checks to tcp_gro_receive From: Paolo Abeni To: Richard Gobert , Eric Dumazet Cc: davem@davemloft.net, kuba@kernel.org, willemdebruijn.kernel@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Date: Tue, 26 Mar 2024 17:14:12 +0100 In-Reply-To: <6566fd5f-fcdf-4dc7-b8a2-5e8a182f8c49@gmail.com> References: <20240325182543.87683-1-richardbgobert@gmail.com> <20240325182543.87683-5-richardbgobert@gmail.com> <46e0c775-91e7-4bf6-88f3-53ab5e00414f@gmail.com> <6566fd5f-fcdf-4dc7-b8a2-5e8a182f8c49@gmail.com> Autocrypt: addr=pabeni@redhat.com; prefer-encrypt=mutual; keydata=mQINBGISiDUBEAC5uMdJicjm3ZlWQJG4u2EU1EhWUSx8IZLUTmEE8zmjPJFSYDcjtfGcbzLPb63BvX7FADmTOkO7gwtDgm501XnQaZgBUnCOUT8qv5MkKsFH20h1XJyqjPeGM55YFAXc+a4WD0YyO5M0+KhDeRLoildeRna1ey944VlZ6Inf67zMYw9vfE5XozBtytFIrRyGEWkQwkjaYhr1cGM8ia24QQVQid3P7SPkR78kJmrT32sGk+TdR4YnZzBvVaojX4AroZrrAQVdOLQWR+w4w1mONfJvahNdjq73tKv51nIpu4SAC1Zmnm3x4u9r22mbMDr0uWqDqwhsvkanYmn4umDKc1ZkBnDIbbumd40x9CKgG6ogVlLYeJa9WyfVMOHDF6f0wRjFjxVoPO6p/ZDkuEa67KCpJnXNYipLJ3MYhdKWBZw0xc3LKiKc+nMfQlo76T/qHMDfRMaMhk+L8gWc3ZlRQFG0/Pd1pdQEiRuvfM5DUXDo/YOZLV0NfRFU9SmtIPhbdm9cV8Hf8mUwubihiJB/9zPvVq8xfiVbdT0sPzBtxW0fXwrbFxYAOFvT0UC2MjlIsukjmXOUJtdZqBE3v3Jf7VnjNVj9P58+MOx9iYo8jl3fNd7biyQWdPDfYk9ncK8km4skfZQIoUVqrWqGDJjHO1W9CQLAxkfOeHrmG29PK9tHIwARAQABtB9QYW9sbyBBYmVuaSA8cGFiZW5pQHJlZGhhdC5jb20+iQJSBBMBCAA8FiEEg1AjqC77wbdLX2LbKSR5jcyPE6QFAmISiDUCGwMFCwkIBwIDIgIBBhUKCQgLAgQWAgMBAh4HAheAAAoJECkkeY3MjxOkJSYQAJcc6MTsuFxYdYZkeWjW//zbD3ApRHzpNlHLVSuJqHr9/aDS+tyszgS8jj9MiqALzgq4iZbg 7ZxN9ZsDL38qVIuFkSpgMZCiUHdxBC11J8nbBSLlpnc924UAyr5XrGA99 6Wl5I4Km3128GY6iAkH54pZpOmpoUyBjcxbJWHstzmvyiXrjA2sMzYjt3Xkqp0cJfIEekOi75wnNPofEEJg28XPcFrpkMUFFvB4Aqrdc2yyR8Y36rbw18sIX3dJdomIP3dL7LoJi9mfUKOnr86Z0xltgcLPGYoCiUZMlXyWgB2IPmmcMP2jLJrusICjZxLYJJLofEjznAJSUEwB/3rlvFrSYvkKkVmfnfro5XEr5nStVTECxfy7RTtltwih85LlZEHP8eJWMUDj3P4Q9CWNgz2pWr1t68QuPHWaA+PrXyasDlcRpRXHZCOcvsKhAaCOG8TzCrutOZ5NxdfXTe3f1jVIEab7lNgr+7HiNVS+UPRzmvBc73DAyToKQBn9kC4jh9HoWyYTepjdcxnio0crmara+/HEyRZDQeOzSexf85I4dwxcdPKXv0fmLtxrN57Ae82bHuRlfeTuDG3x3vl/Bjx4O7Lb+oN2BLTmgpYq7V1WJPUwikZg8M+nvDNcsOoWGbU417PbHHn3N7yS0lLGoCCWyrK1OY0QM4EVsL3TjOfUtCNQYW9sbyBBYmVuaSA8cGFvbG8uYWJlbmlAZ21haWwuY29tPokCUgQTAQgAPBYhBINQI6gu+8G3S19i2ykkeY3MjxOkBQJiEoitAhsDBQsJCAcCAyICAQYVCgkICwIEFgIDAQIeBwIXgAAKCRApJHmNzI8TpBzHD/45pUctaCnhee1vkQnmStAYvHmwrWwIEH1lzDMDCpJQHTUQOOJWDAZOFnE/67bxSS81Wie0OKW2jvg1ylmpBA0gPpnzIExQmfP72cQ1TBoeVColVT6Io35BINn+ymM7c0Bn8RvngSEpr3jBtqvvWXjvtnJ5/HbOVQCg62NC6ewosoKJPWpGXMJ9SKsVIOUHsmoWK60spzeiJoSmAwm3zTJQnM5kRh2q iWjoCy8L35zPqR5TV+f5WR5hTVCqmLHSgm1jxwKhPg9L+GfuE4d0SWd84y GeOB3sSxlhWsuTj1K6K3MO9srD9hr0puqjO9sAizd0BJP8ucf/AACfrgmzIqZXCfVS7jJ/M+0ic+j1Si3yY8wYPEi3dvbVC0zsoGj9n1R7B7L9c3g1pZ4L9ui428vnPiMnDN3jh9OsdaXeWLvSvTylYvw9q0DEXVQTv4/OkcoMrfEkfbXbtZ3PRlAiddSZA5BDEkkm6P9KA2YAuooi1OD9d4MW8LFAeEicvHG+TPO6jtKTacdXDRe611EfRwTjBs19HmabSUfFcumL6BlVyceIoSqXFe5jOfGpbBevTZtg4kTSHqymGb6ra6sKs+/9aJiONs5NXY7iacZ55qG3Ib1cpQTps9bQILnqpwL2VTaH9TPGWwMY3Nc2VEc08zsLrXnA/yZKqZ1YzSY9MGXWYLkCDQRiEog1ARAAyXMKL+x1lDvLZVQjSUIVlaWswc0nV5y2EzBdbdZZCP3ysGC+s+n7xtq0o1wOvSvaG9h5q7sYZs+AKbuUbeZPu0bPWKoO02i00yVoSgWnEqDbyNeiSW+vI+VdiXITV83lG6pS+pAoTZlRROkpb5xo0gQ5ZeYok8MrkEmJbsPjdoKUJDBFTwrRnaDOfb+Qx1D22PlAZpdKiNtwbNZWiwEQFm6mHkIVSTUe2zSemoqYX4QQRvbmuMyPIbwbdNWlItukjHsffuPivLF/XsI1gDV67S1cVnQbBgrpFDxN62USwewXkNl+ndwa+15wgJFyq4Sd+RSMTPDzDQPFovyDfA/jxN2SK1Lizam6o+LBmvhIxwZOfdYH8bdYCoSpqcKLJVG3qVcTwbhGJr3kpRcBRz39Ml6iZhJyI3pEoX3bJTlR5Pr1Kjpx13qGydSMos94CIYWAKhegI06aTdvvuiigBwjngo/Rk5S+iEGR5KmTqGyp27o6YxZy6D4NIc6PKUzhIUxfvuHNvfu sD2W1U7eyLdm/jCgticGDsRtweytsgCSYfbz0gdgUuL3EBYN3JLbAU+UZpy v/fyD4cHDWaizNy/KmOI6FFjvVh4LRCpGTGDVPHsQXaqvzUybaMb7HSfmBBzZqqfVbq9n5FqPjAgD2lJ0rkzb9XnVXHgr6bmMRlaTlBMAEQEAAYkCNgQYAQgAIBYhBINQI6gu+8G3S19i2ykkeY3MjxOkBQJiEog1AhsMAAoJECkkeY3MjxOkY1YQAKdGjHyIdOWSjM8DPLdGJaPgJdugHZowaoyCxffilMGXqc8axBtmYjUIoXurpl+f+a7S0tQhXjGUt09zKlNXxGcebL5TEPFqgJTHN/77ayLslMTtZVYHE2FiIxkvW48yDjZUlefmphGpfpoXe4nRBNto1mMB9Pb9vR47EjNBZCtWWbwJTIEUwHP2Z5fV9nMx9Zw2BhwrfnODnzI8xRWVqk7/5R+FJvl7s3nY4F+svKGD9QHYmxfd8Gx42PZc/qkeCjUORaOf1fsYyChTtJI4iNm6iWbD9HK5LTMzwl0n0lL7CEsBsCJ97i2swm1DQiY1ZJ95G2Nz5PjNRSiymIw9/neTvUT8VJJhzRl3Nb/EmO/qeahfiG7zTpqSn2dEl+AwbcwQrbAhTPzuHIcoLZYV0xDWzAibUnn7pSrQKja+b8kHD9WF+m7dPlRVY7soqEYXylyCOXr5516upH8vVBmqweCIxXSWqPAhQq8d3hB/Ww2A0H0PBTN1REVw8pRLNApEA7C2nX6RW0XmA53PIQvAP0EAakWsqHoKZ5WdpeOcH9iVlUQhRgemQSkhfNaP9LqR1XKujlTuUTpoyT3xwAzkmSxN1nABoutHEO/N87fpIbpbZaIdinF7b9srwUvDOKsywfs5HMiUZhLKoZzCcU/AEFjQsPTATACGsWf3JYPnWxL9 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.4 (3.50.4-1.fc39) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hi, On Tue, 2024-03-26 at 16:02 +0100, Richard Gobert wrote: > This patch is meaningful by itself - removing checks against non-relevant > packets and making the flush/flush_id checks in a single place. I'm personally not sure this patch is a win. The code churn is significant. I understand this is for performance's sake, but I don't see the benefit???=20 The changelog shows that perf reports slightly lower figures for inet_gro_receive(). That is expected, as this patch move code out of such functio. What about inet_gro_flush()/tcp_gro_receive() where such code is moved? Additionally the reported deltas is within noise level according to my personal experience with similar tests. I think we are better off without this patch. Paolo